[jira] [Commented] (CASSANDRA-4050) Rewrite RandomAccessReader to use FileChannel / nio to address Windows file access violations
[
https://issues.apache.org/jira/browse/CASSANDRA-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962060#comment-13962060
]
Joshua McKenzie commented on CASSANDRA-4050:
New patch attached. Passes the same tests trunk does and perf is in line.
Rewrite RandomAccessReader to use FileChannel / nio to address Windows file
access violations
-
Key: CASSANDRA-4050
URL: https://issues.apache.org/jira/browse/CASSANDRA-4050
Project: Cassandra
Issue Type: Bug
Environment: Windows 7
Reporter: Jim Newsham
Assignee: Joshua McKenzie
Priority: Minor
Attachments: CASSANDRA-4050_v1.patch, CASSANDRA-4050_v2.patch
On Windows w/older java I/O libraries the files are not opened with
FILE_SHARE_DELETE. This causes problems as hard-links cannot be deleted
while the original file is opened - our snapshots are a big problem in
particular. The nio library and FileChannels open with FILE_SHARE_DELETE
which should help remedy this problem.
Original text:
I'm using Cassandra 1.0.8, on Windows 7. When I take a snapshot of the
database, I find that I am unable to delete the snapshot directory (i.e., dir
named {datadir}\{keyspacename}\snapshots\{snapshottag}) while Cassandra is
running: The action can't be completed because the folder or a file in it
is open in another program. Close the folder or file and try again [in
Windows Explorer]. If I terminate Cassandra, then I can delete the directory
with no problem.
I expect to be able to move or delete the snapshotted files while Cassandra
is running, as this should not affect the runtime operation of Cassandra.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CASSANDRA-4050) Rewrite RandomAccessReader to use FileChannel / nio to address Windows file access violations
[
https://issues.apache.org/jira/browse/CASSANDRA-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962138#comment-13962138
]
Benedict commented on CASSANDRA-4050:
-
Might want to delete skipBytes from MIS as we discussed, otherwise LGTM and
ready for commit.
Rewrite RandomAccessReader to use FileChannel / nio to address Windows file
access violations
-
Key: CASSANDRA-4050
URL: https://issues.apache.org/jira/browse/CASSANDRA-4050
Project: Cassandra
Issue Type: Bug
Environment: Windows 7
Reporter: Jim Newsham
Assignee: Joshua McKenzie
Priority: Minor
Attachments: CASSANDRA-4050_v1.patch, CASSANDRA-4050_v2.patch
On Windows w/older java I/O libraries the files are not opened with
FILE_SHARE_DELETE. This causes problems as hard-links cannot be deleted
while the original file is opened - our snapshots are a big problem in
particular. The nio library and FileChannels open with FILE_SHARE_DELETE
which should help remedy this problem.
Original text:
I'm using Cassandra 1.0.8, on Windows 7. When I take a snapshot of the
database, I find that I am unable to delete the snapshot directory (i.e., dir
named {datadir}\{keyspacename}\snapshots\{snapshottag}) while Cassandra is
running: The action can't be completed because the folder or a file in it
is open in another program. Close the folder or file and try again [in
Windows Explorer]. If I terminate Cassandra, then I can delete the directory
with no problem.
I expect to be able to move or delete the snapshotted files while Cassandra
is running, as this should not affect the runtime operation of Cassandra.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CASSANDRA-4050) Rewrite RandomAccessReader to use FileChannel / nio to address Windows file access violations
[
https://issues.apache.org/jira/browse/CASSANDRA-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962200#comment-13962200
]
Joshua McKenzie commented on CASSANDRA-4050:
Odd. I wonder if I didn't pull down that
[commit|https://github.com/josh-mckenzie/cassandra/commit/51cf8e74db1d452d99ac554bc86829376d91]
before I rebased locally. Odd since I thought I saw that on the difftool run;
I'll fix it and repost.
Rewrite RandomAccessReader to use FileChannel / nio to address Windows file
access violations
-
Key: CASSANDRA-4050
URL: https://issues.apache.org/jira/browse/CASSANDRA-4050
Project: Cassandra
Issue Type: Bug
Environment: Windows 7
Reporter: Jim Newsham
Assignee: Joshua McKenzie
Priority: Minor
Attachments: CASSANDRA-4050_v1.patch, CASSANDRA-4050_v2.patch
On Windows w/older java I/O libraries the files are not opened with
FILE_SHARE_DELETE. This causes problems as hard-links cannot be deleted
while the original file is opened - our snapshots are a big problem in
particular. The nio library and FileChannels open with FILE_SHARE_DELETE
which should help remedy this problem.
Original text:
I'm using Cassandra 1.0.8, on Windows 7. When I take a snapshot of the
database, I find that I am unable to delete the snapshot directory (i.e., dir
named {datadir}\{keyspacename}\snapshots\{snapshottag}) while Cassandra is
running: The action can't be completed because the folder or a file in it
is open in another program. Close the folder or file and try again [in
Windows Explorer]. If I terminate Cassandra, then I can delete the directory
with no problem.
I expect to be able to move or delete the snapshotted files while Cassandra
is running, as this should not affect the runtime operation of Cassandra.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CASSANDRA-4050) Rewrite RandomAccessReader to use FileChannel / nio to address Windows file access violations
[
https://issues.apache.org/jira/browse/CASSANDRA-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962212#comment-13962212
]
Joshua McKenzie commented on CASSANDRA-4050:
v3 attached. I removed the CommitLogTest changes that snuck on on the remove
skipBytes from MIS commit from you as they looked unrelated to this ticket.
Rewrite RandomAccessReader to use FileChannel / nio to address Windows file
access violations
-
Key: CASSANDRA-4050
URL: https://issues.apache.org/jira/browse/CASSANDRA-4050
Project: Cassandra
Issue Type: Bug
Environment: Windows 7
Reporter: Jim Newsham
Assignee: Joshua McKenzie
Priority: Minor
Attachments: CASSANDRA-4050_v1.patch, CASSANDRA-4050_v2.patch,
CASSANDRA-4050_v3.patch
On Windows w/older java I/O libraries the files are not opened with
FILE_SHARE_DELETE. This causes problems as hard-links cannot be deleted
while the original file is opened - our snapshots are a big problem in
particular. The nio library and FileChannels open with FILE_SHARE_DELETE
which should help remedy this problem.
Original text:
I'm using Cassandra 1.0.8, on Windows 7. When I take a snapshot of the
database, I find that I am unable to delete the snapshot directory (i.e., dir
named {datadir}\{keyspacename}\snapshots\{snapshottag}) while Cassandra is
running: The action can't be completed because the folder or a file in it
is open in another program. Close the folder or file and try again [in
Windows Explorer]. If I terminate Cassandra, then I can delete the directory
with no problem.
I expect to be able to move or delete the snapshotted files while Cassandra
is running, as this should not affect the runtime operation of Cassandra.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CASSANDRA-4050) Rewrite RandomAccessReader to use FileChannel / nio to address Windows file access violations
[
https://issues.apache.org/jira/browse/CASSANDRA-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962214#comment-13962214
]
Benedict commented on CASSANDRA-4050:
-
+1
Rewrite RandomAccessReader to use FileChannel / nio to address Windows file
access violations
-
Key: CASSANDRA-4050
URL: https://issues.apache.org/jira/browse/CASSANDRA-4050
Project: Cassandra
Issue Type: Bug
Environment: Windows 7
Reporter: Jim Newsham
Assignee: Joshua McKenzie
Priority: Minor
Attachments: CASSANDRA-4050_v1.patch, CASSANDRA-4050_v2.patch,
CASSANDRA-4050_v3.patch
On Windows w/older java I/O libraries the files are not opened with
FILE_SHARE_DELETE. This causes problems as hard-links cannot be deleted
while the original file is opened - our snapshots are a big problem in
particular. The nio library and FileChannels open with FILE_SHARE_DELETE
which should help remedy this problem.
Original text:
I'm using Cassandra 1.0.8, on Windows 7. When I take a snapshot of the
database, I find that I am unable to delete the snapshot directory (i.e., dir
named {datadir}\{keyspacename}\snapshots\{snapshottag}) while Cassandra is
running: The action can't be completed because the folder or a file in it
is open in another program. Close the folder or file and try again [in
Windows Explorer]. If I terminate Cassandra, then I can delete the directory
with no problem.
I expect to be able to move or delete the snapshotted files while Cassandra
is running, as this should not affect the runtime operation of Cassandra.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CASSANDRA-4050) Rewrite RandomAccessReader to use FileChannel / nio to address Windows file access violations
[
https://issues.apache.org/jira/browse/CASSANDRA-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960469#comment-13960469
]
Joshua McKenzie commented on CASSANDRA-4050:
I'll rebase your branch against trunk and post a revised patch early next week.
I know how much you love rebasing and I figure I owe you one for the
house-cleaning on this patch. ;)
Rewrite RandomAccessReader to use FileChannel / nio to address Windows file
access violations
-
Key: CASSANDRA-4050
URL: https://issues.apache.org/jira/browse/CASSANDRA-4050
Project: Cassandra
Issue Type: Bug
Environment: Windows 7
Reporter: Jim Newsham
Assignee: Joshua McKenzie
Priority: Minor
Attachments: CASSANDRA-4050_v1.patch
On Windows w/older java I/O libraries the files are not opened with
FILE_SHARE_DELETE. This causes problems as hard-links cannot be deleted
while the original file is opened - our snapshots are a big problem in
particular. The nio library and FileChannels open with FILE_SHARE_DELETE
which should help remedy this problem.
Original text:
I'm using Cassandra 1.0.8, on Windows 7. When I take a snapshot of the
database, I find that I am unable to delete the snapshot directory (i.e., dir
named {datadir}\{keyspacename}\snapshots\{snapshottag}) while Cassandra is
running: The action can't be completed because the folder or a file in it
is open in another program. Close the folder or file and try again [in
Windows Explorer]. If I terminate Cassandra, then I can delete the directory
with no problem.
I expect to be able to move or delete the snapshotted files while Cassandra
is running, as this should not affect the runtime operation of Cassandra.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
