[jira] [Commented] (CASSANDRA-4079) Check SSTable range before running cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254974#comment-13254974 ] Jonathan Ellis commented on CASSANDRA-4079: --- couldn't leave well enough alone ... https://github.com/jbellis/cassandra/branches/4079-4 makes AB.intersects non-abstract and pushes the type check into Range.insersects(AB). I like this a little better since it lets me comment why I'm leaving the EB/IEB unimplemented in an obvious place. > Check SSTable range before running cleanup > -- > > Key: CASSANDRA-4079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4079 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benjamin Coverston >Assignee: Jonathan Ellis >Priority: Minor > Labels: compaction > Fix For: 1.1.1 > > Attachments: 4079.txt > > > Before running a cleanup compaction on an SSTable we should check the range > to see if the SSTable falls into the range we want to remove. If it doesn't > we can just mark the SSTable as compacted and be done with it, if it does, we > can no-op. > Will not help with STCS, but for LCS, and perhaps some others we may see a > benefit here after topology changes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4079) Check SSTable range before running cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254955#comment-13254955 ] Sylvain Lebresne commented on CASSANDRA-4079: - lgtm +1 > Check SSTable range before running cleanup > -- > > Key: CASSANDRA-4079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4079 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benjamin Coverston >Assignee: Jonathan Ellis >Priority: Minor > Labels: compaction > Fix For: 1.1.1 > > Attachments: 4079.txt > > > Before running a cleanup compaction on an SSTable we should check the range > to see if the SSTable falls into the range we want to remove. If it doesn't > we can just mark the SSTable as compacted and be done with it, if it does, we > can no-op. > Will not help with STCS, but for LCS, and perhaps some others we may see a > benefit here after topology changes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4079) Check SSTable range before running cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254948#comment-13254948 ] Jonathan Ellis commented on CASSANDRA-4079: --- Changed to an abstract method in AB at https://github.com/jbellis/cassandra/branches/4079-3 > Check SSTable range before running cleanup > -- > > Key: CASSANDRA-4079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4079 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benjamin Coverston >Assignee: Jonathan Ellis >Priority: Minor > Labels: compaction > Fix For: 1.1.1 > > Attachments: 4079.txt > > > Before running a cleanup compaction on an SSTable we should check the range > to see if the SSTable falls into the range we want to remove. If it doesn't > we can just mark the SSTable as compacted and be done with it, if it does, we > can no-op. > Will not help with STCS, but for LCS, and perhaps some others we may see a > benefit here after topology changes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4079) Check SSTable range before running cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254714#comment-13254714 ] Sylvain Lebresne commented on CASSANDRA-4079: - A small nit: I know this is a bit of a mess, but we also have ExcludingBounds and IncludingExcludingBounds that extends AbstractBounds which Range.intersects() doesn't handle. I don't think we should bother supporting them here since we don't need it, but I'd prefer protecting against future misuse of interests. I'd also prefer not having the method static for no good reason. Typically I would add intersects as a method of Bounds (that would take a list of Range). > Check SSTable range before running cleanup > -- > > Key: CASSANDRA-4079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4079 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benjamin Coverston >Assignee: Jonathan Ellis >Priority: Minor > Labels: compaction > Fix For: 1.1.1 > > Attachments: 4079.txt > > > Before running a cleanup compaction on an SSTable we should check the range > to see if the SSTable falls into the range we want to remove. If it doesn't > we can just mark the SSTable as compacted and be done with it, if it does, we > can no-op. > Will not help with STCS, but for LCS, and perhaps some others we may see a > benefit here after topology changes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4079) Check SSTable range before running cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253779#comment-13253779 ] Benjamin Coverston commented on CASSANDRA-4079: --- +1 on the revised patch > Check SSTable range before running cleanup > -- > > Key: CASSANDRA-4079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4079 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benjamin Coverston >Assignee: Jonathan Ellis >Priority: Minor > Labels: compaction > Fix For: 1.1.1 > > Attachments: 4079.txt > > > Before running a cleanup compaction on an SSTable we should check the range > to see if the SSTable falls into the range we want to remove. If it doesn't > we can just mark the SSTable as compacted and be done with it, if it does, we > can no-op. > Will not help with STCS, but for LCS, and perhaps some others we may see a > benefit here after topology changes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4079) Check SSTable range before running cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239636#comment-13239636 ] Jonathan Ellis commented on CASSANDRA-4079: --- v2 posted to https://github.com/jbellis/cassandra/branches/4079 > Check SSTable range before running cleanup > -- > > Key: CASSANDRA-4079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4079 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benjamin Coverston >Assignee: Jonathan Ellis >Priority: Minor > Labels: compaction > Fix For: 1.1.1 > > Attachments: 4079.txt > > > Before running a cleanup compaction on an SSTable we should check the range > to see if the SSTable falls into the range we want to remove. If it doesn't > we can just mark the SSTable as compacted and be done with it, if it does, we > can no-op. > Will not help with STCS, but for LCS, and perhaps some others we may see a > benefit here after topology changes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4079) Check SSTable range before running cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239489#comment-13239489 ] Sylvain Lebresne commented on CASSANDRA-4079: - The fact that the first and last token are not in the node ranges does not imply the sstable has no data for those ranges. Also, we'd want to skip (but not delete) the sstable if it is fully included in the new node ranges. As a side node, I would really prefer moving this to 1.1.1 and sticking to bug-fix-that-prevent-release for 1.1.0 at this point. > Check SSTable range before running cleanup > -- > > Key: CASSANDRA-4079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4079 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benjamin Coverston >Assignee: Jonathan Ellis >Priority: Minor > Labels: compaction > Fix For: 1.1.0 > > Attachments: 4079.txt > > > Before running a cleanup compaction on an SSTable we should check the range > to see if the SSTable falls into the range we want to remove. If it doesn't > we can just mark the SSTable as compacted and be done with it, if it does, we > can no-op. > Will not help with STCS, but for LCS, and perhaps some others we may see a > benefit here after topology changes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
