[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409590#comment-13409590
]
Jonathan Ellis commented on CASSANDRA-4121:
---
Looks good.
One question, can you clarify what resetEndpoints is doing in
updateNormalTokens?
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
Fix For: 1.2
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409625#comment-13409625
]
Sam Overton commented on CASSANDRA-4121:
updateNormalTokens has to remove any existing token mapping(s) from
tokenToEndpointMap and remove the endpoint from bootstrapping/leaving/moving
collections. resetEndpoints is just storing which endpoints we have already
done this for, to ensure it is only done once for each endpoint, the first time
we see it when iterating through tokenPairs.
The method should probably take MultimapInetAddress, Token instead of a
SetPairToken, InetAddress which would simplify this logic somewhat.
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
Fix For: 1.2
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409642#comment-13409642
]
Jonathan Ellis commented on CASSANDRA-4121:
---
SGTM.
bq. The method should probably take MultimapInetAddress, Token
+1, looks straightforward
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
Fix For: 1.2
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409677#comment-13409677
]
Sam Overton commented on CASSANDRA-4121:
change updateNormalTokens method signature to take Multimap instead of
SetPair:
https://github.com/acunu/cassandra/commit/e0482c42a821bfdaacd23c0a02086a34dfb094de
([raw
diff|https://github.com/acunu/cassandra/commit/e0482c42a821bfdaacd23c0a02086a34dfb094de.diff])
Patch updated.
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
Fix For: 1.2
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409683#comment-13409683
]
Jonathan Ellis commented on CASSANDRA-4121:
---
+1
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
Fix For: 1.2
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409913#comment-13409913
]
Eric Evans commented on CASSANDRA-4121:
---
committed; thanks everyone!
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
Fix For: 1.2
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408317#comment-13408317
]
Jonathan Ellis commented on CASSANDRA-4121:
---
Sorry, I think CASSANDRA-3047 broke the diff. Can you rebase?
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
Fix For: 1.2
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408549#comment-13408549
]
Eric Evans commented on CASSANDRA-4121:
---
Wow, that was... an ordeal.
I'm not sure CASSANDRA-3047 is really the right way to visualize things in a
post-vnodes world, but we can probably wait to cross that bridge in
CASSANDRA-4125.
Everything is synced up with trunk now.
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
Fix For: 1.2
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407024#comment-13407024
]
Sam Overton commented on CASSANDRA-4121:
Removed synchronization in the BMVMaps:
https://github.com/acunu/cassandra/commit/0c8aac3854b0f5a14c3f89e1480cd96d7d6642e6
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
Fix For: 1.2
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406515#comment-13406515
]
Sam Overton commented on CASSANDRA-4121:
bq. If we do go with these wrappers I'd prefer to keep it as thin as possible –
no internal synchronization, no copies on inverse(). (I think the existing
synchronizied wrapper around the bootstrapTokens BiMap saves us exactly one use
of the explicit lock, in pendingRangeChanges. I'm fine with giving that up.)
I think given the changes to synchronization in TokenMetadata for
CASSANDRA-3881 I will revisit synchronization in these BMVMaps - they can
probably just rely on the ReadWriteLock in TMD. Re: no copies on inverse() -
unmodifiableMultimap just makes the returned inverse map immutable, there is no
copy.
bq. I think the code reads better with, than without them, but I can understand
the argument for keeping them thin. Sam?
I do think these wrappers are useful. It cuts down on the size of the interface
that TMD has to provide. Looking up the endpoint to tokens mapping in both
directions is useful and we already use the reverse mapping of bootstrapTokens
in SS.calculatePendingRanges(). I would be tempted to make
TMD.getEndpointToTokenMapForReading return the BMVMap too (currently it copies
into a Multimap).
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
Fix For: 1.2
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405967#comment-13405967
]
Jonathan Ellis commented on CASSANDRA-4121:
---
Time to look at this with CASSANDRA-3881 committed?
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406090#comment-13406090
]
Eric Evans commented on CASSANDRA-4121:
---
bq. If we do go with these wrappers I'd prefer to keep it as thin as possible –
no internal synchronization, no copies on inverse(). (I think the existing
synchronizied wrapper around the bootstrapTokens BiMap saves us exactly one use
of the explicit lock, in pendingRangeChanges. I'm fine with giving that up.)
I think the code reads better with, than without them, but I can understand the
argument for keeping them thin. Sam?
bq. Would it simplify things to make calculateNaturalEndpoints return Set?
getNaturalEndpoints can still copy into an ArrayList for callers that want to
sort.
I'm not sure it will simplify the existing code per say, but it's probably more
correct.
bq. forceTableRepairPrimaryRange could use FBUtilities.waitOnFutures
I updated the patch to make it use FBUtilities.waitOnFuture (singular); The mix
of unparametized and wildcard generic Futures is kind of a mess here.
{quote}
* @Override on SBMVM is redundant
* some redundant type information on .create calls
{quote}
Done.
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
Fix For: 1.2
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4121) TokenMetadata supports multiple tokens per host
[
https://issues.apache.org/jira/browse/CASSANDRA-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401657#comment-13401657
]
Jonathan Ellis commented on CASSANDRA-4121:
---
The big question mark in my mind is if BMVM and SBMVM are worth the complexity
(and potential for bugs) over just inlining the Map/Multimap pair into TMD.
Most operations on tokenToEndpointMap and bootstrapTokens touch other
collections already, and need to be explicitly locked anyway.
I guess the big win is that it makes the new code a lot more 1:1 with what it
replaces, which may be enough to justify it. But you still can't get away from
looping where you used to have a single Token per endpoint...
If we do go with these wrappers I'd prefer to keep it as thin as possible -- no
internal synchronization, no copies on inverse(). (I think the existing
synchronizied wrapper around the bootstrapTokens BiMap saves us exactly one use
of the explicit lock, in pendingRangeChanges. I'm fine with giving that up.)
Other comments:
- Would it simplify things to make calculateNaturalEndpoints return Set?
getNaturalEndpoints can still copy into an ArrayList for callers that want to
sort.
- forceTableRepairPrimaryRange could use FBUtilities.waitOnFutures
- @Override on SBMVM is redundant
- some redundant type information on .create calls
TokenMetadata supports multiple tokens per host
---
Key: CASSANDRA-4121
URL: https://issues.apache.org/jira/browse/CASSANDRA-4121
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Sam Overton
Assignee: Sam Overton
Labels: vnodes
_Edit0: Append patch information._
h3. Patches
||Compare||Raw diff||Description||
|[01_support_multiple_tokens_per_host|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host]|[01_support_multiple_tokens_per_host.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4121/01_support_multiple_tokens_per_host...p/4121/01_support_multiple_tokens_per_host.diff]|Support
associating more than one token per node|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
