[jira] [Commented] (CASSANDRA-4655) Truncate operation doesn't delete rows from HintsColumnFamily.
[ https://issues.apache.org/jira/browse/CASSANDRA-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664804#comment-13664804 ] Vijay commented on CASSANDRA-4655: -- +1 > Truncate operation doesn't delete rows from HintsColumnFamily. > -- > > Key: CASSANDRA-4655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4655 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 0.7.0 > Environment: Centos 6.2, Cassandra 1.1.4 (DataStax distribution), > three-nodes cluster. >Reporter: Alexey Zotov >Assignee: Jonathan Ellis >Priority: Minor > Labels: hintedhandoff, truncate > Fix For: 1.2.6 > > Attachments: 4655-v3.txt, cassandra-1.2-4655-hints_truncation.txt, > cassandra-1.2-4655-hints_truncation-v2.txt > > > Steps to reproduce: > 1. Start writing of data to some column family, let name it 'MyCF' > 2. Stop 1 node > 3. Wait some time (until some data will be collected in HintsColumnFamily) > 4. Start node (HintedHandoff will be started automatically for 'MyCF') > 5. Run 'truncate' command for 'MyCF' column family from command from cli > 6. Wait until truncate will be finished > 7. You will see that 'MyCF' is not empty because HintedHandoff is copying > data > So, I suggest to clean HintsColumnFamily (for truncated column family) before > we had started to discard sstables. > I think it should be done in CompactionManager#submitTrucate() method. I can > try to create patch but I need to know right way of cleaning > HintsColumnFamily. Could you clarify it? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4655) Truncate operation doesn't delete rows from HintsColumnFamily.
[ https://issues.apache.org/jira/browse/CASSANDRA-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612753#comment-13612753 ] Jonathan Ellis commented on CASSANDRA-4655: --- Ping [~azotcsit] > Truncate operation doesn't delete rows from HintsColumnFamily. > -- > > Key: CASSANDRA-4655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4655 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 0.7.0 > Environment: Centos 6.2, Cassandra 1.1.4 (DataStax distribution), > three-nodes cluster. >Reporter: Alexey Zotov >Assignee: Alexey Zotov >Priority: Minor > Labels: hintedhandoff, truncate > Fix For: 1.2.4 > > Attachments: cassandra-1.2-4655-hints_truncation.txt, > cassandra-1.2-4655-hints_truncation-v2.txt > > > Steps to reproduce: > 1. Start writing of data to some column family, let name it 'MyCF' > 2. Stop 1 node > 3. Wait some time (until some data will be collected in HintsColumnFamily) > 4. Start node (HintedHandoff will be started automatically for 'MyCF') > 5. Run 'truncate' command for 'MyCF' column family from command from cli > 6. Wait until truncate will be finished > 7. You will see that 'MyCF' is not empty because HintedHandoff is copying > data > So, I suggest to clean HintsColumnFamily (for truncated column family) before > we had started to discard sstables. > I think it should be done in CompactionManager#submitTrucate() method. I can > try to create patch but I need to know right way of cleaning > HintsColumnFamily. Could you clarify it? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4655) Truncate operation doesn't delete rows from HintsColumnFamily.
[ https://issues.apache.org/jira/browse/CASSANDRA-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588180#comment-13588180 ] Vijay commented on CASSANDRA-4655: -- Overall LGTM, Do we really need to remove removeTruncationTime? IMHO it might be a useful information for the user to query. Instead of caching the truncatedAt in CFS can we just cache it in deliverHintsToEndpointInternal? coz it wont be thread safe in CFS anyways. > Truncate operation doesn't delete rows from HintsColumnFamily. > -- > > Key: CASSANDRA-4655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4655 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 0.7.0 > Environment: Centos 6.2, Cassandra 1.1.4 (DataStax distribution), > three-nodes cluster. >Reporter: Alexey Zotov >Assignee: Alexey Zotov >Priority: Minor > Labels: hintedhandoff, truncate > Fix For: 1.2.3 > > Attachments: cassandra-1.2-4655-hints_truncation.txt, > cassandra-1.2-4655-hints_truncation-v2.txt > > > Steps to reproduce: > 1. Start writing of data to some column family, let name it 'MyCF' > 2. Stop 1 node > 3. Wait some time (until some data will be collected in HintsColumnFamily) > 4. Start node (HintedHandoff will be started automatically for 'MyCF') > 5. Run 'truncate' command for 'MyCF' column family from command from cli > 6. Wait until truncate will be finished > 7. You will see that 'MyCF' is not empty because HintedHandoff is copying > data > So, I suggest to clean HintsColumnFamily (for truncated column family) before > we had started to discard sstables. > I think it should be done in CompactionManager#submitTrucate() method. I can > try to create patch but I need to know right way of cleaning > HintsColumnFamily. Could you clarify it? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4655) Truncate operation doesn't delete rows from HintsColumnFamily.
[ https://issues.apache.org/jira/browse/CASSANDRA-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492722#comment-13492722 ] Jonathan Ellis commented on CASSANDRA-4655: --- Are you still working on this, Alexey? > Truncate operation doesn't delete rows from HintsColumnFamily. > -- > > Key: CASSANDRA-4655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4655 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 0.7.0 > Environment: Centos 6.2, Cassandra 1.1.4 (DataStax distribution), > three-nodes cluster. >Reporter: Alexey Zotov >Assignee: Alexey Zotov >Priority: Minor > Labels: hintedhandoff, truncate > Fix For: 1.2.1 > > Attachments: cassandra-1.2-4655-hints_truncation.txt > > > Steps to reproduce: > 1. Start writing of data to some column family, let name it 'MyCF' > 2. Stop 1 node > 3. Wait some time (until some data will be collected in HintsColumnFamily) > 4. Start node (HintedHandoff will be started automatically for 'MyCF') > 5. Run 'truncate' command for 'MyCF' column family from command from cli > 6. Wait until truncate will be finished > 7. You will see that 'MyCF' is not empty because HintedHandoff is copying > data > So, I suggest to clean HintsColumnFamily (for truncated column family) before > we had started to discard sstables. > I think it should be done in CompactionManager#submitTrucate() method. I can > try to create patch but I need to know right way of cleaning > HintsColumnFamily. Could you clarify it? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4655) Truncate operation doesn't delete rows from HintsColumnFamily.
[
https://issues.apache.org/jira/browse/CASSANDRA-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463889#comment-13463889
]
Jonathan Ellis commented on CASSANDRA-4655:
---
Two things:
# Need to store last truncation time across server restart. Storing these as a
Map in {{system.local}} is one option. ({{system}} columnfamilies are defined
in CFMetaData.)
# Instead of skipping the entire hint if any component CF has been truncated,
should generate a new RowMutation with only untruncated CF data in it.
> Truncate operation doesn't delete rows from HintsColumnFamily.
> --
>
> Key: CASSANDRA-4655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4655
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Affects Versions: 0.7.0
> Environment: Centos 6.2, Cassandra 1.1.4 (DataStax distribution),
> three-nodes cluster.
>Reporter: Alexey Zotov
>Assignee: Alexey Zotov
>Priority: Minor
> Labels: hintedhandoff, truncate
> Fix For: 1.2.1
>
> Attachments: cassandra-1.2-4655-hints_truncation.txt
>
>
> Steps to reproduce:
> 1. Start writing of data to some column family, let name it 'MyCF'
> 2. Stop 1 node
> 3. Wait some time (until some data will be collected in HintsColumnFamily)
> 4. Start node (HintedHandoff will be started automatically for 'MyCF')
> 5. Run 'truncate' command for 'MyCF' column family from command from cli
> 6. Wait until truncate will be finished
> 7. You will see that 'MyCF' is not empty because HintedHandoff is copying
> data
> So, I suggest to clean HintsColumnFamily (for truncated column family) before
> we had started to discard sstables.
> I think it should be done in CompactionManager#submitTrucate() method. I can
> try to create patch but I need to know right way of cleaning
> HintsColumnFamily. Could you clarify it?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4655) Truncate operation doesn't delete rows from HintsColumnFamily.
[ https://issues.apache.org/jira/browse/CASSANDRA-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463614#comment-13463614 ] Alexey Zotov commented on CASSANDRA-4655: - Patch has been attached. Please review it. > Truncate operation doesn't delete rows from HintsColumnFamily. > -- > > Key: CASSANDRA-4655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4655 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 0.7.0 > Environment: Centos 6.2, Cassandra 1.1.4 (DataStax distribution), > three-nodes cluster. >Reporter: Alexey Zotov >Assignee: Alexey Zotov >Priority: Minor > Labels: hintedhandoff, truncate > Fix For: 1.2.1 > > Attachments: cassandra-1.2-4655-hints_truncation.txt > > > Steps to reproduce: > 1. Start writing of data to some column family, let name it 'MyCF' > 2. Stop 1 node > 3. Wait some time (until some data will be collected in HintsColumnFamily) > 4. Start node (HintedHandoff will be started automatically for 'MyCF') > 5. Run 'truncate' command for 'MyCF' column family from command from cli > 6. Wait until truncate will be finished > 7. You will see that 'MyCF' is not empty because HintedHandoff is copying > data > So, I suggest to clean HintsColumnFamily (for truncated column family) before > we had started to discard sstables. > I think it should be done in CompactionManager#submitTrucate() method. I can > try to create patch but I need to know right way of cleaning > HintsColumnFamily. Could you clarify it? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4655) Truncate operation doesn't delete rows from HintsColumnFamily.
[ https://issues.apache.org/jira/browse/CASSANDRA-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461690#comment-13461690 ] Alexey Zotov commented on CASSANDRA-4655: - Good idea. I'll try to implement it. > Truncate operation doesn't delete rows from HintsColumnFamily. > -- > > Key: CASSANDRA-4655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4655 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 0.7.0 > Environment: Centos 6.2, Cassandra 1.1.4 (DataStax distribution), > three-nodes cluster. >Reporter: Alexey Zotov >Priority: Minor > > Steps to reproduce: > 1. Start writing of data to some column family, let name it 'MyCF' > 2. Stop 1 node > 3. Wait some time (until some data will be collected in HintsColumnFamily) > 4. Start node (HintedHandoff will be started automatically for 'MyCF') > 5. Run 'truncate' command for 'MyCF' column family from command from cli > 6. Wait until truncate will be finished > 7. You will see that 'MyCF' is not empty because HintedHandoff is copying > data > So, I suggest to clean HintsColumnFamily (for truncated column family) before > we had started to discard sstables. > I think it should be done in CompactionManager#submitTrucate() method. I can > try to create patch but I need to know right way of cleaning > HintsColumnFamily. Could you clarify it? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4655) Truncate operation doesn't delete rows from HintsColumnFamily.
[ https://issues.apache.org/jira/browse/CASSANDRA-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460603#comment-13460603 ] Jonathan Ellis commented on CASSANDRA-4655: --- Maybe it would be easier to record truncate time and drop hints older than that on replay, than to make truncate a two-pass operation. > Truncate operation doesn't delete rows from HintsColumnFamily. > -- > > Key: CASSANDRA-4655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4655 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 0.7.0 > Environment: Centos 6.2, Cassandra 1.1.4 (DataStax distribution), > three-nodes cluster. >Reporter: Alexey Zotov >Priority: Minor > > Steps to reproduce: > 1. Start writing of data to some column family, let name it 'MyCF' > 2. Stop 1 node > 3. Wait some time (until some data will be collected in HintsColumnFamily) > 4. Start node (HintedHandoff will be started automatically for 'MyCF') > 5. Run 'truncate' command for 'MyCF' column family from command from cli > 6. Wait until truncate will be finished > 7. You will see that 'MyCF' is not empty because HintedHandoff is copying > data > So, I suggest to clean HintsColumnFamily (for truncated column family) before > we had started to discard sstables. > I think it should be done in CompactionManager#submitTrucate() method. I can > try to create patch but I need to know right way of cleaning > HintsColumnFamily. Could you clarify it? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
