[jira] [Commented] (CASSANDRA-5334) Don't announce migrations to pre-1.2 nodes

2013-03-13 Thread Ryan McGuire (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601708#comment-13601708
 ] 

Ryan McGuire commented on CASSANDRA-5334:
-

hmm, looks like the same NPE is coming from a different place than before:

{code}
java.lang.NullPointerException
at 
org.apache.cassandra.utils.ByteBufferUtil.string(ByteBufferUtil.java:167)
at 
org.apache.cassandra.utils.ByteBufferUtil.string(ByteBufferUtil.java:124)
at org.apache.cassandra.cql.jdbc.JdbcUTF8.getString(JdbcUTF8.java:77)
at org.apache.cassandra.cql.jdbc.JdbcUTF8.compose(JdbcUTF8.java:97)
at org.apache.cassandra.db.marshal.UTF8Type.compose(UTF8Type.java:35)
at 
org.apache.cassandra.cql3.UntypedResultSet$Row.getString(UntypedResultSet.java:87)
at 
org.apache.cassandra.config.KSMetaData.fromSchema(KSMetaData.java:256)
at org.apache.cassandra.db.DefsTable.mergeKeyspaces(DefsTable.java:397)
at org.apache.cassandra.db.DefsTable.mergeSchema(DefsTable.java:373)
at 
org.apache.cassandra.db.DefsTable.mergeRemoteSchema(DefsTable.java:352)
at 
org.apache.cassandra.service.MigrationManager$MigrationTask$1.response(MigrationManager.java:453)
at 
org.apache.cassandra.net.ResponseVerbHandler.doVerb(ResponseVerbHandler.java:45)
at 
org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:59)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
{code}

> Don't announce migrations to pre-1.2 nodes
> --
>
> Key: CASSANDRA-5334
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5334
> Project: Cassandra
>  Issue Type: Bug
>Affects Versions: 1.1.9
>Reporter: Ryan McGuire
>Assignee: Ryan McGuire
> Fix For: 1.2.3
>
> Attachments: 5334.patch, 5334-v2.txt, cassandra.trunk.yaml
>
>
> I have a mixed version cluster consisting of two 1.1.9 nodes and one 1.2.2 
> node upgraded from 1.1.9. 
> The upgrade works, and I don't see any end user problems, however I see this 
> exception in the logs on the non-upgraded nodes:
> {code}
> ERROR [MigrationStage:1] 2013-03-11 18:09:09,001 AbstractCassandraDaemon.java 
> (line 135) Exception in thread Thread[MigrationStage:1,5,main]
> java.lang.NullPointerException
>   at 
> org.apache.cassandra.utils.ByteBufferUtil.string(ByteBufferUtil.java:167)
>   at 
> org.apache.cassandra.utils.ByteBufferUtil.string(ByteBufferUtil.java:124)
>   at org.apache.cassandra.cql.jdbc.JdbcUTF8.getString(JdbcUTF8.java:77)
>   at org.apache.cassandra.cql.jdbc.JdbcUTF8.compose(JdbcUTF8.java:97)
>   at org.apache.cassandra.db.marshal.UTF8Type.compose(UTF8Type.java:35)
>   at 
> org.apache.cassandra.cql3.UntypedResultSet$Row.getString(UntypedResultSet.java:87)
>   at 
> org.apache.cassandra.config.KSMetaData.fromSchema(KSMetaData.java:256)
>   at org.apache.cassandra.db.DefsTable.mergeKeyspaces(DefsTable.java:397)
>   at org.apache.cassandra.db.DefsTable.mergeSchema(DefsTable.java:373)
>   at 
> org.apache.cassandra.db.DefsTable.mergeRemoteSchema(DefsTable.java:352)
>   at 
> org.apache.cassandra.db.DefinitionsUpdateVerbHandler$1.runMayThrow(DefinitionsUpdateVerbHandler.java:48)
>   at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
>   at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:138)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>   at java.lang.Thread.run(Thread.java:662)
> {code}
> Steps to reproduce:
> {code}
> ccm create -v 1.1.9 1.1.9
> ccm populate -n 3
> ccm start
> ccm node1 stress
> ccm node1 stop
> {code}
> edit ~/.ccm/1.1.9/cluster.conf and configure cassandra_dir to point to 1.2.2. 
> Edit node1's cassandra.yaml to be 1.2 compliant.
> {code}
> ccm node1 start
> {code}
> The cluster is now a mixed version, and works for user queries, but with the 
> exception above.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5334) Don't announce migrations to pre-1.2 nodes

2013-03-13 Thread Ryan McGuire (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601723#comment-13601723
 ] 

Ryan McGuire commented on CASSANDRA-5334:
-

giving this back to [~iamaleksey] to revisit "IIRC we already have code to 
prevent 1.1 from pulling the schema from 1.2 nodes."

> Don't announce migrations to pre-1.2 nodes
> --
>
> Key: CASSANDRA-5334
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5334
> Project: Cassandra
>  Issue Type: Bug
>Affects Versions: 1.1.9
>Reporter: Ryan McGuire
>Assignee: Aleksey Yeschenko
> Fix For: 1.2.3
>
> Attachments: 5334.patch, 5334-v2.txt, cassandra.trunk.yaml
>
>
> I have a mixed version cluster consisting of two 1.1.9 nodes and one 1.2.2 
> node upgraded from 1.1.9. 
> The upgrade works, and I don't see any end user problems, however I see this 
> exception in the logs on the non-upgraded nodes:
> {code}
> ERROR [MigrationStage:1] 2013-03-11 18:09:09,001 AbstractCassandraDaemon.java 
> (line 135) Exception in thread Thread[MigrationStage:1,5,main]
> java.lang.NullPointerException
>   at 
> org.apache.cassandra.utils.ByteBufferUtil.string(ByteBufferUtil.java:167)
>   at 
> org.apache.cassandra.utils.ByteBufferUtil.string(ByteBufferUtil.java:124)
>   at org.apache.cassandra.cql.jdbc.JdbcUTF8.getString(JdbcUTF8.java:77)
>   at org.apache.cassandra.cql.jdbc.JdbcUTF8.compose(JdbcUTF8.java:97)
>   at org.apache.cassandra.db.marshal.UTF8Type.compose(UTF8Type.java:35)
>   at 
> org.apache.cassandra.cql3.UntypedResultSet$Row.getString(UntypedResultSet.java:87)
>   at 
> org.apache.cassandra.config.KSMetaData.fromSchema(KSMetaData.java:256)
>   at org.apache.cassandra.db.DefsTable.mergeKeyspaces(DefsTable.java:397)
>   at org.apache.cassandra.db.DefsTable.mergeSchema(DefsTable.java:373)
>   at 
> org.apache.cassandra.db.DefsTable.mergeRemoteSchema(DefsTable.java:352)
>   at 
> org.apache.cassandra.db.DefinitionsUpdateVerbHandler$1.runMayThrow(DefinitionsUpdateVerbHandler.java:48)
>   at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
>   at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:138)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>   at java.lang.Thread.run(Thread.java:662)
> {code}
> Steps to reproduce:
> {code}
> ccm create -v 1.1.9 1.1.9
> ccm populate -n 3
> ccm start
> ccm node1 stress
> ccm node1 stop
> {code}
> edit ~/.ccm/1.1.9/cluster.conf and configure cassandra_dir to point to 1.2.2. 
> Edit node1's cassandra.yaml to be 1.2 compliant.
> {code}
> ccm node1 start
> {code}
> The cluster is now a mixed version, and works for user queries, but with the 
> exception above.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5334) Don't announce migrations to pre-1.2 nodes

2013-03-13 Thread Ryan McGuire (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601780#comment-13601780
 ] 

Ryan McGuire commented on CASSANDRA-5334:
-

Great, 5334-extra seems to clear up the intermittent failures. At least, I ran 
my dtest 10 times before and it failed half the time, and now I ran it 10 times 
with no failures.

> Don't announce migrations to pre-1.2 nodes
> --
>
> Key: CASSANDRA-5334
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5334
> Project: Cassandra
>  Issue Type: Bug
>Affects Versions: 1.1.9
>Reporter: Ryan McGuire
>Assignee: Aleksey Yeschenko
> Fix For: 1.2.3
>
> Attachments: 5334-extra.txt, 5334.patch, 5334-v2.txt, 
> cassandra.trunk.yaml
>
>
> I have a mixed version cluster consisting of two 1.1.9 nodes and one 1.2.2 
> node upgraded from 1.1.9. 
> The upgrade works, and I don't see any end user problems, however I see this 
> exception in the logs on the non-upgraded nodes:
> {code}
> ERROR [MigrationStage:1] 2013-03-11 18:09:09,001 AbstractCassandraDaemon.java 
> (line 135) Exception in thread Thread[MigrationStage:1,5,main]
> java.lang.NullPointerException
>   at 
> org.apache.cassandra.utils.ByteBufferUtil.string(ByteBufferUtil.java:167)
>   at 
> org.apache.cassandra.utils.ByteBufferUtil.string(ByteBufferUtil.java:124)
>   at org.apache.cassandra.cql.jdbc.JdbcUTF8.getString(JdbcUTF8.java:77)
>   at org.apache.cassandra.cql.jdbc.JdbcUTF8.compose(JdbcUTF8.java:97)
>   at org.apache.cassandra.db.marshal.UTF8Type.compose(UTF8Type.java:35)
>   at 
> org.apache.cassandra.cql3.UntypedResultSet$Row.getString(UntypedResultSet.java:87)
>   at 
> org.apache.cassandra.config.KSMetaData.fromSchema(KSMetaData.java:256)
>   at org.apache.cassandra.db.DefsTable.mergeKeyspaces(DefsTable.java:397)
>   at org.apache.cassandra.db.DefsTable.mergeSchema(DefsTable.java:373)
>   at 
> org.apache.cassandra.db.DefsTable.mergeRemoteSchema(DefsTable.java:352)
>   at 
> org.apache.cassandra.db.DefinitionsUpdateVerbHandler$1.runMayThrow(DefinitionsUpdateVerbHandler.java:48)
>   at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
>   at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:138)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>   at java.lang.Thread.run(Thread.java:662)
> {code}
> Steps to reproduce:
> {code}
> ccm create -v 1.1.9 1.1.9
> ccm populate -n 3
> ccm start
> ccm node1 stress
> ccm node1 stop
> {code}
> edit ~/.ccm/1.1.9/cluster.conf and configure cassandra_dir to point to 1.2.2. 
> Edit node1's cassandra.yaml to be 1.2 compliant.
> {code}
> ccm node1 start
> {code}
> The cluster is now a mixed version, and works for user queries, but with the 
> exception above.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5334) Don't announce migrations to pre-1.2 nodes

2013-03-13 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601850#comment-13601850
 ] 

Jonathan Ellis commented on CASSANDRA-5334:
---

+1

> Don't announce migrations to pre-1.2 nodes
> --
>
> Key: CASSANDRA-5334
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5334
> Project: Cassandra
>  Issue Type: Bug
>Affects Versions: 1.1.9
>Reporter: Ryan McGuire
>Assignee: Aleksey Yeschenko
> Fix For: 1.2.3
>
> Attachments: 5334-extra.txt, 5334.patch, 5334-v2.txt, 
> cassandra.trunk.yaml
>
>
> I have a mixed version cluster consisting of two 1.1.9 nodes and one 1.2.2 
> node upgraded from 1.1.9. 
> The upgrade works, and I don't see any end user problems, however I see this 
> exception in the logs on the non-upgraded nodes:
> {code}
> ERROR [MigrationStage:1] 2013-03-11 18:09:09,001 AbstractCassandraDaemon.java 
> (line 135) Exception in thread Thread[MigrationStage:1,5,main]
> java.lang.NullPointerException
>   at 
> org.apache.cassandra.utils.ByteBufferUtil.string(ByteBufferUtil.java:167)
>   at 
> org.apache.cassandra.utils.ByteBufferUtil.string(ByteBufferUtil.java:124)
>   at org.apache.cassandra.cql.jdbc.JdbcUTF8.getString(JdbcUTF8.java:77)
>   at org.apache.cassandra.cql.jdbc.JdbcUTF8.compose(JdbcUTF8.java:97)
>   at org.apache.cassandra.db.marshal.UTF8Type.compose(UTF8Type.java:35)
>   at 
> org.apache.cassandra.cql3.UntypedResultSet$Row.getString(UntypedResultSet.java:87)
>   at 
> org.apache.cassandra.config.KSMetaData.fromSchema(KSMetaData.java:256)
>   at org.apache.cassandra.db.DefsTable.mergeKeyspaces(DefsTable.java:397)
>   at org.apache.cassandra.db.DefsTable.mergeSchema(DefsTable.java:373)
>   at 
> org.apache.cassandra.db.DefsTable.mergeRemoteSchema(DefsTable.java:352)
>   at 
> org.apache.cassandra.db.DefinitionsUpdateVerbHandler$1.runMayThrow(DefinitionsUpdateVerbHandler.java:48)
>   at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
>   at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:138)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>   at java.lang.Thread.run(Thread.java:662)
> {code}
> Steps to reproduce:
> {code}
> ccm create -v 1.1.9 1.1.9
> ccm populate -n 3
> ccm start
> ccm node1 stress
> ccm node1 stop
> {code}
> edit ~/.ccm/1.1.9/cluster.conf and configure cassandra_dir to point to 1.2.2. 
> Edit node1's cassandra.yaml to be 1.2 compliant.
> {code}
> ccm node1 start
> {code}
> The cluster is now a mixed version, and works for user queries, but with the 
> exception above.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira