[jira] [Commented] (CASSANDRA-5441) Add support for read at CL.SERIAL
[ https://issues.apache.org/jira/browse/CASSANDRA-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645765#comment-13645765 ] Sylvain Lebresne commented on CASSANDRA-5441: - +1 > Add support for read at CL.SERIAL > - > > Key: CASSANDRA-5441 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5441 > Project: Cassandra > Issue Type: Sub-task > Components: API, Core >Affects Versions: 2.0 >Reporter: Jonathan Ellis >Assignee: Jonathan Ellis > Fix For: 2.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5441) Add support for read at CL.SERIAL
[ https://issues.apache.org/jira/browse/CASSANDRA-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645743#comment-13645743 ] Jonathan Ellis commented on CASSANDRA-5441: --- Ah, gotcha. Fix pushed. > Add support for read at CL.SERIAL > - > > Key: CASSANDRA-5441 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5441 > Project: Cassandra > Issue Type: Sub-task > Components: API, Core >Affects Versions: 2.0 >Reporter: Jonathan Ellis >Assignee: Jonathan Ellis > Fix For: 2.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5441) Add support for read at CL.SERIAL
[
https://issues.apache.org/jira/browse/CASSANDRA-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645727#comment-13645727
]
Sylvain Lebresne commented on CASSANDRA-5441:
-
bq. Not sure what you mean – preparePaxos will throw WriteTimeoutException
I mean, what if {{beginAndRepairPaxos}} returns {{null}} a bunch of times
(maybe we've replayed an in-progress update sucessfully but it took us some
time, and then we're unlucky and can't get our prepare 'promised' due to
contention) and we end up exiting the {{while}} loop due to the while condition
and not due to {{beginAndRepairPaxos}} returning something. Then we should
timeout, not do as if everything was fine (since it's not).
> Add support for read at CL.SERIAL
> -
>
> Key: CASSANDRA-5441
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5441
> Project: Cassandra
> Issue Type: Sub-task
> Components: API, Core
>Affects Versions: 2.0
>Reporter: Jonathan Ellis
>Assignee: Jonathan Ellis
> Fix For: 2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5441) Add support for read at CL.SERIAL
[ https://issues.apache.org/jira/browse/CASSANDRA-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645706#comment-13645706 ] Jonathan Ellis commented on CASSANDRA-5441: --- bq. If we timeout trying to commit in-progress round, we should throw a timeout exception, not proceed to fetching the rows Not sure what you mean -- preparePaxos will throw WriteTimeoutException which will propagate all the way back to the client. https://github.com/jbellis/cassandra/commits/5441-2 rebased post-CASSANDRA-544 with nit addressed. > Add support for read at CL.SERIAL > - > > Key: CASSANDRA-5441 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5441 > Project: Cassandra > Issue Type: Sub-task > Components: API, Core >Affects Versions: 2.0 >Reporter: Jonathan Ellis >Assignee: Jonathan Ellis > Fix For: 2.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5441) Add support for read at CL.SERIAL
[ https://issues.apache.org/jira/browse/CASSANDRA-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645556#comment-13645556 ] Sylvain Lebresne commented on CASSANDRA-5441: - If we timeout trying to commit in-progress round, we should throw a timeout exception, not proceed to fetching the rows. nit: Maybe we could rewrite "You must use CAS for serializable writes" -> "You must use conditional updates for serializable writes"? > Add support for read at CL.SERIAL > - > > Key: CASSANDRA-5441 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5441 > Project: Cassandra > Issue Type: Sub-task > Components: API, Core >Affects Versions: 2.0 >Reporter: Jonathan Ellis >Assignee: Jonathan Ellis > Fix For: 2.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5441) Add support for read at CL.SERIAL
[ https://issues.apache.org/jira/browse/CASSANDRA-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632547#comment-13632547 ] Jonathan Ellis commented on CASSANDRA-5441: --- Pushed to https://github.com/jbellis/cassandra/commits/5441 > Add support for read at CL.SERIAL > - > > Key: CASSANDRA-5441 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5441 > Project: Cassandra > Issue Type: Sub-task > Components: API, Core >Reporter: Jonathan Ellis > Fix For: 2.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5441) Add support for read at CL.SERIAL
[ https://issues.apache.org/jira/browse/CASSANDRA-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628791#comment-13628791 ] Sylvain Lebresne commented on CASSANDRA-5441: - Agreed, I think that's about all we need. But as a side note, it would be nice to use this ticket to also add proper validation of CL.SERIAL (refuse it in normal writes, in any type of counter operation, etc...). > Add support for read at CL.SERIAL > - > > Key: CASSANDRA-5441 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5441 > Project: Cassandra > Issue Type: Sub-task > Components: API, Core >Reporter: Jonathan Ellis > Fix For: 2.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5441) Add support for read at CL.SERIAL
[ https://issues.apache.org/jira/browse/CASSANDRA-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626744#comment-13626744 ] Jonathan Ellis commented on CASSANDRA-5441: --- I think this is as simple as "perform the prepare/complete in-progress-proposals part of Paxos, followed by a Quorum read." > Add support for read at CL.SERIAL > - > > Key: CASSANDRA-5441 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5441 > Project: Cassandra > Issue Type: Sub-task > Components: API, Core >Reporter: Jonathan Ellis > Fix For: 2.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
