[jira] [Commented] (CASSANDRA-5595) Add counters to TRACE for how much CASSANDRA-5514 helped a query

2013-05-28 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668472#comment-13668472
 ] 

Jonathan Ellis commented on CASSANDRA-5595:
---

+1

> Add counters to TRACE for how much CASSANDRA-5514 helped a query
> 
>
> Key: CASSANDRA-5595
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5595
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.0
>Reporter: Jeremiah Jordan
>Assignee: Marcus Eriksson
>Priority: Minor
> Attachments: 
> 0001-add-tracing-that-tracks-how-many-sstables-were-skipp.patch, 
> 0001-trace-how-many-sstables-were-skipped-during-slice-du.patch
>
>
> It might be an interesting stat to keep track of how many sstables got 
> skipped by the comparisons added in CASSANDRA-5514.  Could be exposed in 
> TRACE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5595) Add counters to TRACE for how much CASSANDRA-5514 helped a query

2013-05-28 Thread Marcus Eriksson (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668375#comment-13668375
 ] 

Marcus Eriksson commented on CASSANDRA-5595:


hehe figured there was a reason

i'll fix

> Add counters to TRACE for how much CASSANDRA-5514 helped a query
> 
>
> Key: CASSANDRA-5595
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5595
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.0
>Reporter: Jeremiah Jordan
>Assignee: Marcus Eriksson
>Priority: Minor
> Attachments: 
> 0001-add-tracing-that-tracks-how-many-sstables-were-skipp.patch
>
>
> It might be an interesting stat to keep track of how many sstables got 
> skipped by the comparisons added in CASSANDRA-5514.  Could be exposed in 
> TRACE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5595) Add counters to TRACE for how much CASSANDRA-5514 helped a query

2013-05-28 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668369#comment-13668369
 ] 

Jonathan Ellis commented on CASSANDRA-5595:
---

We actually don't want to use varargs in Tracing since it forces array 
allocation even if tracing is off.

> Add counters to TRACE for how much CASSANDRA-5514 helped a query
> 
>
> Key: CASSANDRA-5595
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5595
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.0
>Reporter: Jeremiah Jordan
>Assignee: Marcus Eriksson
>Priority: Minor
> Attachments: 
> 0001-add-tracing-that-tracks-how-many-sstables-were-skipp.patch
>
>
> It might be an interesting stat to keep track of how many sstables got 
> skipped by the comparisons added in CASSANDRA-5514.  Could be exposed in 
> TRACE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira