[jira] [Commented] (CASSANDRA-5687) Move C* Python Thrift tests into dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092785#comment-14092785 ] Aleksey Yeschenko commented on CASSANDRA-5687: -- The last two remaining failing 2.1 tests (test_index_scan and test_dynamic_indexes_with_system_update_cf) are both caused by CASSANDRA-7525 regression. See CASSANDRA-7741. Move C* Python Thrift tests into dtests --- Key: CASSANDRA-5687 URL: https://issues.apache.org/jira/browse/CASSANDRA-5687 Project: Cassandra Issue Type: Test Reporter: Ryan McGuire Assignee: Aleksey Yeschenko Priority: Minor Fix For: 2.1.0 Attachments: 5687.nosetests.log, 5687.nosetets.2.0.log There's several good tests currently sitting in the C* source tree under test/system/test_thrift_server.py - these tests are not run via 'ant test' and no buildbot is regularly running them. Let's move them into cassandra-dtest so that we're not wasting valid tests. It appears they will need some refactoring to automatically start clusters via ccm, like the rest of dtests do. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-5687) Move C* Python Thrift tests into dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093180#comment-14093180 ] Ryan McGuire commented on CASSANDRA-5687: - I've refactored my test, and I'm seeing parity. test_index_scan and test_dynamic_indexes_with_system_update_cf are failing on 2.1, otherwise they are all passing. Move C* Python Thrift tests into dtests --- Key: CASSANDRA-5687 URL: https://issues.apache.org/jira/browse/CASSANDRA-5687 Project: Cassandra Issue Type: Test Reporter: Ryan McGuire Assignee: Ryan McGuire Priority: Minor Fix For: 2.1.0 Attachments: 5687.nosetests.log, 5687.nosetets.2.0.log There's several good tests currently sitting in the C* source tree under test/system/test_thrift_server.py - these tests are not run via 'ant test' and no buildbot is regularly running them. Let's move them into cassandra-dtest so that we're not wasting valid tests. It appears they will need some refactoring to automatically start clusters via ccm, like the rest of dtests do. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-5687) Move C* Python Thrift tests into dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092162#comment-14092162 ] Aleksey Yeschenko commented on CASSANDRA-5687: -- 2 of the 3 2.0 failures are caused by CASSANDRA-7723. Move C* Python Thrift tests into dtests --- Key: CASSANDRA-5687 URL: https://issues.apache.org/jira/browse/CASSANDRA-5687 Project: Cassandra Issue Type: Test Reporter: Ryan McGuire Assignee: Aleksey Yeschenko Priority: Minor Fix For: 2.1.0 Attachments: 5687.nosetests.log, 5687.nosetets.2.0.log There's several good tests currently sitting in the C* source tree under test/system/test_thrift_server.py - these tests are not run via 'ant test' and no buildbot is regularly running them. Let's move them into cassandra-dtest so that we're not wasting valid tests. It appears they will need some refactoring to automatically start clusters via ccm, like the rest of dtests do. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-5687) Move C* Python Thrift tests into dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092311#comment-14092311 ] Aleksey Yeschenko commented on CASSANDRA-5687: -- test_system_column_family_operations failure was 2.0-only, and ninja-fixed by https://github.com/apache/cassandra/commit/6976d82ed64f7b48a6d2d465de176abf3c040f81 2.0 is clean now, passing all the tests (even without CASSANDRA-7733 committed). Move C* Python Thrift tests into dtests --- Key: CASSANDRA-5687 URL: https://issues.apache.org/jira/browse/CASSANDRA-5687 Project: Cassandra Issue Type: Test Reporter: Ryan McGuire Assignee: Aleksey Yeschenko Priority: Minor Fix For: 2.1.0 Attachments: 5687.nosetests.log, 5687.nosetets.2.0.log There's several good tests currently sitting in the C* source tree under test/system/test_thrift_server.py - these tests are not run via 'ant test' and no buildbot is regularly running them. Let's move them into cassandra-dtest so that we're not wasting valid tests. It appears they will need some refactoring to automatically start clusters via ccm, like the rest of dtests do. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-5687) Move C* Python Thrift tests into dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14090971#comment-14090971 ] Ryan McGuire commented on CASSANDRA-5687: - I've refactored the test enough to work within the dtest framework here: https://github.com/riptano/cassandra-dtest/blob/4bd38e96122aefab2fb753710d385ebf0ef4a87c/thrift_tests.py There's a lot of failures against 2.1.0. I've attached the log. Move C* Python Thrift tests into dtests --- Key: CASSANDRA-5687 URL: https://issues.apache.org/jira/browse/CASSANDRA-5687 Project: Cassandra Issue Type: Test Reporter: Ryan McGuire Assignee: Ryan McGuire Priority: Minor There's several good tests currently sitting in the C* source tree under test/system/test_thrift_server.py - these tests are not run via 'ant test' and no buildbot is regularly running them. Let's move them into cassandra-dtest so that we're not wasting valid tests. It appears they will need some refactoring to automatically start clusters via ccm, like the rest of dtests do. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-5687) Move C* Python Thrift tests into dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14091173#comment-14091173 ] Aleksey Yeschenko commented on CASSANDRA-5687: -- Cassandra 1.2 had just one failing test, I fixed it and pushed the fix. 2.0 Seem to have 3 legit errors, I'm looking into them now: ERROR: system.test_thrift_server.TestMutations.test_batch_mutate_remove_slice_part_of_supercolumns ERROR: system.test_thrift_server.TestMutations.test_batch_mutate_remove_slice_standard ERROR: system.test_thrift_server.TestMutations.test_system_column_family_operations 2.1 additionally errors out on the following, mostly counters-related tests: ERROR: system.test_thrift_server.TestMutations.test_dynamic_indexes_with_system_update_cf ERROR: system.test_thrift_server.TestMutations.test_incr_decr_standard_batch_remove ERROR: system.test_thrift_server.TestMutations.test_incr_decr_standard_remove ERROR: system.test_thrift_server.TestMutations.test_incr_decr_super_remove ERROR: system.test_thrift_server.TestMutations.test_incr_standard_remove ERROR: system.test_thrift_server.TestMutations.test_incr_super_remove ERROR: system.test_thrift_server.TestMutations.test_index_scan My guess is that most of the counter ones are broken b/c we've changed counters deletion semantics (CASSANDRA-7346), and it's the tests that should be updated. The rest of them look legit so far. Move C* Python Thrift tests into dtests --- Key: CASSANDRA-5687 URL: https://issues.apache.org/jira/browse/CASSANDRA-5687 Project: Cassandra Issue Type: Test Reporter: Ryan McGuire Assignee: Ryan McGuire Priority: Minor Fix For: 2.1.0 Attachments: 5687.nosetests.log, 5687.nosetets.2.0.log There's several good tests currently sitting in the C* source tree under test/system/test_thrift_server.py - these tests are not run via 'ant test' and no buildbot is regularly running them. Let's move them into cassandra-dtest so that we're not wasting valid tests. It appears they will need some refactoring to automatically start clusters via ccm, like the rest of dtests do. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-5687) Move C* Python Thrift tests into dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086826#comment-14086826 ] Aleksey Yeschenko commented on CASSANDRA-5687: -- [~enigmacurry] Any plans for this? Move C* Python Thrift tests into dtests --- Key: CASSANDRA-5687 URL: https://issues.apache.org/jira/browse/CASSANDRA-5687 Project: Cassandra Issue Type: Test Reporter: Ryan McGuire Assignee: Ryan McGuire Priority: Minor There's several good tests currently sitting in the C* source tree under test/system/test_thrift_server.py - these tests are not run via 'ant test' and no buildbot is regularly running them. Let's move them into cassandra-dtest so that we're not wasting valid tests. It appears they will need some refactoring to automatically start clusters via ccm, like the rest of dtests do. -- This message was sent by Atlassian JIRA (v6.2#6252)
