[jira] [Commented] (CASSANDRA-5696) Upgrading to cassandra-1.2 with a dead LEFT state from 1.1 causes problems

2013-06-26 Thread Jason Brown (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13694225#comment-13694225
 ] 

Jason Brown commented on CASSANDRA-5696:


After we make this change, won't the same rules apply to 1.2.{0..6} - 
1.2.7+/2.0 upgrades? The VV fields will again be inverted, although arguably in 
a more internally consistent manner (with 1.1)?


 Upgrading to cassandra-1.2 with a dead LEFT state from 1.1 causes problems
 --

 Key: CASSANDRA-5696
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5696
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.2.0
Reporter: Brandon Williams
Assignee: Brandon Williams
 Fix For: 1.2.7

 Attachments: 5696.txt


 In 1.1, we wrote LEFT states as LEFT,token,expiretime in gossip.  However in 
 1.2, VersionValue serializes this to LEFT,expiretime,tokens and causes the 
 upgrade 1.2 to try and parse it this way as well, causing it to try to parse 
 the token as an expiretime.
 Another wrinkle to this is assassinate still writes it the old way: 
 LEFT,tokens,expiretime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5696) Upgrading to cassandra-1.2 with a dead LEFT state from 1.1 causes problems

2013-06-26 Thread Jason Brown (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13694228#comment-13694228
 ] 

Jason Brown commented on CASSANDRA-5696:


Thought a little bit more, and I think this patch is fine. +1

 Upgrading to cassandra-1.2 with a dead LEFT state from 1.1 causes problems
 --

 Key: CASSANDRA-5696
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5696
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.2.0
Reporter: Brandon Williams
Assignee: Brandon Williams
 Fix For: 1.2.7

 Attachments: 5696.txt


 In 1.1, we wrote LEFT states as LEFT,token,expiretime in gossip.  However in 
 1.2, VersionValue serializes this to LEFT,expiretime,tokens and causes the 
 upgrade 1.2 to try and parse it this way as well, causing it to try to parse 
 the token as an expiretime.
 Another wrinkle to this is assassinate still writes it the old way: 
 LEFT,tokens,expiretime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira