[jira] [Commented] (CASSANDRA-6281) Use Atomic*FieldUpdater to save memory
[ https://issues.apache.org/jira/browse/CASSANDRA-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860285#comment-13860285 ] Sylvain Lebresne commented on CASSANDRA-6281: - Playing devil's advocate here, I'd rather stick to 2.1. There is no such thing as an entirely safe patch and this sound like a pretty minor improvement (in term of concrete impact, it's definitively nice to have). Use Atomic*FieldUpdater to save memory -- Key: CASSANDRA-6281 URL: https://issues.apache.org/jira/browse/CASSANDRA-6281 Project: Cassandra Issue Type: Improvement Reporter: Marcus Eriksson Assignee: Marcus Eriksson Priority: Minor Fix For: 2.1 Attachments: 0001-Use-Atomic-FieldUpdater-to-save-memory.patch Followup to CASSANDRA-6278, use Atomic*FieldUpdater in; AtomicSortedColumns ReadCallback WriteResponseHandler -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CASSANDRA-6281) Use Atomic*FieldUpdater to save memory
[ https://issues.apache.org/jira/browse/CASSANDRA-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860297#comment-13860297 ] Benedict commented on CASSANDRA-6281: - Don't even need to apply the patch to see it looks good. Every - line is matched by a semantically identical + line, except in DWRH, which is almost identical and definitely fine. Note, I did apply it, just to make sure. Everything looks hunkydory. I'm comfortable about applying it to 2.0.5, the patch is about as safe as they come, although I think the benefit is actually fairly minimal so I don't think it is urgent. Overall contribution to memory consumption of these fields in the 2.0 branch is going to be really minimal given, probably ~2% or less of memtable consumption on average. The only thing I would say is that the receive = 0 assignment in ReadCallback is unnecessary. Use Atomic*FieldUpdater to save memory -- Key: CASSANDRA-6281 URL: https://issues.apache.org/jira/browse/CASSANDRA-6281 Project: Cassandra Issue Type: Improvement Reporter: Marcus Eriksson Assignee: Marcus Eriksson Priority: Minor Fix For: 2.1 Attachments: 0001-Use-Atomic-FieldUpdater-to-save-memory.patch Followup to CASSANDRA-6278, use Atomic*FieldUpdater in; AtomicSortedColumns ReadCallback WriteResponseHandler -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CASSANDRA-6281) Use Atomic*FieldUpdater to save memory
[ https://issues.apache.org/jira/browse/CASSANDRA-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860307#comment-13860307 ] Jonathan Ellis commented on CASSANDRA-6281: --- For 2% benefit I'm fine w/ waiting for 2.1. Use Atomic*FieldUpdater to save memory -- Key: CASSANDRA-6281 URL: https://issues.apache.org/jira/browse/CASSANDRA-6281 Project: Cassandra Issue Type: Improvement Reporter: Marcus Eriksson Assignee: Marcus Eriksson Priority: Minor Fix For: 2.1 Attachments: 0001-Use-Atomic-FieldUpdater-to-save-memory.patch Followup to CASSANDRA-6278, use Atomic*FieldUpdater in; AtomicSortedColumns ReadCallback WriteResponseHandler -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CASSANDRA-6281) Use Atomic*FieldUpdater to save memory
[ https://issues.apache.org/jira/browse/CASSANDRA-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860315#comment-13860315 ] Benedict commented on CASSANDRA-6281: - Just for absolute correctness, I'll clarify: Current overhead per column is around 100 bytes, plus a little extra for the row as a whole. This will save around 16 bytes on average per row in memtable (the readcallbacks/writehandlers are too short lived to be a major impact at all). So in a table with only 1 almost empty column this might be a large saving, 10-15%, but it goes down rapidly. And I doubt many people have tables with fewer than 4-5 columns, at which point it's about 4% excluding the data itself (so maybe 3% including it), and getting smaller with each column / size of payload. Use Atomic*FieldUpdater to save memory -- Key: CASSANDRA-6281 URL: https://issues.apache.org/jira/browse/CASSANDRA-6281 Project: Cassandra Issue Type: Improvement Reporter: Marcus Eriksson Assignee: Marcus Eriksson Priority: Minor Fix For: 2.1 Attachments: 0001-Use-Atomic-FieldUpdater-to-save-memory.patch Followup to CASSANDRA-6278, use Atomic*FieldUpdater in; AtomicSortedColumns ReadCallback WriteResponseHandler -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CASSANDRA-6281) Use Atomic*FieldUpdater to save memory
[ https://issues.apache.org/jira/browse/CASSANDRA-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860708#comment-13860708 ] Marcus Eriksson commented on CASSANDRA-6281: CASSANDRA-6278 went into 2.1 so i figured the same here Use Atomic*FieldUpdater to save memory -- Key: CASSANDRA-6281 URL: https://issues.apache.org/jira/browse/CASSANDRA-6281 Project: Cassandra Issue Type: Improvement Reporter: Marcus Eriksson Assignee: Marcus Eriksson Priority: Minor Fix For: 2.1 Attachments: 0001-Use-Atomic-FieldUpdater-to-save-memory.patch Followup to CASSANDRA-6278, use Atomic*FieldUpdater in; AtomicSortedColumns ReadCallback WriteResponseHandler -- This message was sent by Atlassian JIRA (v6.1.5#6160)
