[jira] [Commented] (CASSANDRA-6498) Null pointer exception in custom secondary indexes

2014-01-15 Thread Miguel Angel Fernandez Diaz (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-6498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872304#comment-13872304
 ] 

Miguel Angel Fernandez Diaz commented on CASSANDRA-6498:


+1

I've been running some tests with this patch and there were no errors.

> Null pointer exception in custom secondary indexes
> --
>
> Key: CASSANDRA-6498
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6498
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Andrés de la Peña
>Assignee: Miguel Angel Fernandez Diaz
>  Labels: 2i, secondaryIndex, secondary_index
> Attachments: CASSANDRA-6498.patch
>
>
> StorageProxy#estimateResultRowsPerRange raises a null pointer exception when 
> using a custom 2i implementation that not uses a column family as underlying 
> storage:
> {code}
> resultRowsPerRange = highestSelectivityIndex.getIndexCfs().getMeanColumns();
> {code}
> According to the documentation, the method SecondaryIndex#getIndexCfs should 
> return null when no column family is used.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (CASSANDRA-6498) Null pointer exception in custom secondary indexes

2014-01-15 Thread Alvaro Agea (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-6498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872128#comment-13872128
 ] 

Alvaro Agea commented on CASSANDRA-6498:


+1

> Null pointer exception in custom secondary indexes
> --
>
> Key: CASSANDRA-6498
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6498
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Andrés de la Peña
>Assignee: Miguel Angel Fernandez Diaz
>  Labels: 2i, secondaryIndex, secondary_index
> Attachments: CASSANDRA-6498.patch
>
>
> StorageProxy#estimateResultRowsPerRange raises a null pointer exception when 
> using a custom 2i implementation that not uses a column family as underlying 
> storage:
> {code}
> resultRowsPerRange = highestSelectivityIndex.getIndexCfs().getMeanColumns();
> {code}
> According to the documentation, the method SecondaryIndex#getIndexCfs should 
> return null when no column family is used.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (CASSANDRA-6498) Null pointer exception in custom secondary indexes

2014-01-15 Thread Sam Tunnicliffe (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-6498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872138#comment-13872138
 ] 

Sam Tunnicliffe commented on CASSANDRA-6498:


+1 patch looks good to me. 

In fact, the same issue affects Solr backed indexes in DSE and our approach is 
the same.

> Null pointer exception in custom secondary indexes
> --
>
> Key: CASSANDRA-6498
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6498
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Andrés de la Peña
>Assignee: Miguel Angel Fernandez Diaz
>  Labels: 2i, secondaryIndex, secondary_index
> Attachments: CASSANDRA-6498.patch
>
>
> StorageProxy#estimateResultRowsPerRange raises a null pointer exception when 
> using a custom 2i implementation that not uses a column family as underlying 
> storage:
> {code}
> resultRowsPerRange = highestSelectivityIndex.getIndexCfs().getMeanColumns();
> {code}
> According to the documentation, the method SecondaryIndex#getIndexCfs should 
> return null when no column family is used.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (CASSANDRA-6498) Null pointer exception in custom secondary indexes

2014-01-15 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-6498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872111#comment-13872111
 ] 

Andrés de la Peña commented on CASSANDRA-6498:
--

I have been assigned to this bug, the provided patch seems to work fine.
Could the reviewer please review (and, hopefully, commit) the patch?

Thanks

> Null pointer exception in custom secondary indexes
> --
>
> Key: CASSANDRA-6498
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6498
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Andrés de la Peña
>Assignee: Andrés de la Peña
>  Labels: 2i, secondaryIndex, secondary_index
> Attachments: CASSANDRA-6498.patch
>
>
> StorageProxy#estimateResultRowsPerRange raises a null pointer exception when 
> using a custom 2i implementation that not uses a column family as underlying 
> storage:
> {code}
> resultRowsPerRange = highestSelectivityIndex.getIndexCfs().getMeanColumns();
> {code}
> According to the documentation, the method SecondaryIndex#getIndexCfs should 
> return null when no column family is used.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)