[jira] [Commented] (CASSANDRA-6828) inline thrift documentation is slightly sparse

2014-03-11 Thread Tyler Hobbs (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-6828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13930594#comment-13930594
 ] 

Tyler Hobbs commented on CASSANDRA-6828:


Overall the new docs look good, thanks.  The one point I disagree with is this:

{quote}
Batch mutations are very efficient and should be prefered over doing multiple 
inserts.
{quote}

Batch mutations also have downsides.  They put more temporary load on the 
coordinator, which can cause GC problems and spikes in latency when the batches 
are large.  When a large batch mutation fails, you have to retry the entire 
thing, even if only one of the mutations in the batch failed.  I would just 
tone down the "preferred" language and add those disclaimers.

Other than that, I think this is good to go.

> inline thrift documentation is slightly sparse 
> ---
>
> Key: CASSANDRA-6828
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6828
> Project: Cassandra
>  Issue Type: Improvement
>  Components: API, Documentation & website
>Reporter: Edward Capriolo
>Assignee: Edward Capriolo
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CASSANDRA-6828) inline thrift documentation is slightly sparse

2014-03-08 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-6828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924991#comment-13924991
 ] 

Edward Capriolo commented on CASSANDRA-6828:


Obviously there is a lot of good information found outside the thrift file. 
Some features like CAS have a good amount of documentation. Other features have 
little or none. Also found a spot where column path was referring to some html 
doc that seems to no longer exist. 

It is hard to say what information should or should not be here, but I thought 
it neccesary to at least alert people at one place in the file that they should 
not be using SuperColumns anymore :)

https://github.com/edwardcapriolo/cassandra/compare/document-thrift-interface



> inline thrift documentation is slightly sparse 
> ---
>
> Key: CASSANDRA-6828
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6828
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Edward Capriolo
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)