[jira] [Commented] (CASSANDRA-6907) ignore snapshot repair flag on Windows
[ https://issues.apache.org/jira/browse/CASSANDRA-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948013#comment-13948013 ] Jonathan Ellis commented on CASSANDRA-6907: --- committed > ignore snapshot repair flag on Windows > -- > > Key: CASSANDRA-6907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6907 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Jonathan Ellis >Assignee: Joshua McKenzie > Fix For: 2.0.7, 2.1 beta2 > > Attachments: CASSANDRA-6907_v1.patch, CASSANDRA-6907_v2.patch, > CASSANDRA-6907_v3.patch > > > Per discussion in CASSANDRA-4050, we should ignore the snapshot repair flag > on windows, and log a warning while proceeding to do non-snapshot repair. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-6907) ignore snapshot repair flag on Windows
[ https://issues.apache.org/jira/browse/CASSANDRA-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945419#comment-13945419 ] Joshua McKenzie commented on CASSANDRA-6907: new patch attached. > ignore snapshot repair flag on Windows > -- > > Key: CASSANDRA-6907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6907 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Jonathan Ellis >Assignee: Joshua McKenzie > Fix For: 2.0.7 > > Attachments: CASSANDRA-6907_v1.patch, CASSANDRA-6907_v2.patch, > CASSANDRA-6907_v3.patch > > > Per discussion in CASSANDRA-4050, we should ignore the snapshot repair flag > on windows, and log a warning while proceeding to do non-snapshot repair. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-6907) ignore snapshot repair flag on Windows
[ https://issues.apache.org/jira/browse/CASSANDRA-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945357#comment-13945357 ] Jonathan Ellis commented on CASSANDRA-6907: --- Let's go ahead and do that, we can just leave it out of 3.0 when we merge so there's no need to worry about it outliving its usefulness. > ignore snapshot repair flag on Windows > -- > > Key: CASSANDRA-6907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6907 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Jonathan Ellis >Assignee: Joshua McKenzie > Fix For: 2.0.7 > > Attachments: CASSANDRA-6907_v1.patch, CASSANDRA-6907_v2.patch > > > Per discussion in CASSANDRA-4050, we should ignore the snapshot repair flag > on windows, and log a warning while proceeding to do non-snapshot repair. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-6907) ignore snapshot repair flag on Windows
[ https://issues.apache.org/jira/browse/CASSANDRA-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945329#comment-13945329 ] Joshua McKenzie commented on CASSANDRA-6907: Would be more robust, yes, but also represent more invasive changes for temporary OS-specific workarounds. If we want to err on the side of robustness that should be a trivial change. > ignore snapshot repair flag on Windows > -- > > Key: CASSANDRA-6907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6907 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Jonathan Ellis >Assignee: Joshua McKenzie > Fix For: 2.0.7 > > Attachments: CASSANDRA-6907_v1.patch, CASSANDRA-6907_v2.patch > > > Per discussion in CASSANDRA-4050, we should ignore the snapshot repair flag > on windows, and log a warning while proceeding to do non-snapshot repair. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-6907) ignore snapshot repair flag on Windows
[ https://issues.apache.org/jira/browse/CASSANDRA-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945315#comment-13945315 ] Jonathan Ellis commented on CASSANDRA-6907: --- Wouldn't addressing in code be more robust for invocations via jmx as well as .bat? > ignore snapshot repair flag on Windows > -- > > Key: CASSANDRA-6907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6907 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Jonathan Ellis >Assignee: Joshua McKenzie > Fix For: 2.0.7 > > Attachments: CASSANDRA-6907_v1.patch, CASSANDRA-6907_v2.patch > > > Per discussion in CASSANDRA-4050, we should ignore the snapshot repair flag > on windows, and log a warning while proceeding to do non-snapshot repair. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-6907) ignore snapshot repair flag on Windows
[ https://issues.apache.org/jira/browse/CASSANDRA-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945305#comment-13945305 ] Joshua McKenzie commented on CASSANDRA-6907: Went with protection in the startup .bat file to force addition of -par on repair if it's not there and log to stdout. Lighter touch and isolates changes to windows environment only. > ignore snapshot repair flag on Windows > -- > > Key: CASSANDRA-6907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6907 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Jonathan Ellis >Assignee: Joshua McKenzie > Fix For: 2.0.7 > > Attachments: CASSANDRA-6907_v1.patch > > > Per discussion in CASSANDRA-4050, we should ignore the snapshot repair flag > on windows, and log a warning while proceeding to do non-snapshot repair. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-6907) ignore snapshot repair flag on Windows
[ https://issues.apache.org/jira/browse/CASSANDRA-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943814#comment-13943814 ] Jonathan Ellis commented on CASSANDRA-6907: --- (I would prefer to leave the default of snapshot the same on both windows and linux, which means we should log a warning and ignore the flag instead of failing the operation.) > ignore snapshot repair flag on Windows > -- > > Key: CASSANDRA-6907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6907 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Jonathan Ellis >Assignee: Joshua McKenzie > Fix For: 2.0.7 > > > Per discussion in CASSANDRA-4050, we should ignore the snapshot repair flag > on windows, and log a warning while proceeding to do non-snapshot repair. -- This message was sent by Atlassian JIRA (v6.2#6252)
