[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679313#comment-14679313 ] Aleksey Yeschenko commented on CASSANDRA-7342: -- Committed as [07a7e80c321b6667cc44a236f999c7837fe48e20|https://github.com/apache/cassandra/commit/07a7e80c321b6667cc44a236f999c7837fe48e20] to cassandra-2.1, and merged up. Thanks. > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Sub-task >Reporter: sankalp kohli >Assignee: sankalp kohli > Fix For: 2.1.9, 2.2.1, 3.0 beta 1 > > Attachments: 7342_2.0.txt, 7342_2.1.txt > > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679275#comment-14679275 ] sankalp kohli commented on CASSANDRA-7342: -- +1 looks good. Thanks for simplifying the above two things. > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Sub-task >Reporter: sankalp kohli >Assignee: sankalp kohli > Fix For: 2.1.x, 2.2.x, 3.0.x > > Attachments: 7342_2.0.txt, 7342_2.1.txt > > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[
https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679136#comment-14679136
]
Aleksey Yeschenko commented on CASSANDRA-7342:
--
The original patch was ignoring {{shouldHint}} in {{commitPaxos()}} when the
node was live. Both the original patch and my follow-up had redundant methods -
and arguments - we don't need an extra {{isCas}} or {{kind}} fields in
{{WriteCallbackInfo}} because we can infer the type from {{sentMessage.verb}}.
Updated versions: [2.1|https://github.com/iamaleksey/cassandra/tree/7342-2.1],
[2.2|https://github.com/iamaleksey/cassandra/tree/7342-2.2],
[3.0|https://github.com/iamaleksey/cassandra/tree/7342-3.0].
Cassci: [2.1
testall|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-7342-2.1-testall/],
[2.1
dtest|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-7342-2.1-dtest/],
[2.2
testall|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-7342-2.2-testall/],
[2.2
dtest|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-7342-2.2-dtest/],
[3.0
testall|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-7342-3.0-testall/],
[3.0
dtest|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-7342-3.0-dtest/].
> CAS writes does not have hint functionality.
> -
>
> Key: CASSANDRA-7342
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7342
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: sankalp kohli
>Assignee: sankalp kohli
> Fix For: 2.1.x, 2.2.x, 3.0.x
>
> Attachments: 7342_2.0.txt, 7342_2.1.txt
>
>
> When a dead node comes up, it gets the last commit but not anything which it
> has missed.
> This reduces the durability of those writes compared to other writes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660203#comment-14660203 ] Aleksey Yeschenko commented on CASSANDRA-7342: -- Ok, the patch looks fine. Pushed to my own branch with some minor nits fixed - https://github.com/iamaleksey/cassandra/commits/7342 Will see if cassci is happy, then double check for 2.2 and 3.0. > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Sub-task >Reporter: sankalp kohli >Assignee: sankalp kohli > Fix For: 2.1.x, 2.2.x, 3.0.x > > Attachments: 7342_2.0.txt, 7342_2.1.txt > > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639491#comment-14639491 ] sankalp kohli commented on CASSANDRA-7342: -- sure. > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Sub-task >Reporter: sankalp kohli >Assignee: sankalp kohli > Attachments: 7342_2.0.txt, 7342_2.1.txt > > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639405#comment-14639405 ] Aleksey Yeschenko commented on CASSANDRA-7342: -- [~kohlisankalp] I'll review, but I'd rather not be adding it to 2.0 at this stage (2.1 too, but I can make an exception for 2.1). > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Sub-task >Reporter: sankalp kohli >Assignee: sankalp kohli > Attachments: 7342_2.0.txt, 7342_2.1.txt > > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638115#comment-14638115 ] sankalp kohli commented on CASSANDRA-7342: -- cc [~iamaleksey] > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Sub-task >Reporter: sankalp kohli >Assignee: sankalp kohli > Attachments: 7342_2.0.txt, 7342_2.1.txt > > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[
https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599033#comment-14599033
]
Sylvain Lebresne commented on CASSANDRA-7342:
-
Yes, I think we can treat those as normal hints. The only downside of not going
through {{savePaxosCommit}} might be that we'll end up replaying that same
commit. Which is both harmless and unlikely since if you get hints, you're
probably not up to date in the first place, in which case going through
{{savePaxosCommit}} is wasted anyway. So happy to keep it simple.
> CAS writes does not have hint functionality.
> -
>
> Key: CASSANDRA-7342
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7342
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: sankalp kohli
>Assignee: sankalp kohli
>
> When a dead node comes up, it gets the last commit but not anything which it
> has missed.
> This reduces the durability of those writes compared to other writes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598084#comment-14598084 ] sankalp kohli commented on CASSANDRA-7342: -- cc [~slebresne] > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Sub-task >Reporter: sankalp kohli >Assignee: sankalp kohli > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596992#comment-14596992 ] sankalp kohli commented on CASSANDRA-7342: -- Can't we treat the RowMutation inside a Commit as normal mutation and just drop it into hints. If we do this, we won't be calling PaxosState.commit which won't call SystemKeyspace.savePaxosCommit(proposal); > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Sub-task >Reporter: sankalp kohli >Assignee: sankalp kohli > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056875#comment-14056875 ] sankalp kohli commented on CASSANDRA-7342: -- Can we instead write a normal write for a failed CAS commit. I am not sure whether it will work. > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Improvement >Reporter: sankalp kohli >Assignee: sankalp kohli > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029744#comment-14029744 ] sankalp kohli commented on CASSANDRA-7342: -- Thanks Sylvain for the input. Let me work on it. > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Improvement >Reporter: sankalp kohli > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029729#comment-14029729 ] Sylvain Lebresne commented on CASSANDRA-7342: - That sounds like a reasonable idea to me. > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Improvement >Reporter: sankalp kohli > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029696#comment-14029696 ] Jonathan Ellis commented on CASSANDRA-7342: --- Ping [~slebresne] > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Improvement >Reporter: sankalp kohli > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7342) CAS writes does not have hint functionality.
[ https://issues.apache.org/jira/browse/CASSANDRA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028420#comment-14028420 ] sankalp kohli commented on CASSANDRA-7342: -- I was thinking of ways to do it. Can we use the same hints CF and add a new column called cas_commit and save commits there. This way we can distinguish while replaying the logs whether it is a commit or a normal mutation. CREATE TABLE hints ( target_id uuid, hint_id timeuuid, message_version int, mutation blob, cas_commit blob, PRIMARY KEY (target_id, hint_id, message_version) * ) WITH COMPACT STORAGE; > CAS writes does not have hint functionality. > - > > Key: CASSANDRA-7342 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7342 > Project: Cassandra > Issue Type: Improvement >Reporter: sankalp kohli > > When a dead node comes up, it gets the last commit but not anything which it > has missed. > This reduces the durability of those writes compared to other writes. -- This message was sent by Atlassian JIRA (v6.2#6252)
