[jira] [Commented] (CASSANDRA-7710) nodetool ring throws exception if run on machine without Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089291#comment-14089291 ] Jonathan Ellis commented on CASSANDRA-7710: --- [~mshuler] can you figure out where we fixed this in 2.1? > nodetool ring throws exception if run on machine without Cassandra > -- > > Key: CASSANDRA-7710 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7710 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Jimmy Mårdell >Priority: Minor > > DatabaseDescriptor.getNumTokens() is invoked in the nodetool ring command > which doesn't work so well when running on a machine where Cassandra doesnt' > exist. And it has all kind of side effects as well. > This seems fixed in 2.1 but would be nice if it was fixed in 2.0 as well. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7710) nodetool ring throws exception if run on machine without Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093225#comment-14093225 ] Michael Shuler commented on CASSANDRA-7710: --- [~yarin] could you clarify exactly how you are attempting to use nodetool or DatabaseDescriptor.getNumTokens()? Running nodetool against another node, from a machine that does not have Cassandra *running*, works fine (Cassandra is installed, but is not a part of the cluster, nor has the service been started). I'm not clear on the use case of: bq. running on a machine where Cassandra doesn't exist. > nodetool ring throws exception if run on machine without Cassandra > -- > > Key: CASSANDRA-7710 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7710 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Jimmy Mårdell >Assignee: Michael Shuler >Priority: Minor > > DatabaseDescriptor.getNumTokens() is invoked in the nodetool ring command > which doesn't work so well when running on a machine where Cassandra doesnt' > exist. And it has all kind of side effects as well. > This seems fixed in 2.1 but would be nice if it was fixed in 2.0 as well. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7710) nodetool ring throws exception if run on machine without Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095343#comment-14095343 ] Jimmy Mårdell commented on CASSANDRA-7710: -- Our particular problem is that we have created our own SeedProvider. When you run "nodetool ring" on a production machine, our custom SeedProvider gets invoked by the nodetool process (as a side effect of DatabaseDescriptor being invoked) which causes some minor issues. This seems like a bug to me; nodetool ought to be a pure CLI fetching data through JMX. Compare the 2.0 implementation (using DatabaseDescriptor.getNumTokens() to determine if the cluster uses vnodes): https://github.com/apache/cassandra/blob/cassandra-2.0/src/java/org/apache/cassandra/tools/NodeCmd.java#L296 and the 2.1 implementations (which determines if the cluster uses vnodes by counting number of tokens through JMX) https://github.com/apache/cassandra/blob/cassandra-2.1/src/java/org/apache/cassandra/tools/NodeTool.java#L437 The 2.1 implementation is clearly superior and doesn't have side effects. I think this should be backported 2.0. I might do this myself, since it doesn't seem to so hard. > nodetool ring throws exception if run on machine without Cassandra > -- > > Key: CASSANDRA-7710 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7710 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Jimmy Mårdell >Assignee: Michael Shuler >Priority: Minor > > DatabaseDescriptor.getNumTokens() is invoked in the nodetool ring command > which doesn't work so well when running on a machine where Cassandra doesnt' > exist. And it has all kind of side effects as well. > This seems fixed in 2.1 but would be nice if it was fixed in 2.0 as well. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7710) nodetool ring throws exception if run on machine without Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095590#comment-14095590 ] Michael Shuler commented on CASSANDRA-7710: --- Thanks for the details, that helps a great deal! Do feel free to post a patch for review, and I'll see if I can tie the changes above to particular commits for reference. > nodetool ring throws exception if run on machine without Cassandra > -- > > Key: CASSANDRA-7710 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7710 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Jimmy Mårdell >Assignee: Michael Shuler >Priority: Minor > > DatabaseDescriptor.getNumTokens() is invoked in the nodetool ring command > which doesn't work so well when running on a machine where Cassandra doesnt' > exist. And it has all kind of side effects as well. > This seems fixed in 2.1 but would be nice if it was fixed in 2.0 as well. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7710) nodetool ring throws exception if run on machine without Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096824#comment-14096824 ] Jimmy Mårdell commented on CASSANDRA-7710: -- Thanks, yes, that's the one I was looking for! > nodetool ring throws exception if run on machine without Cassandra > -- > > Key: CASSANDRA-7710 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7710 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Jimmy Mårdell >Assignee: Michael Shuler >Priority: Minor > > DatabaseDescriptor.getNumTokens() is invoked in the nodetool ring command > which doesn't work so well when running on a machine where Cassandra doesnt' > exist. And it has all kind of side effects as well. > This seems fixed in 2.1 but would be nice if it was fixed in 2.0 as well. -- This message was sent by Atlassian JIRA (v6.2#6252)
