[jira] [Commented] (CASSANDRA-7820) Remove fat client mode
[ https://issues.apache.org/jira/browse/CASSANDRA-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162656#comment-14162656 ] Joshua McKenzie commented on CASSANDRA-7820: I agree on changing isFatclient, though it looks like they're R/O on gossip as they don't have tokens so other gossip participants won't pull schema from them. Maybe isGossipReadOnly()? This is going to break anybody that's been relying on SS.initClient up to this point. Probably worth documenting in NEWS nit: Can remove empty static constructor block from SSTableLoader On the whole - LGTM. CASSANDRA-7993 will need to be addressed w/respect to the changes here. > Remove fat client mode > -- > > Key: CASSANDRA-7820 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7820 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Brandon Williams > Fix For: 3.0 > > Attachments: 7820-v1.txt, 7820-v2.txt, 7820-v3.txt > > > Now that we support push notifications server -> client, there's no reason to > have clients participating in gossip directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7820) Remove fat client mode
[ https://issues.apache.org/jira/browse/CASSANDRA-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133404#comment-14133404 ] Brandon Williams commented on CASSANDRA-7820: - The simplest example is bootstrapping nodes that haven't completed or fail. > Remove fat client mode > -- > > Key: CASSANDRA-7820 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7820 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Brandon Williams > Fix For: 3.0 > > Attachments: 7820-v1.txt, 7820-v2.txt, 7820-v3.txt > > > Now that we support push notifications server -> client, there's no reason to > have clients participating in gossip directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7820) Remove fat client mode
[ https://issues.apache.org/jira/browse/CASSANDRA-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133398#comment-14133398 ] Jonathan Ellis commented on CASSANDRA-7820: --- What gossip only members will we have left? > Remove fat client mode > -- > > Key: CASSANDRA-7820 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7820 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Brandon Williams > Fix For: 3.0 > > Attachments: 7820-v1.txt, 7820-v2.txt, 7820-v3.txt > > > Now that we support push notifications server -> client, there's no reason to > have clients participating in gossip directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7820) Remove fat client mode
[ https://issues.apache.org/jira/browse/CASSANDRA-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132838#comment-14132838 ] Brandon Williams commented on CASSANDRA-7820: - On commit I'll probably rename Gossiper.isFatClient to something else so we can be rid of this terminology altogether. Perhaps isGossipOnlyMember unless there's a better idea. > Remove fat client mode > -- > > Key: CASSANDRA-7820 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7820 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Brandon Williams > Fix For: 3.0 > > Attachments: 7820-v1.txt, 7820-v2.txt, 7820-v3.txt > > > Now that we support push notifications server -> client, there's no reason to > have clients participating in gossip directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7820) Remove fat client mode
[ https://issues.apache.org/jira/browse/CASSANDRA-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132541#comment-14132541 ] Brandon Williams commented on CASSANDRA-7820: - I understand now, the only reason initClient was still being called was to start MS, and v2 populated the hibernate state but never actually gossiped, so it worked too. > Remove fat client mode > -- > > Key: CASSANDRA-7820 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7820 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Brandon Williams > Fix For: 3.0 > > Attachments: 7820-v1.txt, 7820-v2.txt > > > Now that we support push notifications server -> client, there's no reason to > have clients participating in gossip directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7820) Remove fat client mode
[ https://issues.apache.org/jira/browse/CASSANDRA-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132372#comment-14132372 ] Brandon Williams commented on CASSANDRA-7820: - Yes, they use SS.initClient, but it's the pulling schema via thrift that gives me hope that converting them to *gossip* fat clients will work. > Remove fat client mode > -- > > Key: CASSANDRA-7820 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7820 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Brandon Williams > Fix For: 3.0 > > Attachments: 7820-v1.txt > > > Now that we support push notifications server -> client, there's no reason to > have clients participating in gossip directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7820) Remove fat client mode
[ https://issues.apache.org/jira/browse/CASSANDRA-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132367#comment-14132367 ] Yuki Morishita commented on CASSANDRA-7820: --- bq. Bulk loaders are fat clients Are they? They pull schema using thrift (for now). > Remove fat client mode > -- > > Key: CASSANDRA-7820 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7820 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Brandon Williams > Fix For: 3.0 > > Attachments: 7820-v1.txt > > > Now that we support push notifications server -> client, there's no reason to > have clients participating in gossip directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7820) Remove fat client mode
[ https://issues.apache.org/jira/browse/CASSANDRA-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132320#comment-14132320 ] Brandon Williams commented on CASSANDRA-7820: - We *might* be able to get away with putting them in hibernate, which would prevent any events from being sent to SS from the Gossiper. > Remove fat client mode > -- > > Key: CASSANDRA-7820 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7820 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Brandon Williams > Fix For: 3.0 > > Attachments: 7820-v1.txt > > > Now that we support push notifications server -> client, there's no reason to > have clients participating in gossip directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7820) Remove fat client mode
[ https://issues.apache.org/jira/browse/CASSANDRA-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132313#comment-14132313 ] Jonathan Ellis commented on CASSANDRA-7820: --- Well, crap. > Remove fat client mode > -- > > Key: CASSANDRA-7820 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7820 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Brandon Williams > Fix For: 3.0 > > Attachments: 7820-v1.txt > > > Now that we support push notifications server -> client, there's no reason to > have clients participating in gossip directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7820) Remove fat client mode
[ https://issues.apache.org/jira/browse/CASSANDRA-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132303#comment-14132303 ] Brandon Williams commented on CASSANDRA-7820: - Note that this isn't to remove 'fat client gossip mode' since the concept will still need to exist there for nodes that are members of gossip, but not SS (think bootstrapping nodes, for instance.) The wrinkle with removing actual client mode comes down to bulk loading. Bulk loaders are fat clients, so we'll still need the mess of checks we do everywhere to avoid doing 'real node' things. :( > Remove fat client mode > -- > > Key: CASSANDRA-7820 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7820 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Brandon Williams > Fix For: 3.0 > > > Now that we support push notifications server -> client, there's no reason to > have clients participating in gossip directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
