[jira] [Commented] (CASSANDRA-8212) Archive Commitlog Test Failing

2014-11-25 Thread Sam Tunnicliffe (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224665#comment-14224665
 ] 

Sam Tunnicliffe commented on CASSANDRA-8212:


yes, this test appears to have been broken on 2.0 since it was introduced in 
[18f4a4b|https://github.com/riptano/cassandra-dtest/commit/18f4a4b8f6a033cc74c5036a8aeef6241992d011].
 The reason is that 2.0 does not force any active commit log segments to be 
recycled during drain, which means they are also not archived. Because this 
test actually destroys the cluster midway through, any mutations in these 
active segments will be lost. Another test in the fixture archives the active 
segments manually and that one passes as expected. The test passes on 2.1 due 
to substantial changes in CommitLog, including the forced recycling of any 
active commit logs during drain.

Seems like the right thing to do is to just the failing test {{@since('2.1')}} 
as it is the case that before then active segments need to be manually archived 
(if the cl dir is cleared, CASSANDRA-6904 adds archival of existing segments at 
startup). What do you think [~philipthompson]?

 Archive Commitlog Test Failing
 --

 Key: CASSANDRA-8212
 URL: https://issues.apache.org/jira/browse/CASSANDRA-8212
 Project: Cassandra
  Issue Type: Bug
Reporter: Philip Thompson
Assignee: Sam Tunnicliffe
 Fix For: 2.0.12


 The test snapshot_test.TestArchiveCommitlog.test_archive_commitlog is failing 
 on 2.0.11, but not 2.1.1. We attempt to replay 65000 rows, but in 2.0.11 only 
 63000 rows succeed. URL for test output:
 http://cassci.datastax.com/job/cassandra-2.0_dtest/lastCompletedBuild/testReport/snapshot_test/TestArchiveCommitlog/test_archive_commitlog/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CASSANDRA-8212) Archive Commitlog Test Failing

2014-11-25 Thread Philip Thompson (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224912#comment-14224912
 ] 

Philip Thompson commented on CASSANDRA-8212:


To confirm, because we have another test that archives the active segments 
manually, then restricting this test to 2.1+ isn't causing a loss of 2.0 
coverage? Then I'm fine restricting it as such.

 Archive Commitlog Test Failing
 --

 Key: CASSANDRA-8212
 URL: https://issues.apache.org/jira/browse/CASSANDRA-8212
 Project: Cassandra
  Issue Type: Bug
Reporter: Philip Thompson
Assignee: Sam Tunnicliffe
 Fix For: 2.0.12


 The test snapshot_test.TestArchiveCommitlog.test_archive_commitlog is failing 
 on 2.0.11, but not 2.1.1. We attempt to replay 65000 rows, but in 2.0.11 only 
 63000 rows succeed. URL for test output:
 http://cassci.datastax.com/job/cassandra-2.0_dtest/lastCompletedBuild/testReport/snapshot_test/TestArchiveCommitlog/test_archive_commitlog/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CASSANDRA-8212) Archive Commitlog Test Failing

2014-11-25 Thread Sam Tunnicliffe (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224931#comment-14224931
 ] 

Sam Tunnicliffe commented on CASSANDRA-8212:


Right, {{test_archive_commitlog_with_active_commitlog}} does the manual 
archival of active segments (and passes on 2.0). 

 Archive Commitlog Test Failing
 --

 Key: CASSANDRA-8212
 URL: https://issues.apache.org/jira/browse/CASSANDRA-8212
 Project: Cassandra
  Issue Type: Bug
Reporter: Philip Thompson
Assignee: Sam Tunnicliffe
 Fix For: 2.0.12


 The test snapshot_test.TestArchiveCommitlog.test_archive_commitlog is failing 
 on 2.0.11, but not 2.1.1. We attempt to replay 65000 rows, but in 2.0.11 only 
 63000 rows succeed. URL for test output:
 http://cassci.datastax.com/job/cassandra-2.0_dtest/lastCompletedBuild/testReport/snapshot_test/TestArchiveCommitlog/test_archive_commitlog/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CASSANDRA-8212) Archive Commitlog Test Failing

2014-11-25 Thread Philip Thompson (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224933#comment-14224933
 ] 

Philip Thompson commented on CASSANDRA-8212:


Okay, since this is a test issue I've reassigned the ticket to me and changed 
the type. Thanks [~beobal]

 Archive Commitlog Test Failing
 --

 Key: CASSANDRA-8212
 URL: https://issues.apache.org/jira/browse/CASSANDRA-8212
 Project: Cassandra
  Issue Type: Test
Reporter: Philip Thompson
Assignee: Philip Thompson
 Fix For: 2.0.12


 The test snapshot_test.TestArchiveCommitlog.test_archive_commitlog is failing 
 on 2.0.11, but not 2.1.1. We attempt to replay 65000 rows, but in 2.0.11 only 
 63000 rows succeed. URL for test output:
 http://cassci.datastax.com/job/cassandra-2.0_dtest/lastCompletedBuild/testReport/snapshot_test/TestArchiveCommitlog/test_archive_commitlog/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)