[jira] [Commented] (CASSANDRA-8373) MOVED_NODE Topology Change event is never emitted
[
https://issues.apache.org/jira/browse/CASSANDRA-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252650#comment-14252650
]
Tyler Hobbs commented on CASSANDRA-8373:
I looked into the single-node problem briefly and it wasn't clear how to fix
things. {{updateNormalTokens()}} gets called frequently, which has the effect
of removing nodes from the "moving" set. Since a single node moving isn't a
terribly important case, I think it's worth committing what we have and
splitting that out. I've opened CASSANDRA-8516 and assigned it to
[~brandon.williams] to take a look at.
> MOVED_NODE Topology Change event is never emitted
> -
>
> Key: CASSANDRA-8373
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8373
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Reporter: Adam Holmberg
>Priority: Minor
> Fix For: 2.0.12, 2.1.3
>
> Attachments: 8373.txt
>
>
> lifeCycleSubscribers.onMove never gets called because [this
> tokenMetadata.updateNormalTokens|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/StorageService.java#L1585]
> call [changes the endpoint moving
> status|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/locator/TokenMetadata.java#L190],
> making the later isMoving conditional always false.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8373) MOVED_NODE Topology Change event is never emitted
[
https://issues.apache.org/jira/browse/CASSANDRA-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232047#comment-14232047
]
Tyler Hobbs commented on CASSANDRA-8373:
On 2.0, this gives the correct behavior with a multi-node cluster, but with a
single-node cluster a {{NEW_NODE}} notification is sent instead of a
{{MOVED_NODE}} notification. It looks the single-node behavior is also present
in 2.0, but it would be nice to fix that here as well.
> MOVED_NODE Topology Change event is never emitted
> -
>
> Key: CASSANDRA-8373
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8373
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Minor
> Fix For: 2.0.12, 2.1.3
>
> Attachments: 8373.txt
>
>
> lifeCycleSubscribers.onMove never gets called because [this
> tokenMetadata.updateNormalTokens|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/StorageService.java#L1585]
> call [changes the endpoint moving
> status|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/locator/TokenMetadata.java#L190],
> making the later isMoving conditional always false.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
