[jira] [Commented] (CASSANDRA-8749) Cleanup SegmentedFile
[ https://issues.apache.org/jira/browse/CASSANDRA-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313932#comment-14313932 ] Marcus Eriksson commented on CASSANDRA-8749: +1 > Cleanup SegmentedFile > - > > Key: CASSANDRA-8749 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8749 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benedict >Assignee: Benedict >Priority: Trivial > Fix For: 2.1.4 > > > As a follow up to 8707 (building upon it for ease, since that edits these > files), and a precursor to another follow up, this ticket cleans up the > SegmentedFile hierarchy a little, and makes it encapsulate the construction > of a new reader, so we implementation details don't leak into SSTableReader. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8749) Cleanup SegmentedFile
[ https://issues.apache.org/jira/browse/CASSANDRA-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313928#comment-14313928 ] Benedict commented on CASSANDRA-8749: - force-pushed a version with some of the MmappedSegmentedFile changes rolled back, since they were a mistake (i've added some comments to explain their behaviour, since it wasn't clear before) > Cleanup SegmentedFile > - > > Key: CASSANDRA-8749 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8749 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benedict >Assignee: Benedict >Priority: Trivial > Fix For: 2.1.4 > > > As a follow up to 8707 (building upon it for ease, since that edits these > files), and a precursor to another follow up, this ticket cleans up the > SegmentedFile hierarchy a little, and makes it encapsulate the construction > of a new reader, so we implementation details don't leak into SSTableReader. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8749) Cleanup SegmentedFile
[ https://issues.apache.org/jira/browse/CASSANDRA-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307922#comment-14307922 ] Benedict commented on CASSANDRA-8749: - Patch available [here|https://github.com/belliottsmith/cassandra/tree/cleanup-segmentedfile] > Cleanup SegmentedFile > - > > Key: CASSANDRA-8749 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8749 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Benedict >Assignee: Benedict >Priority: Trivial > Fix For: 2.1.4 > > > As a follow up to 8707 (building upon it for ease, since that edits these > files), and a precursor to another follow up, this ticket cleans up the > SegmentedFile hierarchy a little, and makes it encapsulate the construction > of a new reader, so we implementation details don't leak into SSTableReader. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
