[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047215#comment-15047215 ] Carl Yeksigian commented on CASSANDRA-8805: --- [~krummas] just pushed rebased branches. > runWithCompactionsDisabled only cancels compactions, which is not the only > source of markCompacted > -- > > Key: CASSANDRA-8805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 > Project: Cassandra > Issue Type: Bug >Reporter: Benedict >Assignee: Carl Yeksigian > Fix For: 2.1.x > > Attachments: 8805-2.1.txt > > > Operations like repair that may operate over all sstables cancel compactions > before beginning, and fail if there are any files marked compacting after > doing so. Redistribution of index summaries is not a compaction, so is not > cancelled by this action, but does mark sstables as compacting, so such an > action will fail to initiate if there is an index summary redistribution in > progress. It seems that IndexSummaryManager needs to register itself as > interruptible along with compactions (AFAICT no other actions that may > markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026972#comment-15026972 ] Marcus Eriksson commented on CASSANDRA-8805: ok, +1 could you rebase the branches? > runWithCompactionsDisabled only cancels compactions, which is not the only > source of markCompacted > -- > > Key: CASSANDRA-8805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 > Project: Cassandra > Issue Type: Bug >Reporter: Benedict >Assignee: Carl Yeksigian > Fix For: 2.1.x > > Attachments: 8805-2.1.txt > > > Operations like repair that may operate over all sstables cancel compactions > before beginning, and fail if there are any files marked compacting after > doing so. Redistribution of index summaries is not a compaction, so is not > cancelled by this action, but does mark sstables as compacting, so such an > action will fail to initiate if there is an index summary redistribution in > progress. It seems that IndexSummaryManager needs to register itself as > interruptible along with compactions (AFAICT no other actions that may > markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024796#comment-15024796 ] Carl Yeksigian commented on CASSANDRA-8805: --- Pushed a commit which checks the sstables and the data. Kicked off new cassci runs. > runWithCompactionsDisabled only cancels compactions, which is not the only > source of markCompacted > -- > > Key: CASSANDRA-8805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 > Project: Cassandra > Issue Type: Bug >Reporter: Benedict >Assignee: Carl Yeksigian > Fix For: 2.1.x > > Attachments: 8805-2.1.txt > > > Operations like repair that may operate over all sstables cancel compactions > before beginning, and fail if there are any files marked compacting after > doing so. Redistribution of index summaries is not a compaction, so is not > cancelled by this action, but does mark sstables as compacting, so such an > action will fail to initiate if there is an index summary redistribution in > progress. It seems that IndexSummaryManager needs to register itself as > interruptible along with compactions (AFAICT no other actions that may > markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006393#comment-15006393 ] Marcus Eriksson commented on CASSANDRA-8805: Patch looks good to me, but in the new test, could we verify that the tracker has the correct sstable instances? (ie, just verify that the finally clause in adjustSamplingLevels actually does the right thing). Also perhaps validate the data in StandardLowIndexInterval after compaction cancellation? > runWithCompactionsDisabled only cancels compactions, which is not the only > source of markCompacted > -- > > Key: CASSANDRA-8805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 > Project: Cassandra > Issue Type: Bug >Reporter: Benedict >Assignee: Carl Yeksigian > Fix For: 2.1.x > > Attachments: 8805-2.1.txt > > > Operations like repair that may operate over all sstables cancel compactions > before beginning, and fail if there are any files marked compacting after > doing so. Redistribution of index summaries is not a compaction, so is not > cancelled by this action, but does mark sstables as compacting, so such an > action will fail to initiate if there is an index summary redistribution in > progress. It seems that IndexSummaryManager needs to register itself as > interruptible along with compactions (AFAICT no other actions that may > markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004507#comment-15004507 ] Joshua McKenzie commented on CASSANDRA-8805: Swapped reviewer to [~krummas] for the home-stretch as Benedict's on vacation. > runWithCompactionsDisabled only cancels compactions, which is not the only > source of markCompacted > -- > > Key: CASSANDRA-8805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 > Project: Cassandra > Issue Type: Bug >Reporter: Benedict >Assignee: Carl Yeksigian > Fix For: 2.1.x > > Attachments: 8805-2.1.txt > > > Operations like repair that may operate over all sstables cancel compactions > before beginning, and fail if there are any files marked compacting after > doing so. Redistribution of index summaries is not a compaction, so is not > cancelled by this action, but does mark sstables as compacting, so such an > action will fail to initiate if there is an index summary redistribution in > progress. It seems that IndexSummaryManager needs to register itself as > interruptible along with compactions (AFAICT no other actions that may > markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004473#comment-15004473 ] Carl Yeksigian commented on CASSANDRA-8805: --- I've pushed a rebased and squashed version, and merged it forward to trunk: || 2.1 || 2.2 || 3.0 || trunk || | [branch|https://github.com/carlyeks/cassandra/tree/ticket/8805/2.1] | [branch|https://github.com/carlyeks/cassandra/tree/ticket/8805/2.2] | [branch|https://github.com/carlyeks/cassandra/tree/ticket/8805/3.0] | [branch|https://github.com/carlyeks/cassandra/tree/ticket/8805/trunk] | | [utest|http://cassci.datastax.com/view/Dev/view/carlyeks/job/carlyeks-ticket-8805-2.1-testall/] | [utest|http://cassci.datastax.com/view/Dev/view/carlyeks/job/carlyeks-ticket-8805-2.2-testall/] | [utest|http://cassci.datastax.com/view/Dev/view/carlyeks/job/carlyeks-ticket-8805-3.0-testall/] | [utest|http://cassci.datastax.com/view/Dev/view/carlyeks/job/carlyeks-ticket-8805-trunk-testall/] | | [dtest|http://cassci.datastax.com/view/Dev/view/carlyeks/job/carlyeks-ticket-8805-2.1-dtest/] | [dtest|http://cassci.datastax.com/view/Dev/view/carlyeks/job/carlyeks-ticket-8805-2.2-dtest/] | [dtest|http://cassci.datastax.com/view/Dev/view/carlyeks/job/carlyeks-ticket-8805-3.0-dtest/] | [dtest|http://cassci.datastax.com/view/Dev/view/carlyeks/job/carlyeks-ticket-8805-trunk-dtest/] | > runWithCompactionsDisabled only cancels compactions, which is not the only > source of markCompacted > -- > > Key: CASSANDRA-8805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 > Project: Cassandra > Issue Type: Bug >Reporter: Benedict >Assignee: Carl Yeksigian > Fix For: 2.1.x > > Attachments: 8805-2.1.txt > > > Operations like repair that may operate over all sstables cancel compactions > before beginning, and fail if there are any files marked compacting after > doing so. Redistribution of index summaries is not a compaction, so is not > cancelled by this action, but does mark sstables as compacting, so such an > action will fail to initiate if there is an index summary redistribution in > progress. It seems that IndexSummaryManager needs to register itself as > interruptible along with compactions (AFAICT no other actions that may > markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743887#comment-14743887 ] Carl Yeksigian commented on CASSANDRA-8805: --- Sorry, I missed that you had moved it up -- looks good. > runWithCompactionsDisabled only cancels compactions, which is not the only > source of markCompacted > -- > > Key: CASSANDRA-8805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Benedict >Assignee: Carl Yeksigian > Fix For: 2.1.x > > Attachments: 8805-2.1.txt > > > Operations like repair that may operate over all sstables cancel compactions > before beginning, and fail if there are any files marked compacting after > doing so. Redistribution of index summaries is not a compaction, so is not > cancelled by this action, but does mark sstables as compacting, so such an > action will fail to initiate if there is an index summary redistribution in > progress. It seems that IndexSummaryManager needs to register itself as > interruptible along with compactions (AFAICT no other actions that may > markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743872#comment-14743872
]
Carl Yeksigian commented on CASSANDRA-8805:
---
I think you need to add the {{newSSTables.add}} back to the finally clause.
Otherwise, changes look good.
> runWithCompactionsDisabled only cancels compactions, which is not the only
> source of markCompacted
> --
>
> Key: CASSANDRA-8805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8805
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Reporter: Benedict
>Assignee: Carl Yeksigian
> Fix For: 2.1.x
>
> Attachments: 8805-2.1.txt
>
>
> Operations like repair that may operate over all sstables cancel compactions
> before beginning, and fail if there are any files marked compacting after
> doing so. Redistribution of index summaries is not a compaction, so is not
> cancelled by this action, but does mark sstables as compacting, so such an
> action will fail to initiate if there is an index summary redistribution in
> progress. It seems that IndexSummaryManager needs to register itself as
> interruptible along with compactions (AFAICT no other actions that may
> markCompacting are not themselves compactions).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743881#comment-14743881 ] Benedict commented on CASSANDRA-8805: - There wasn't a finally clause before, and it's currently being executed in all normal executions (whereas under failure it is discarded anyway), so I must admit I'm not certain what you're reasoning is. If you could elaborate I'd appreciate it. > runWithCompactionsDisabled only cancels compactions, which is not the only > source of markCompacted > -- > > Key: CASSANDRA-8805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Benedict >Assignee: Carl Yeksigian > Fix For: 2.1.x > > Attachments: 8805-2.1.txt > > > Operations like repair that may operate over all sstables cancel compactions > before beginning, and fail if there are any files marked compacting after > doing so. Redistribution of index summaries is not a compaction, so is not > cancelled by this action, but does mark sstables as compacting, so such an > action will fail to initiate if there is an index summary redistribution in > progress. It seems that IndexSummaryManager needs to register itself as > interruptible along with compactions (AFAICT no other actions that may > markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743949#comment-14743949 ] Benedict commented on CASSANDRA-8805: - OK, great. Could you post upstream branch merges? > runWithCompactionsDisabled only cancels compactions, which is not the only > source of markCompacted > -- > > Key: CASSANDRA-8805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Benedict >Assignee: Carl Yeksigian > Fix For: 2.1.x > > Attachments: 8805-2.1.txt > > > Operations like repair that may operate over all sstables cancel compactions > before beginning, and fail if there are any files marked compacting after > doing so. Redistribution of index summaries is not a compaction, so is not > cancelled by this action, but does mark sstables as compacting, so such an > action will fail to initiate if there is an index summary redistribution in > progress. It seems that IndexSummaryManager needs to register itself as > interruptible along with compactions (AFAICT no other actions that may > markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742717#comment-14742717 ] Benedict commented on CASSANDRA-8805: - Thanks. I've pushed a version [here|https://github.com/belliottsmith/cassandra/tree/8805], which just cleans up ever so slightly. As a note for the future, it's very helpful for review to avoid squashing until after we're ready to commit (or we reach some mutually agreed way point) > runWithCompactionsDisabled only cancels compactions, which is not the only > source of markCompacted > -- > > Key: CASSANDRA-8805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Benedict >Assignee: Carl Yeksigian > Fix For: 2.1.x > > Attachments: 8805-2.1.txt > > > Operations like repair that may operate over all sstables cancel compactions > before beginning, and fail if there are any files marked compacting after > doing so. Redistribution of index summaries is not a compaction, so is not > cancelled by this action, but does mark sstables as compacting, so such an > action will fail to initiate if there is an index summary redistribution in > progress. It seems that IndexSummaryManager needs to register itself as > interruptible along with compactions (AFAICT no other actions that may > markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569384#comment-14569384
]
Benedict commented on CASSANDRA-8805:
-
The rollback logic in the event of CIE is, unfortunately, likely to break
things. Once a reader replaces another, it needs to be published or itself
replaced. So we should either make visible the newly sampled readers (excluding
the ones we haven't completed), or we should construct a new instance with the
old summaries that are publised.
Since the operation can also be very expensive, we should probably extract the
resampling into a method that can itself check for the {{isStopRequested}},
otherwise it could take a long time to acquiesce.
runWithCompactionsDisabled only cancels compactions, which is not the only
source of markCompacted
--
Key: CASSANDRA-8805
URL: https://issues.apache.org/jira/browse/CASSANDRA-8805
Project: Cassandra
Issue Type: Bug
Components: Core
Reporter: Benedict
Assignee: Carl Yeksigian
Fix For: 2.1.x
Attachments: 8805-2.1.txt
Operations like repair that may operate over all sstables cancel compactions
before beginning, and fail if there are any files marked compacting after
doing so. Redistribution of index summaries is not a compaction, so is not
cancelled by this action, but does mark sstables as compacting, so such an
action will fail to initiate if there is an index summary redistribution in
progress. It seems that IndexSummaryManager needs to register itself as
interruptible along with compactions (AFAICT no other actions that may
markCompacting are not themselves compactions).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14567402#comment-14567402 ] Carl Yeksigian commented on CASSANDRA-8805: --- I pushed up an [update|https://github.com/carlyeks/cassandra/tree/ticket/8805], but there is an issue with the tests timing out when the cancel test is run before the compaction race test (http://cassci.datastax.com/view/Dev/view/carlyeks/job/carlyeks-ticket-8805-testall/). runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted -- Key: CASSANDRA-8805 URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 Project: Cassandra Issue Type: Bug Components: Core Reporter: Benedict Assignee: Carl Yeksigian Fix For: 2.1.x Attachments: 8805-2.1.txt Operations like repair that may operate over all sstables cancel compactions before beginning, and fail if there are any files marked compacting after doing so. Redistribution of index summaries is not a compaction, so is not cancelled by this action, but does mark sstables as compacting, so such an action will fail to initiate if there is an index summary redistribution in progress. It seems that IndexSummaryManager needs to register itself as interruptible along with compactions (AFAICT no other actions that may markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555778#comment-14555778 ] Benedict commented on CASSANDRA-8805: - [~carlyeks]: The general approach looks good, but could I get a proper (rebased) branch up? If you could get things into a ready to commit state with CHANGES.txt wired up as well, that would be appreciated. I would like to move away from dealing with patch files, as it isn't conducive to the new commit process. runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted -- Key: CASSANDRA-8805 URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 Project: Cassandra Issue Type: Bug Components: Core Reporter: Benedict Assignee: Carl Yeksigian Fix For: 2.1.x Attachments: 8805-2.1.txt Operations like repair that may operate over all sstables cancel compactions before beginning, and fail if there are any files marked compacting after doing so. Redistribution of index summaries is not a compaction, so is not cancelled by this action, but does mark sstables as compacting, so such an action will fail to initiate if there is an index summary redistribution in progress. It seems that IndexSummaryManager needs to register itself as interruptible along with compactions (AFAICT no other actions that may markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326263#comment-14326263 ] Tyler Hobbs commented on CASSANDRA-8805: Are the changes to make IndexSummaryManager interruptible all that's needed here? runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted -- Key: CASSANDRA-8805 URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 Project: Cassandra Issue Type: Bug Components: Core Reporter: Benedict Fix For: 2.1.4 Operations like repair that may operate over all sstables cancel compactions before beginning, and fail if there are any files marked compacting after doing so. Redistribution of index summaries is not a compaction, so is not cancelled by this action, but does mark sstables as compacting, so such an action will fail to initiate if there is an index summary redistribution in progress. It seems that IndexSummaryManager needs to register itself as interruptible along with compactions (AFAICT no other actions that may markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326284#comment-14326284 ] Benedict commented on CASSANDRA-8805: - Pretty much. I think the best thing to do is create a new OperationType and register a CompactionInfo.Holder for it, so that it plugs into the existing framework runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted -- Key: CASSANDRA-8805 URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 Project: Cassandra Issue Type: Bug Components: Core Reporter: Benedict Assignee: Benedict Fix For: 2.1.4 Operations like repair that may operate over all sstables cancel compactions before beginning, and fail if there are any files marked compacting after doing so. Redistribution of index summaries is not a compaction, so is not cancelled by this action, but does mark sstables as compacting, so such an action will fail to initiate if there is an index summary redistribution in progress. It seems that IndexSummaryManager needs to register itself as interruptible along with compactions (AFAICT no other actions that may markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326378#comment-14326378 ] Benedict commented on CASSANDRA-8805: - Not sure how I keep accidentally changing assignee to myself. Must be some keyboard shortcut... runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted -- Key: CASSANDRA-8805 URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 Project: Cassandra Issue Type: Bug Components: Core Reporter: Benedict Fix For: 2.1.4 Operations like repair that may operate over all sstables cancel compactions before beginning, and fail if there are any files marked compacting after doing so. Redistribution of index summaries is not a compaction, so is not cancelled by this action, but does mark sstables as compacting, so such an action will fail to initiate if there is an index summary redistribution in progress. It seems that IndexSummaryManager needs to register itself as interruptible along with compactions (AFAICT no other actions that may markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322704#comment-14322704 ] Benedict commented on CASSANDRA-8805: - /cc [~thobbs] runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted -- Key: CASSANDRA-8805 URL: https://issues.apache.org/jira/browse/CASSANDRA-8805 Project: Cassandra Issue Type: Bug Components: Core Reporter: Benedict Fix For: 2.1.4 Operations like repair that may operate over all sstables cancel compactions before beginning, and fail if there are any files marked compacting after doing so. Redistribution of index summaries is not a compaction, so is not cancelled by this action, but does mark sstables as compacting, so such an action will fail to initiate if there is an index summary redistribution in progress. It seems that IndexSummaryManager needs to register itself as interruptible along with compactions (AFAICT no other actions that may markCompacting are not themselves compactions). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
