[jira] [Commented] (CASSANDRA-8834) Top partitions reporting wrong cardinality
[ https://issues.apache.org/jira/browse/CASSANDRA-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346400#comment-14346400 ] Aleksey Yeschenko commented on CASSANDRA-8834: -- Committed, thanks. > Top partitions reporting wrong cardinality > -- > > Key: CASSANDRA-8834 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8834 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Chris Lohfink >Assignee: Chris Lohfink > Fix For: 2.1.4 > > Attachments: CASSANDRA-8834-v3.txt, cardinality.patch > > > It always reports a cardinality of 1. Patch also includes a try/catch around > the conversion of partition keys that isn't always handled well in thrift cfs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8834) Top partitions reporting wrong cardinality
[ https://issues.apache.org/jira/browse/CASSANDRA-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346383#comment-14346383 ] Chris Lohfink commented on CASSANDRA-8834: -- messed up v2 patch, v3 is with fix > Top partitions reporting wrong cardinality > -- > > Key: CASSANDRA-8834 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8834 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Chris Lohfink >Assignee: Chris Lohfink > Fix For: 2.1.4 > > Attachments: CASSANDRA-8834-v3.txt, cardinality.patch > > > It always reports a cardinality of 1. Patch also includes a try/catch around > the conversion of partition keys that isn't always handled well in thrift cfs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8834) Top partitions reporting wrong cardinality
[ https://issues.apache.org/jira/browse/CASSANDRA-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346374#comment-14346374 ] Chris Lohfink commented on CASSANDRA-8834: -- changed to actually use the token's hash since already using md5/murmur for good enough distribution for HLL and then can avoid needing the byte[] for clearsprings murmur impl. Also removed try/catch for marshal exception > Top partitions reporting wrong cardinality > -- > > Key: CASSANDRA-8834 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8834 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Chris Lohfink >Assignee: Chris Lohfink > Fix For: 2.1.4 > > Attachments: CASSANDRA-8834-v2.txt, cardinality.patch > > > It always reports a cardinality of 1. Patch also includes a try/catch around > the conversion of partition keys that isn't always handled well in thrift cfs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8834) Top partitions reporting wrong cardinality
[ https://issues.apache.org/jira/browse/CASSANDRA-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345953#comment-14345953 ] Aleksey Yeschenko commented on CASSANDRA-8834: -- Probably a stress bug (using a partition key of the wrong type), so no need to guard against that. Another issue I see is accessing BB#array() of the partition key directly in CFS#apply(). You can't rely on it being available. > Top partitions reporting wrong cardinality > -- > > Key: CASSANDRA-8834 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8834 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Chris Lohfink >Assignee: Chris Lohfink > Fix For: 2.1.4 > > Attachments: cardinality.patch > > > It always reports a cardinality of 1. Patch also includes a try/catch around > the conversion of partition keys that isn't always handled well in thrift cfs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8834) Top partitions reporting wrong cardinality
[ https://issues.apache.org/jira/browse/CASSANDRA-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345229#comment-14345229 ] Chris Lohfink commented on CASSANDRA-8834: -- So I cant seem to reproduce it but I when testing after upgrading to 2.1.3 (along with stress tool upgrade that happened there) I was getting that exception from there, which I can neither explain or have happen again... Something involving the change in schema when going from old pure thrift table to what cqlstress creates now I assumed. > Top partitions reporting wrong cardinality > -- > > Key: CASSANDRA-8834 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8834 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Chris Lohfink >Assignee: Chris Lohfink > Fix For: 2.1.4 > > Attachments: cardinality.patch > > > It always reports a cardinality of 1. Patch also includes a try/catch around > the conversion of partition keys that isn't always handled well in thrift cfs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8834) Top partitions reporting wrong cardinality
[ https://issues.apache.org/jira/browse/CASSANDRA-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1431#comment-1431 ] Aleksey Yeschenko commented on CASSANDRA-8834: -- bq. Patch also includes a try/catch around the conversion of partition keys that isn't always handled well in thrift cfs. Can you give me an example? This should never be the case, and Thrift vs no-Thrift is irrelevant. > Top partitions reporting wrong cardinality > -- > > Key: CASSANDRA-8834 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8834 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Chris Lohfink >Assignee: Chris Lohfink > Fix For: 2.1.4 > > Attachments: cardinality.patch > > > It always reports a cardinality of 1. Patch also includes a try/catch around > the conversion of partition keys that isn't always handled well in thrift cfs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8834) Top partitions reporting wrong cardinality
[ https://issues.apache.org/jira/browse/CASSANDRA-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329034#comment-14329034 ] Chris Lohfink commented on CASSANDRA-8834: -- patch is against 2.1 branch > Top partitions reporting wrong cardinality > -- > > Key: CASSANDRA-8834 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8834 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Chris Lohfink >Assignee: Chris Lohfink > Attachments: cardinality.patch > > > It always reports a cardinality of 1. Patch also includes a try/catch around > the conversion of partition keys that isn't always handled well in thrift cfs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8834) Top partitions reporting wrong cardinality
[ https://issues.apache.org/jira/browse/CASSANDRA-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328462#comment-14328462 ] Aleksey Yeschenko commented on CASSANDRA-8834: -- Fixver? > Top partitions reporting wrong cardinality > -- > > Key: CASSANDRA-8834 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8834 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Chris Lohfink >Assignee: Chris Lohfink > Attachments: cardinality.patch > > > It always reports a cardinality of 1. Patch also includes a try/catch around > the conversion of partition keys that isn't always handled well in thrift cfs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
