[jira] [Commented] (CASSANDRA-8966) SequentialWriter should be Ref counted
[ https://issues.apache.org/jira/browse/CASSANDRA-8966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375380#comment-14375380 ] Eric Medley commented on CASSANDRA-8966: There seems to be a lot of changes wrt CASSANDRA-8984. I will wait until this is committed to trunk. SequentialWriter should be Ref counted -- Key: CASSANDRA-8966 URL: https://issues.apache.org/jira/browse/CASSANDRA-8966 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Benedict Priority: Minor Fix For: 3.0 A LHF to introduce some more resource safety -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8966) SequentialWriter should be Ref counted
[ https://issues.apache.org/jira/browse/CASSANDRA-8966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366253#comment-14366253 ] Benedict commented on CASSANDRA-8966: - Another FYI, that I've left out the headline aspect of this ticket from the change I'm filing, so if you're still interested in making this addition you're welcome to have a crack at it! CASSANDRA-8984 refactors the APIs to make them safer, but does not introduce Ref counting. SequentialWriter should be Ref counted -- Key: CASSANDRA-8966 URL: https://issues.apache.org/jira/browse/CASSANDRA-8966 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Benedict Priority: Minor Fix For: 3.0 A LHF to introduce some more resource safety -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8966) SequentialWriter should be Ref counted
[ https://issues.apache.org/jira/browse/CASSANDRA-8966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14365069#comment-14365069 ] Benedict commented on CASSANDRA-8966: - Just an FYI that I'm looking at this now also, and plan to commit a patch shortly including it, along with some final tidying up of the contracts in SSTableRewriter, SSTableWriter et al, to improve safety under failure SequentialWriter should be Ref counted -- Key: CASSANDRA-8966 URL: https://issues.apache.org/jira/browse/CASSANDRA-8966 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Benedict Priority: Minor Fix For: 3.0 A LHF to introduce some more resource safety -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8966) SequentialWriter should be Ref counted
[ https://issues.apache.org/jira/browse/CASSANDRA-8966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361681#comment-14361681 ] Eric Medley commented on CASSANDRA-8966: What should happen if the writer is still open when it becomes unreferenced? Should it be closed or aborted? SequentialWriter should be Ref counted -- Key: CASSANDRA-8966 URL: https://issues.apache.org/jira/browse/CASSANDRA-8966 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Benedict Priority: Minor Fix For: 3.0 A LHF to introduce some more resource safety -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8966) SequentialWriter should be Ref counted
[ https://issues.apache.org/jira/browse/CASSANDRA-8966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361704#comment-14361704 ] Benedict commented on CASSANDRA-8966: - Aborted. I would also like to change the contract of this, SSTableWriter and SSTableRewriter so that all implement AutoCloseable, where close() calls abort() unless finish() (or another commit-style call) is called beforehand. So that we can more easily use these in RAII fashion. SequentialWriter should be Ref counted -- Key: CASSANDRA-8966 URL: https://issues.apache.org/jira/browse/CASSANDRA-8966 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Benedict Priority: Minor Fix For: 3.0 A LHF to introduce some more resource safety -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8966) SequentialWriter should be Ref counted
[ https://issues.apache.org/jira/browse/CASSANDRA-8966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361719#comment-14361719 ] Eric Medley commented on CASSANDRA-8966: I'll give this a go SequentialWriter should be Ref counted -- Key: CASSANDRA-8966 URL: https://issues.apache.org/jira/browse/CASSANDRA-8966 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Benedict Priority: Minor Fix For: 3.0 A LHF to introduce some more resource safety -- This message was sent by Atlassian JIRA (v6.3.4#6332)
