[jira] [Commented] (CASSANDRA-9022) Node Cleanup deletes all its data after a new node joined the cluster

2015-03-24 Thread Benedict (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377850#comment-14377850
 ] 

Benedict commented on CASSANDRA-9022:
-

Yep, committed without those changes (which were CASSANDRA-9021)

 Node Cleanup deletes all its data after a new node joined the cluster
 -

 Key: CASSANDRA-9022
 URL: https://issues.apache.org/jira/browse/CASSANDRA-9022
 Project: Cassandra
  Issue Type: Bug
Reporter: Alan Boudreault
Assignee: Benedict
Priority: Critical
 Fix For: 2.1.4

 Attachments: 9022.txt, bisect.sh, results_cassandra_2.1.3.txt, 
 results_cassandra_2.1_branch.txt


 I try to add a node in my cluster and doing some cleanup deleted all my data 
 on a node. This makes the cluster totally broken since all next read seem to 
 not be able to validate the data. Even a repair on the problematic node 
 doesn't fix the issue.  I've attached the bisect script used and the output 
 results of the procedure.
 Procedure to reproduce:
 {code}
 ccm stop  ccm remove
 ccm create -n 2 --install-dir=path/to/cassandra-2.1/branch demo
 ccm start
 ccm node1 stress -- write n=100 -schema replication\(factor=2\) -rate 
 threads=50
 ccm node1 nodetool status
 ccm add -i 127.0.0.3 -j 7400 node3 # no auto-boostrap
 ccm node3 start
 ccm node1 nodetool status
 ccm node3 repair
 ccm node3 nodetool status
 ccm node1 nodetool cleanup
 ccm node2 nodetool cleanup
 ccm node3 nodetool cleanup
 ccm node1 nodetool status
 ccm node1 repair
 ccm node1 stress -- read n=100 ## CRASH Data returned was not validated 
 ?!?
 {code}
 bisec script output:
 {code}
 $ git bisect start cassandra-2.1 cassandra-2.1.3
 $ git bisect run ~/dev/cstar/cleanup_issue/bisect.sh
 ...
 4b05b204acfa60ecad5672c7e6068eb47b21397a is the first bad commit
 commit 4b05b204acfa60ecad5672c7e6068eb47b21397a
 Author: Benedict Elliott Smith bened...@apache.org
 Date:   Wed Feb 11 15:49:43 2015 +
 Enforce SSTableReader.first/last
 
 patch by benedict; reviewed by yukim for CASSANDRA-8744
 :100644 100644 3f0463731e624cbe273dcb3951b2055fa5d9e1a2 
 b2f894eb22b9102d410f1eabeb3e11d26727fbd3 M  CHANGES.txt
 :04 04 51ac2a6cd39bd2377c2e1ed6693ef789ab65a26c 
 79fa2501f4155a64dca2bbdcc9e578008e4e425a M  src
 bisect run success
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-9022) Node Cleanup deletes all its data after a new node joined the cluster

2015-03-24 Thread Alan Boudreault (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378043#comment-14378043
 ] 

Alan Boudreault commented on CASSANDRA-9022:


dtest merged: https://github.com/riptano/cassandra-dtest/pull/203 . Thanks for 
the quick fix Benedict!

 Node Cleanup deletes all its data after a new node joined the cluster
 -

 Key: CASSANDRA-9022
 URL: https://issues.apache.org/jira/browse/CASSANDRA-9022
 Project: Cassandra
  Issue Type: Bug
Reporter: Alan Boudreault
Assignee: Benedict
Priority: Critical
  Labels: qa-resolved
 Fix For: 2.1.4

 Attachments: 9022.txt, bisect.sh, results_cassandra_2.1.3.txt, 
 results_cassandra_2.1_branch.txt


 I try to add a node in my cluster and doing some cleanup deleted all my data 
 on a node. This makes the cluster totally broken since all next read seem to 
 not be able to validate the data. Even a repair on the problematic node 
 doesn't fix the issue.  I've attached the bisect script used and the output 
 results of the procedure.
 Procedure to reproduce:
 {code}
 ccm stop  ccm remove
 ccm create -n 2 --install-dir=path/to/cassandra-2.1/branch demo
 ccm start
 ccm node1 stress -- write n=100 -schema replication\(factor=2\) -rate 
 threads=50
 ccm node1 nodetool status
 ccm add -i 127.0.0.3 -j 7400 node3 # no auto-boostrap
 ccm node3 start
 ccm node1 nodetool status
 ccm node3 repair
 ccm node3 nodetool status
 ccm node1 nodetool cleanup
 ccm node2 nodetool cleanup
 ccm node3 nodetool cleanup
 ccm node1 nodetool status
 ccm node1 repair
 ccm node1 stress -- read n=100 ## CRASH Data returned was not validated 
 ?!?
 {code}
 bisec script output:
 {code}
 $ git bisect start cassandra-2.1 cassandra-2.1.3
 $ git bisect run ~/dev/cstar/cleanup_issue/bisect.sh
 ...
 4b05b204acfa60ecad5672c7e6068eb47b21397a is the first bad commit
 commit 4b05b204acfa60ecad5672c7e6068eb47b21397a
 Author: Benedict Elliott Smith bened...@apache.org
 Date:   Wed Feb 11 15:49:43 2015 +
 Enforce SSTableReader.first/last
 
 patch by benedict; reviewed by yukim for CASSANDRA-8744
 :100644 100644 3f0463731e624cbe273dcb3951b2055fa5d9e1a2 
 b2f894eb22b9102d410f1eabeb3e11d26727fbd3 M  CHANGES.txt
 :04 04 51ac2a6cd39bd2377c2e1ed6693ef789ab65a26c 
 79fa2501f4155a64dca2bbdcc9e578008e4e425a M  src
 bisect run success
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-9022) Node Cleanup deletes all its data after a new node joined the cluster

2015-03-24 Thread Sylvain Lebresne (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377510#comment-14377510
 ] 

Sylvain Lebresne commented on CASSANDRA-9022:
-

+1, but I'm assuming the changes in {{SSTableReader}} are unrelated to this 
issue. If I'm wrong, then would you care explaining why they are related. 
Otherwise, can you not include them in that particular commit.

 Node Cleanup deletes all its data after a new node joined the cluster
 -

 Key: CASSANDRA-9022
 URL: https://issues.apache.org/jira/browse/CASSANDRA-9022
 Project: Cassandra
  Issue Type: Bug
Reporter: Alan Boudreault
Assignee: Benedict
Priority: Critical
 Fix For: 2.1.4

 Attachments: 9022.txt, bisect.sh, results_cassandra_2.1.3.txt, 
 results_cassandra_2.1_branch.txt


 I try to add a node in my cluster and doing some cleanup deleted all my data 
 on a node. This makes the cluster totally broken since all next read seem to 
 not be able to validate the data. Even a repair on the problematic node 
 doesn't fix the issue.  I've attached the bisect script used and the output 
 results of the procedure.
 Procedure to reproduce:
 {code}
 ccm stop  ccm remove
 ccm create -n 2 --install-dir=path/to/cassandra-2.1/branch demo
 ccm start
 ccm node1 stress -- write n=100 -schema replication\(factor=2\) -rate 
 threads=50
 ccm node1 nodetool status
 ccm add -i 127.0.0.3 -j 7400 node3 # no auto-boostrap
 ccm node3 start
 ccm node1 nodetool status
 ccm node3 repair
 ccm node3 nodetool status
 ccm node1 nodetool cleanup
 ccm node2 nodetool cleanup
 ccm node3 nodetool cleanup
 ccm node1 nodetool status
 ccm node1 repair
 ccm node1 stress -- read n=100 ## CRASH Data returned was not validated 
 ?!?
 {code}
 bisec script output:
 {code}
 $ git bisect start cassandra-2.1 cassandra-2.1.3
 $ git bisect run ~/dev/cstar/cleanup_issue/bisect.sh
 ...
 4b05b204acfa60ecad5672c7e6068eb47b21397a is the first bad commit
 commit 4b05b204acfa60ecad5672c7e6068eb47b21397a
 Author: Benedict Elliott Smith bened...@apache.org
 Date:   Wed Feb 11 15:49:43 2015 +
 Enforce SSTableReader.first/last
 
 patch by benedict; reviewed by yukim for CASSANDRA-8744
 :100644 100644 3f0463731e624cbe273dcb3951b2055fa5d9e1a2 
 b2f894eb22b9102d410f1eabeb3e11d26727fbd3 M  CHANGES.txt
 :04 04 51ac2a6cd39bd2377c2e1ed6693ef789ab65a26c 
 79fa2501f4155a64dca2bbdcc9e578008e4e425a M  src
 bisect run success
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-9022) Node Cleanup deletes all its data after a new node joined the cluster

2015-03-23 Thread Alan Boudreault (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376706#comment-14376706
 ] 

Alan Boudreault commented on CASSANDRA-9022:


Yep. This patch seems to fix the issue. Ran my test case twice and everything 
looks good. I will finish my dtest for this later or tomorrow morning. Thanks! 

 Node Cleanup deletes all its data after a new node joined the cluster
 -

 Key: CASSANDRA-9022
 URL: https://issues.apache.org/jira/browse/CASSANDRA-9022
 Project: Cassandra
  Issue Type: Bug
Reporter: Alan Boudreault
Assignee: Benedict
Priority: Critical
 Fix For: 2.1.4

 Attachments: 9022.txt, bisect.sh, results_cassandra_2.1.3.txt, 
 results_cassandra_2.1_branch.txt


 I try to add a node in my cluster and doing some cleanup deleted all my data 
 on a node. This makes the cluster totally broken since all next read seem to 
 not be able to validate the data. Even a repair on the problematic node 
 doesn't fix the issue.  I've attached the bisect script used and the output 
 results of the procedure.
 Procedure to reproduce:
 {code}
 ccm stop  ccm remove
 ccm create -n 2 --install-dir=path/to/cassandra-2.1/branch demo
 ccm start
 ccm node1 stress -- write n=100 -schema replication\(factor=2\) -rate 
 threads=50
 ccm node1 nodetool status
 ccm add -i 127.0.0.3 -j 7400 node3 # no auto-boostrap
 ccm node3 start
 ccm node1 nodetool status
 ccm node3 repair
 ccm node3 nodetool status
 ccm node1 nodetool cleanup
 ccm node2 nodetool cleanup
 ccm node3 nodetool cleanup
 ccm node1 nodetool status
 ccm node1 repair
 ccm node1 stress -- read n=100 ## CRASH Data returned was not validated 
 ?!?
 {code}
 bisec script output:
 {code}
 $ git bisect start cassandra-2.1 cassandra-2.1.3
 $ git bisect run ~/dev/cstar/cleanup_issue/bisect.sh
 ...
 4b05b204acfa60ecad5672c7e6068eb47b21397a is the first bad commit
 commit 4b05b204acfa60ecad5672c7e6068eb47b21397a
 Author: Benedict Elliott Smith bened...@apache.org
 Date:   Wed Feb 11 15:49:43 2015 +
 Enforce SSTableReader.first/last
 
 patch by benedict; reviewed by yukim for CASSANDRA-8744
 :100644 100644 3f0463731e624cbe273dcb3951b2055fa5d9e1a2 
 b2f894eb22b9102d410f1eabeb3e11d26727fbd3 M  CHANGES.txt
 :04 04 51ac2a6cd39bd2377c2e1ed6693ef789ab65a26c 
 79fa2501f4155a64dca2bbdcc9e578008e4e425a M  src
 bisect run success
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-9022) Node Cleanup deletes all its data after a new node joined the cluster

2015-03-23 Thread Benedict (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376883#comment-14376883
 ] 

Benedict commented on CASSANDRA-9022:
-

No. This bug never saw the light of day.

 Node Cleanup deletes all its data after a new node joined the cluster
 -

 Key: CASSANDRA-9022
 URL: https://issues.apache.org/jira/browse/CASSANDRA-9022
 Project: Cassandra
  Issue Type: Bug
Reporter: Alan Boudreault
Assignee: Benedict
Priority: Critical
 Fix For: 2.1.4

 Attachments: 9022.txt, bisect.sh, results_cassandra_2.1.3.txt, 
 results_cassandra_2.1_branch.txt


 I try to add a node in my cluster and doing some cleanup deleted all my data 
 on a node. This makes the cluster totally broken since all next read seem to 
 not be able to validate the data. Even a repair on the problematic node 
 doesn't fix the issue.  I've attached the bisect script used and the output 
 results of the procedure.
 Procedure to reproduce:
 {code}
 ccm stop  ccm remove
 ccm create -n 2 --install-dir=path/to/cassandra-2.1/branch demo
 ccm start
 ccm node1 stress -- write n=100 -schema replication\(factor=2\) -rate 
 threads=50
 ccm node1 nodetool status
 ccm add -i 127.0.0.3 -j 7400 node3 # no auto-boostrap
 ccm node3 start
 ccm node1 nodetool status
 ccm node3 repair
 ccm node3 nodetool status
 ccm node1 nodetool cleanup
 ccm node2 nodetool cleanup
 ccm node3 nodetool cleanup
 ccm node1 nodetool status
 ccm node1 repair
 ccm node1 stress -- read n=100 ## CRASH Data returned was not validated 
 ?!?
 {code}
 bisec script output:
 {code}
 $ git bisect start cassandra-2.1 cassandra-2.1.3
 $ git bisect run ~/dev/cstar/cleanup_issue/bisect.sh
 ...
 4b05b204acfa60ecad5672c7e6068eb47b21397a is the first bad commit
 commit 4b05b204acfa60ecad5672c7e6068eb47b21397a
 Author: Benedict Elliott Smith bened...@apache.org
 Date:   Wed Feb 11 15:49:43 2015 +
 Enforce SSTableReader.first/last
 
 patch by benedict; reviewed by yukim for CASSANDRA-8744
 :100644 100644 3f0463731e624cbe273dcb3951b2055fa5d9e1a2 
 b2f894eb22b9102d410f1eabeb3e11d26727fbd3 M  CHANGES.txt
 :04 04 51ac2a6cd39bd2377c2e1ed6693ef789ab65a26c 
 79fa2501f4155a64dca2bbdcc9e578008e4e425a M  src
 bisect run success
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-9022) Node Cleanup deletes all its data after a new node joined the cluster

2015-03-23 Thread Nick Bailey (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376881#comment-14376881
 ] 

Nick Bailey commented on CASSANDRA-9022:


So does this mean cleanup should never been run on a 2.1.0-2.1.3 cluster if 
nodes have been added to the cluster?

 Node Cleanup deletes all its data after a new node joined the cluster
 -

 Key: CASSANDRA-9022
 URL: https://issues.apache.org/jira/browse/CASSANDRA-9022
 Project: Cassandra
  Issue Type: Bug
Reporter: Alan Boudreault
Assignee: Benedict
Priority: Critical
 Fix For: 2.1.4

 Attachments: 9022.txt, bisect.sh, results_cassandra_2.1.3.txt, 
 results_cassandra_2.1_branch.txt


 I try to add a node in my cluster and doing some cleanup deleted all my data 
 on a node. This makes the cluster totally broken since all next read seem to 
 not be able to validate the data. Even a repair on the problematic node 
 doesn't fix the issue.  I've attached the bisect script used and the output 
 results of the procedure.
 Procedure to reproduce:
 {code}
 ccm stop  ccm remove
 ccm create -n 2 --install-dir=path/to/cassandra-2.1/branch demo
 ccm start
 ccm node1 stress -- write n=100 -schema replication\(factor=2\) -rate 
 threads=50
 ccm node1 nodetool status
 ccm add -i 127.0.0.3 -j 7400 node3 # no auto-boostrap
 ccm node3 start
 ccm node1 nodetool status
 ccm node3 repair
 ccm node3 nodetool status
 ccm node1 nodetool cleanup
 ccm node2 nodetool cleanup
 ccm node3 nodetool cleanup
 ccm node1 nodetool status
 ccm node1 repair
 ccm node1 stress -- read n=100 ## CRASH Data returned was not validated 
 ?!?
 {code}
 bisec script output:
 {code}
 $ git bisect start cassandra-2.1 cassandra-2.1.3
 $ git bisect run ~/dev/cstar/cleanup_issue/bisect.sh
 ...
 4b05b204acfa60ecad5672c7e6068eb47b21397a is the first bad commit
 commit 4b05b204acfa60ecad5672c7e6068eb47b21397a
 Author: Benedict Elliott Smith bened...@apache.org
 Date:   Wed Feb 11 15:49:43 2015 +
 Enforce SSTableReader.first/last
 
 patch by benedict; reviewed by yukim for CASSANDRA-8744
 :100644 100644 3f0463731e624cbe273dcb3951b2055fa5d9e1a2 
 b2f894eb22b9102d410f1eabeb3e11d26727fbd3 M  CHANGES.txt
 :04 04 51ac2a6cd39bd2377c2e1ed6693ef789ab65a26c 
 79fa2501f4155a64dca2bbdcc9e578008e4e425a M  src
 bisect run success
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)