[jira] [Commented] (CASSANDRASC-75) Shaded Sidecar client should shade Jackson completely to avoid incompatibility issues
[ https://issues.apache.org/jira/browse/CASSANDRASC-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769291#comment-17769291 ] ASF subversion and git services commented on CASSANDRASC-75: Commit 4408b9d3ec32c9243484258135017ce9c4804b2a in cassandra-sidecar's branch refs/heads/trunk from Doug Rohrer [ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=4408b9d ] CASSANDRASC-75: Shade Jackson completely to prevent incompatibility issues Before, we we shading almost all of Jackson but left the annotations unshaded/relocated. However, this causes problems in older Spark environments where the annotations in the class path don’t quite match what the other shaded parts of Jackson expect (missing classes being the most serious issue). This can cause the library to fail on certain Spark versions. This commit removes the exclusion of the annotations project from shading in the vertx-client-shaded project. - Additionally, tweaked CircleCI settings so that we don't run out of virtual memory and see the OS OOM kill the test exexutor. Patch by Doug Rohrer; Reviewed by Dinesh Joshi, Francisco Guerrero, Yifan Cai for CASSANDRASC-75 > Shaded Sidecar client should shade Jackson completely to avoid > incompatibility issues > - > > Key: CASSANDRASC-75 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-75 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Fix For: 1.0 > > > Before, we were shading almost all of Jackson but left the annotations > unshaded/relocated. However, this causes problems in older Spark environments > where the annotations in the class path don’t quite match what the other > shaded parts of Jackson expect (missing classes being the most serious > issue). This can cause the library to fail on certain Spark versions. > > We should shade +all+ of Jackson in the shaded client to prevent these issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-75) Shaded Sidecar client should shade Jackson completely to avoid incompatibility issues
[ https://issues.apache.org/jira/browse/CASSANDRASC-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769288#comment-17769288 ] Yifan Cai commented on CASSANDRASC-75: -- +1 on the patch! Thanks for adding the comment at the line that shades dependency. > Shaded Sidecar client should shade Jackson completely to avoid > incompatibility issues > - > > Key: CASSANDRASC-75 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-75 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Fix For: 1.0 > > > Before, we were shading almost all of Jackson but left the annotations > unshaded/relocated. However, this causes problems in older Spark environments > where the annotations in the class path don’t quite match what the other > shaded parts of Jackson expect (missing classes being the most serious > issue). This can cause the library to fail on certain Spark versions. > > We should shade +all+ of Jackson in the shaded client to prevent these issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-75) Shaded Sidecar client should shade Jackson completely to avoid incompatibility issues
[ https://issues.apache.org/jira/browse/CASSANDRASC-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768822#comment-17768822 ] Francisco Guerrero commented on CASSANDRASC-75: --- +1, thanks for the patch! > Shaded Sidecar client should shade Jackson completely to avoid > incompatibility issues > - > > Key: CASSANDRASC-75 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-75 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Fix For: 1.0 > > > Before, we were shading almost all of Jackson but left the annotations > unshaded/relocated. However, this causes problems in older Spark environments > where the annotations in the class path don’t quite match what the other > shaded parts of Jackson expect (missing classes being the most serious > issue). This can cause the library to fail on certain Spark versions. > > We should shade +all+ of Jackson in the shaded client to prevent these issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-75) Shaded Sidecar client should shade Jackson completely to avoid incompatibility issues
[ https://issues.apache.org/jira/browse/CASSANDRASC-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768137#comment-17768137 ] Dinesh Joshi commented on CASSANDRASC-75: - +1, thanks for the patch. > Shaded Sidecar client should shade Jackson completely to avoid > incompatibility issues > - > > Key: CASSANDRASC-75 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-75 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Fix For: 1.0 > > > Before, we we shading almost all of Jackson but left the annotations > unshaded/relocated. However, this causes problems in older Spark environments > where the annotations in the class path don’t quite match what the other > shaded parts of Jackson expect (missing classes being the most serious > issue). This can cause the library to fail on certain Spark versions. > > We should shade +all+ of Jackson in the shaded client to prevent these issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-75) Shaded Sidecar client should shade Jackson completely to avoid incompatibility issues
[ https://issues.apache.org/jira/browse/CASSANDRASC-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768135#comment-17768135 ] Doug Rohrer commented on CASSANDRASC-75: Clean CI (after a few flakes dealing with, I think, OOMs but it's hard to tell from the logs of previous runs) [https://app.circleci.com/pipelines/github/JeetKunDoug/cassandra-sidecar/70/workflows/e335963c-7423-4016-aa54-403b09faf800] > Shaded Sidecar client should shade Jackson completely to avoid > incompatibility issues > - > > Key: CASSANDRASC-75 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-75 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Fix For: 1.0 > > > Before, we we shading almost all of Jackson but left the annotations > unshaded/relocated. However, this causes problems in older Spark environments > where the annotations in the class path don’t quite match what the other > shaded parts of Jackson expect (missing classes being the most serious > issue). This can cause the library to fail on certain Spark versions. > > We should shade +all+ of Jackson in the shaded client to prevent these issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
