[jira] [Commented] (CASSANDRASC-83) Require gossip to be enabled for ring and token ranges mapping endpoints
[ https://issues.apache.org/jira/browse/CASSANDRASC-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790637#comment-17790637 ] ASF subversion and git services commented on CASSANDRASC-83: Commit c1a6225dac62db94fd3faee92513e84ba3b9b3b7 in cassandra-sidecar's branch refs/heads/trunk from Francisco Guerrero [ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=c1a6225 ] CASSANDRASC-83: Require gossip to be enabled for ring and token ranges mapping endpoints The ring and token ranges mapping endpoints leverage JMX to produce the payload. Ring and token ranges mapping information is derived from gossip information available to the Cassandra instance. If gossip has been disabled, the information might provide an inconsistent view of the cluster which is undesirable. We should instead return a 503 (Service Unavailable) to the client whenever the client tries to access these endpoints and gossip has been disabled. In this commit, we ensure the endpoints return a 503 (Service Unavailable) when gossip is disabled. Patch by Francisco Guerrero; Reviewed by Dinesh Joshi, Josh McKenzie, Yifan Cai for CASSANDRASC-83 > Require gossip to be enabled for ring and token ranges mapping endpoints > > > Key: CASSANDRASC-83 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-83 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > The ring and token ranges mapping endpoints leverage JMX to produce the > payload. Ring and token ranges mapping information is derived from gossip > information available to the Cassandra instance. If gossip has been disabled, > the information might provide an inconsistent view of the cluster which is > undesirable. We should instead return a 503 (Service Unavailable) to the > client whenever the client tries to access these endpoints and gossip has > been disabled. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-83) Require gossip to be enabled for ring and token ranges mapping endpoints
[ https://issues.apache.org/jira/browse/CASSANDRASC-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790636#comment-17790636 ] Yifan Cai commented on CASSANDRASC-83: -- +1 on the patch > Require gossip to be enabled for ring and token ranges mapping endpoints > > > Key: CASSANDRASC-83 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-83 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > The ring and token ranges mapping endpoints leverage JMX to produce the > payload. Ring and token ranges mapping information is derived from gossip > information available to the Cassandra instance. If gossip has been disabled, > the information might provide an inconsistent view of the cluster which is > undesirable. We should instead return a 503 (Service Unavailable) to the > client whenever the client tries to access these endpoints and gossip has > been disabled. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-83) Require gossip to be enabled for ring and token ranges mapping endpoints
[ https://issues.apache.org/jira/browse/CASSANDRASC-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786086#comment-17786086 ] Josh McKenzie commented on CASSANDRASC-83: -- +1 here as well - very clean! > Require gossip to be enabled for ring and token ranges mapping endpoints > > > Key: CASSANDRASC-83 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-83 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > The ring and token ranges mapping endpoints leverage JMX to produce the > payload. Ring and token ranges mapping information is derived from gossip > information available to the Cassandra instance. If gossip has been disabled, > the information might provide an inconsistent view of the cluster which is > undesirable. We should instead return a 503 (Service Unavailable) to the > client whenever the client tries to access these endpoints and gossip has > been disabled. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-83) Require gossip to be enabled for ring and token ranges mapping endpoints
[ https://issues.apache.org/jira/browse/CASSANDRASC-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784247#comment-17784247 ] Dinesh Joshi commented on CASSANDRASC-83: - +1, thanks for the patch! > Require gossip to be enabled for ring and token ranges mapping endpoints > > > Key: CASSANDRASC-83 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-83 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > The ring and token ranges mapping endpoints leverage JMX to produce the > payload. Ring and token ranges mapping information is derived from gossip > information available to the Cassandra instance. If gossip has been disabled, > the information might provide an inconsistent view of the cluster which is > undesirable. We should instead return a 503 (Service Unavailable) to the > client whenever the client tries to access these endpoints and gossip has > been disabled. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-83) Require gossip to be enabled for ring and token ranges mapping endpoints
[ https://issues.apache.org/jira/browse/CASSANDRASC-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784148#comment-17784148 ] Francisco Guerrero commented on CASSANDRASC-83: --- Latest CI: https://app.circleci.com/pipelines/github/frankgh/cassandra-sidecar/367 > Require gossip to be enabled for ring and token ranges mapping endpoints > > > Key: CASSANDRASC-83 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-83 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > The ring and token ranges mapping endpoints leverage JMX to produce the > payload. Ring and token ranges mapping information is derived from gossip > information available to the Cassandra instance. If gossip has been disabled, > the information might provide an inconsistent view of the cluster which is > undesirable. We should instead return a 503 (Service Unavailable) to the > client whenever the client tries to access these endpoints and gossip has > been disabled. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-83) Require gossip to be enabled for ring and token ranges mapping endpoints
[ https://issues.apache.org/jira/browse/CASSANDRASC-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783822#comment-17783822 ] Francisco Guerrero commented on CASSANDRASC-83: --- CI: https://app.circleci.com/pipelines/github/frankgh/cassandra-sidecar/366 > Require gossip to be enabled for ring and token ranges mapping endpoints > > > Key: CASSANDRASC-83 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-83 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > The ring and token ranges mapping endpoints leverage JMX to produce the > payload. Ring and token ranges mapping information is derived from gossip > information available to the Cassandra instance. If gossip has been disabled, > the information might provide an inconsistent view of the cluster which is > undesirable. We should instead return a 503 (Service Unavailable) to the > client whenever the client tries to access these endpoints and gossip has > been disabled. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
