[jira] [Updated] (CASSANDRA-10246) Named values don't work with batches
[ https://issues.apache.org/jira/browse/CASSANDRA-10246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne updated CASSANDRA-10246: - Issue Type: Sub-task (was: Bug) Parent: CASSANDRA-9362 > Named values don't work with batches > > > Key: CASSANDRA-10246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10246 > Project: Cassandra > Issue Type: Sub-task > Components: CQL >Reporter: Michael Penick >Assignee: Ariel Weisberg > Labels: client-impacting > Fix For: 3.x > > > This is broken at the protocol-level and in the implementation. > At the protocol-level the {{}} component of the batch comes after the > queries. That means the protocol parser would need to read ahead (and back > track) to determine the values encoding and correctly read the values from > the query entries. Also, a batch-level setting for named values forces all > queries to use the same encoding. Should batches force a single, homogenous > query value encoding? (This is confusing) > In the implementation, values are indiscriminately read using > {{CBUtil.readValueList()}}, and the batch flags are never checked (for > {{(Flag.NAMES_FOR_VALUES}}) to see if {{CBUtil.readNameAndValueList()}} > should be called instead: > https://github.com/apache/cassandra/blob/cassandra-2.1/src/java/org/apache/cassandra/transport/messages/BatchMessage.java#L64 > Proposed solution: CASSANDRA-10247 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10246) Named values don't work with batches
[ https://issues.apache.org/jira/browse/CASSANDRA-10246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-10246: -- Fix Version/s: (was: 3.0.x) 3.1 > Named values don't work with batches > > > Key: CASSANDRA-10246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10246 > Project: Cassandra > Issue Type: Bug > Components: API >Reporter: Michael Penick > Labels: client-impacting > Fix For: 2.1.x, 2.2.x, 3.1 > > > This is broken at the protocol-level and in the implementation. > At the protocol-level the {{}} component of the batch comes after the > queries. That means the protocol parser would need to read ahead (and back > track) to determine the values encoding and correctly read the values from > the query entries. Also, a batch-level setting for named values forces all > queries to use the same encoding. Should batches force a single, homogenous > query value encoding? (This is confusing) > In the implementation, values are indiscriminately read using > {{CBUtil.readValueList()}}, and the batch flags are never checked (for > {{(Flag.NAMES_FOR_VALUES}}) to see if {{CBUtil.readNameAndValueList()}} > should be called instead: > https://github.com/apache/cassandra/blob/cassandra-2.1/src/java/org/apache/cassandra/transport/messages/BatchMessage.java#L64 > Proposed solution: CASSANDRA-10247 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10246) Named values don't work with batches
[ https://issues.apache.org/jira/browse/CASSANDRA-10246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joshua McKenzie updated CASSANDRA-10246: Fix Version/s: (was: 3.0.0 rc2) 3.0.x 2.2.x 2.1.x > Named values don't work with batches > > > Key: CASSANDRA-10246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10246 > Project: Cassandra > Issue Type: Bug > Components: API >Reporter: Michael Penick > Labels: client-impacting > Fix For: 2.1.x, 2.2.x, 3.0.x > > > This is broken at the protocol-level and in the implementation. > At the protocol-level the {{}} component of the batch comes after the > queries. That means the protocol parser would need to read ahead (and back > track) to determine the values encoding and correctly read the values from > the query entries. Also, a batch-level setting for named values forces all > queries to use the same encoding. Should batches force a single, homogenous > query value encoding? (This is confusing) > In the implementation, values are indiscriminately read using > {{CBUtil.readValueList()}}, and the batch flags are never checked (for > {{(Flag.NAMES_FOR_VALUES}}) to see if {{CBUtil.readNameAndValueList()}} > should be called instead: > https://github.com/apache/cassandra/blob/cassandra-2.1/src/java/org/apache/cassandra/transport/messages/BatchMessage.java#L64 > Proposed solution: CASSANDRA-10247 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10246) Named values don't work with batches
[ https://issues.apache.org/jira/browse/CASSANDRA-10246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Thompson updated CASSANDRA-10246: Reproduced In: 2.2.1, 2.1.9 (was: 2.1.9, 2.2.1) Fix Version/s: 3.0.x 2.2.x 2.1.x > Named values don't work with batches > > > Key: CASSANDRA-10246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10246 > Project: Cassandra > Issue Type: Bug > Components: API >Reporter: Michael Penick > Labels: client-impacting > Fix For: 2.1.x, 2.2.x, 3.0.x > > > This is broken at the protocol-level and in the implementation. > At the protocol-level the {{}} component of the batch comes after the > queries. That means the protocol parser would need to read ahead (and back > track) to determine the values encoding and correctly read the values from > the query entries. Also, a batch-level setting for named values forces all > queries to use the same encoding. Should batches force a single, homogenous > query value encoding? (This is confusing) > In the implementation, values are indiscriminately read using > {{CBUtil.readValueList()}}, and the batch flags are never checked (for > {{(Flag.NAMES_FOR_VALUES}}) to see if {{CBUtil.readNameAndValueList()}} > should be called instead: > https://github.com/apache/cassandra/blob/cassandra-2.1/src/java/org/apache/cassandra/transport/messages/BatchMessage.java#L64 > Proposed solution: CASSANDRA-10247 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10246) Named values don't work with batches
[ https://issues.apache.org/jira/browse/CASSANDRA-10246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Penick updated CASSANDRA-10246: --- Summary: Named values don't work with batches (was: Names values don't work with batches) > Named values don't work with batches > > > Key: CASSANDRA-10246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10246 > Project: Cassandra > Issue Type: Bug > Components: API >Reporter: Michael Penick > Labels: client-impacting > > This is broken at the protocol-level and in the implementation. > At the protocol-level the {{}} component of the batch comes after the > queries. That means the protocol parser would need to read ahead (and back > track) to determine the values encoding and correctly read the values from > the query entries. Also, a batch-level setting for named values forces all > queries to use the same encoding. Should batches force a single, homogenous > query value encoding? (This is confusing) > In the implementation, values are indiscriminately read using > {{CBUtil.readValueList()}}, and the batch flags are never checked (for > {{(Flag.NAMES_FOR_VALUES}}) to see if {{CBUtil.readNameAndValueList()}} > should be called instead: > https://github.com/apache/cassandra/blob/cassandra-2.1/src/java/org/apache/cassandra/transport/messages/BatchMessage.java#L64 > Proposed solution: CASSANDRA-10247 -- This message was sent by Atlassian JIRA (v6.3.4#6332)