[jira] [Updated] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DOAN DuyHai updated CASSANDRA-11183: Attachment: patch_SASI_for_Static.txt Attached is the patch for this new feature. I also added a test in {{SASIIndexTest}} to ensure that conditions on static columns are working in combination with non static columns ... > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Attachments: patch_SASI_for_Static.txt > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DOAN DuyHai updated CASSANDRA-11183: Fix Version/s: 3.6 Status: Patch Available (was: Open) > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Fix For: 3.6 > > Attachments: patch_SASI_for_Static.txt > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DOAN DuyHai updated CASSANDRA-11183: Attachment: (was: patch_SASI_for_Static.txt) > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Fix For: 3.6 > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DOAN DuyHai updated CASSANDRA-11183: Attachment: patch_SASI_for_Static_AFTER_Review.txt Ok, after [~xedin] remarks, I have updated the patch. Now *normal* and *static* rows are passed together to {{operation.satisfiedBy(Unfiltered, Row, allowMissings)}} and {{operation.localSatisfiedBy(Unfiltered, Row, allowMissings)}} However, I did not modify the method {{ColumnIndex.getValueOf(column, row, nowInSecs)}} because it is used at many places where we may not have access to static row. Instead I added a new method {{ColumnIndex.getValueOfStatic(column, staticRow, nowInSecs)}} This method will be called by * {{ColumnIndex.index(DecoratedKey, Row)}} * {{operation.localSatisfiedBy(Unfiltered, Row, allowMissings)}} For test coverage, in addition of existing {{SASIIndexTest.testStaticIndex}}, I also added {{OperationTest.testSatisfiedByWithStatic}} which combines # static AND non static conditions # static OR non static conditions # (static OR static conditions) AND static conditions All tests are green > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Fix For: 3.6 > > Attachments: patch_SASI_for_Static_AFTER_Review.txt > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Yaskevich updated CASSANDRA-11183: Attachment: CASSANDRA-11183-statics.patch [~doanduyhai] The latest patch is not applicable on the trunk, so you will have to rebase. I'm also attaching changes (CASSANDRA-11183-statics.patch) for Operation, ColumnIndex.getValueOf and SASIIndexBuilder that I think are less intrusive comparing to separating getValue into getValueOf and getStaticValueOf which has to check column kind anyway. > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Fix For: 3.6 > > Attachments: CASSANDRA-11183-statics.patch, > patch_SASI_for_Static_AFTER_Review.txt > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Yaskevich updated CASSANDRA-11183: Component/s: (was: CQL) sasi > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: sasi >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Fix For: 3.6 > > Attachments: CASSANDRA-11183-statics.patch, > patch_SASI_for_Static_AFTER_Review.txt > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Yaskevich updated CASSANDRA-11183: Reviewer: Pavel Yaskevich > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: sasi >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Fix For: 3.6 > > Attachments: CASSANDRA-11183-statics.patch, > patch_SASI_for_Static_AFTER_Review.txt > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DOAN DuyHai updated CASSANDRA-11183: Attachment: (was: patch_SASI_for_Static_AFTER_Review.txt) > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: sasi >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Fix For: 3.6 > > Attachments: CASSANDRA-11183-statics.patch > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DOAN DuyHai updated CASSANDRA-11183: Attachment: patch_SASI_for_Static_FINAL_Review.txt Ok, I rebased from trunk and integrate your changes [~xedin]. I kept the 2 unit tests for the sake of code coverage > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: sasi >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Fix For: 3.6 > > Attachments: CASSANDRA-11183-statics.patch, > patch_SASI_for_Static_FINAL_Review.txt > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Yaskevich updated CASSANDRA-11183: Resolution: Fixed Status: Resolved (was: Patch Available) Merged. Thanks again, [~doanduyhai]! > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: sasi >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Fix For: 3.6 > > Attachments: CASSANDRA-11183-statics.patch, > patch_SASI_for_Static_FINAL_Review.txt > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)