[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-11671: --- Fix Version/s: (was: 4.x) 4.1 Source Control Link: https://github.com/apache/cassandra/commit/fbf101072a65a240eb4831583aeb72e97078737f Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed into trunk at fbf101072a65a240eb4831583aeb72e97078737f > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Coordination >Reporter: Sam Tunnicliffe >Assignee: Artsiom Yudovin >Priority: Low > Labels: pull-request-available > Fix For: 4.1 > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-11671: --- Status: Ready to Commit (was: Review In Progress) > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Coordination >Reporter: Sam Tunnicliffe >Assignee: Artsiom Yudovin >Priority: Low > Labels: pull-request-available > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-11671: --- Reviewers: Benjamin Lerer, Brandon Williams (was: Brandon Williams) > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Coordination >Reporter: Sam Tunnicliffe >Assignee: Artsiom Yudovin >Priority: Low > Labels: pull-request-available > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-11671: - Fix Version/s: (was: 3.11.x) > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Coordination >Reporter: Sam Tunnicliffe >Assignee: Artsiom Yudovin >Priority: Low > Labels: pull-request-available > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-11671: - Fix Version/s: 3.11.x > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Coordination >Reporter: Sam Tunnicliffe >Priority: Low > Labels: pull-request-available > Fix For: 3.11.x, 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-11671: - Reviewers: Brandon Williams (was: Jason Brown) Status: Review In Progress (was: Patch Available) > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Coordination >Reporter: Sam Tunnicliffe >Priority: Low > Labels: pull-request-available > Fix For: 3.11.x, 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Brown updated CASSANDRA-11671: Reviewer: Jason Brown > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Coordination >Reporter: Sam Tunnicliffe >Priority: Minor > Labels: pull-request-available > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artsiom Yudovin updated CASSANDRA-11671: Status: Patch Available (was: Awaiting Feedback) > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Coordination >Reporter: Sam Tunnicliffe >Priority: Minor > Labels: pull-request-available > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artsiom Yudovin updated CASSANDRA-11671: Status: Ready to Commit (was: Patch Available) > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Coordination >Reporter: Sam Tunnicliffe >Priority: Minor > Labels: pull-request-available > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artsiom Yudovin updated CASSANDRA-11671: Status: Patch Available (was: Open) this [pull request|https://github.com/apache/cassandra/pull/251] > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Coordination >Reporter: Sam Tunnicliffe >Priority: Minor > Labels: pull-request-available > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artsiom Yudovin updated CASSANDRA-11671: Status: Awaiting Feedback (was: In Progress) > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Coordination >Reporter: Sam Tunnicliffe >Priority: Minor > Labels: pull-request-available > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artsiom Yudovin updated CASSANDRA-11671: Status: In Progress (was: Ready to Commit) > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Coordination >Reporter: Sam Tunnicliffe >Priority: Minor > Labels: pull-request-available > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11671) Remove check on gossip status from DynamicEndpointSnitch::updateScores
[ https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-11671: --- Labels: pull-request-available (was: ) > Remove check on gossip status from DynamicEndpointSnitch::updateScores > -- > > Key: CASSANDRA-11671 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11671 > Project: Cassandra > Issue Type: Improvement > Components: Coordination >Reporter: Sam Tunnicliffe >Priority: Minor > Labels: pull-request-available > Fix For: 4.x > > > It seems that historically there were initialization ordering issues which > affected DES and StorageService (CASSANDRA-1756) and so a condition was added > to DES::updateScores() to ensure that SS had finished setup. In fact, the > check was actually testing whether gossip was active or not. CASSANDRA-10134 > preserved this behaviour, but it seems likely that the check can be removed > from DES completely now. If not, it can at least be switched to use > SS::isInitialized() which post CASSANDRA-10134 actually reports what it's > name suggests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org