[jira] [Updated] (CASSANDRA-11868) unused imports and generic types
[ https://issues.apache.org/jira/browse/CASSANDRA-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] C. Scott Andreas updated CASSANDRA-11868: - Component/s: Core > unused imports and generic types > > > Key: CASSANDRA-11868 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11868 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Major > Fix For: 4.x > > > I was going through Cassandra source and for busy work I started looking at > all the .java files eclipse flags as warning. They are broken roughly into a > few cases. > 1) unused imports > 2) raw types missing <> > 3) case statements without defaults > 4) @resource annotation > My IDE claims item 4 is not needed (it looks like we have done this to > signify methods that return objects that need to be closed) I can guess 4 was > done intentionally and short of making out own annotation I will ignore these > for now. > I would like to tackle this busy work before I get started. I have some > questions: > 1) Do this only on trunk? or multiple branches > 2) should I tackle 1,2,3 in separate branches/patches -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11868) unused imports and generic types
[ https://issues.apache.org/jira/browse/CASSANDRA-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Petrov updated CASSANDRA-11868: Reviewer: (was: Alex Petrov) > unused imports and generic types > > > Key: CASSANDRA-11868 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11868 > Project: Cassandra > Issue Type: Improvement >Reporter: Edward Capriolo >Assignee: Edward Capriolo > Fix For: 3.x > > > I was going through Cassandra source and for busy work I started looking at > all the .java files eclipse flags as warning. They are broken roughly into a > few cases. > 1) unused imports > 2) raw types missing <> > 3) case statements without defaults > 4) @resource annotation > My IDE claims item 4 is not needed (it looks like we have done this to > signify methods that return objects that need to be closed) I can guess 4 was > done intentionally and short of making out own annotation I will ignore these > for now. > I would like to tackle this busy work before I get started. I have some > questions: > 1) Do this only on trunk? or multiple branches > 2) should I tackle 1,2,3 in separate branches/patches -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11868) unused imports and generic types
[ https://issues.apache.org/jira/browse/CASSANDRA-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-11868: --- Status: Open (was: Patch Available) > unused imports and generic types > > > Key: CASSANDRA-11868 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11868 > Project: Cassandra > Issue Type: Improvement >Reporter: Edward Capriolo >Assignee: Edward Capriolo > Fix For: 3.x > > > I was going through Cassandra source and for busy work I started looking at > all the .java files eclipse flags as warning. They are broken roughly into a > few cases. > 1) unused imports > 2) raw types missing <> > 3) case statements without defaults > 4) @resource annotation > My IDE claims item 4 is not needed (it looks like we have done this to > signify methods that return objects that need to be closed) I can guess 4 was > done intentionally and short of making out own annotation I will ignore these > for now. > I would like to tackle this busy work before I get started. I have some > questions: > 1) Do this only on trunk? or multiple branches > 2) should I tackle 1,2,3 in separate branches/patches -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11868) unused imports and generic types
[ https://issues.apache.org/jira/browse/CASSANDRA-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-11868: -- Fix Version/s: (was: 3.8) 3.x > unused imports and generic types > > > Key: CASSANDRA-11868 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11868 > Project: Cassandra > Issue Type: Improvement >Reporter: Edward Capriolo >Assignee: Edward Capriolo > Fix For: 3.x > > > I was going through Cassandra source and for busy work I started looking at > all the .java files eclipse flags as warning. They are broken roughly into a > few cases. > 1) unused imports > 2) raw types missing <> > 3) case statements without defaults > 4) @resource annotation > My IDE claims item 4 is not needed (it looks like we have done this to > signify methods that return objects that need to be closed) I can guess 4 was > done intentionally and short of making out own annotation I will ignore these > for now. > I would like to tackle this busy work before I get started. I have some > questions: > 1) Do this only on trunk? or multiple branches > 2) should I tackle 1,2,3 in separate branches/patches -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11868) unused imports and generic types
[ https://issues.apache.org/jira/browse/CASSANDRA-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joshua McKenzie updated CASSANDRA-11868: Reviewer: Alex Petrov > unused imports and generic types > > > Key: CASSANDRA-11868 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11868 > Project: Cassandra > Issue Type: Improvement >Reporter: Edward Capriolo >Assignee: Edward Capriolo > Fix For: 3.8 > > > I was going through Cassandra source and for busy work I started looking at > all the .java files eclipse flags as warning. They are broken roughly into a > few cases. > 1) unused imports > 2) raw types missing <> > 3) case statements without defaults > 4) @resource annotation > My IDE claims item 4 is not needed (it looks like we have done this to > signify methods that return objects that need to be closed) I can guess 4 was > done intentionally and short of making out own annotation I will ignore these > for now. > I would like to tackle this busy work before I get started. I have some > questions: > 1) Do this only on trunk? or multiple branches > 2) should I tackle 1,2,3 in separate branches/patches -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11868) unused imports and generic types
[ https://issues.apache.org/jira/browse/CASSANDRA-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Capriolo updated CASSANDRA-11868: Fix Version/s: 3.8 Status: Patch Available (was: Open) > unused imports and generic types > > > Key: CASSANDRA-11868 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11868 > Project: Cassandra > Issue Type: Improvement >Reporter: Edward Capriolo >Assignee: Edward Capriolo > Fix For: 3.8 > > > I was going through Cassandra source and for busy work I started looking at > all the .java files eclipse flags as warning. They are broken roughly into a > few cases. > 1) unused imports > 2) raw types missing <> > 3) case statements without defaults > 4) @resource annotation > My IDE claims item 4 is not needed (it looks like we have done this to > signify methods that return objects that need to be closed) I can guess 4 was > done intentionally and short of making out own annotation I will ignore these > for now. > I would like to tackle this busy work before I get started. I have some > questions: > 1) Do this only on trunk? or multiple branches > 2) should I tackle 1,2,3 in separate branches/patches -- This message was sent by Atlassian JIRA (v6.3.4#6332)