[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mck updated CASSANDRA-12835:
Resolution: Fixed
Fix Version/s: (was: 3.11.x)
(was: 4.x)
4.0
3.11.0
Reproduced In: (was: )
Status: Resolved (was: Ready to Commit)
> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
> Issue Type: Bug
>Reporter: Hannu Kröger
>Assignee: mck
>Priority: Critical
> Labels: tracing
> Fix For: 3.11.0, 4.0
>
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is
> QueryMessage and the code in
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
> is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder =
> ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be
> {{state.createTracingSession(getCustomPayload());}}. At least that fixes the
> problem for me.
> This also raises the question whether some other parts of the code should
> pass the custom payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:public void createTracingSession()
> 82:createTracingSession(Collections.EMPTY_MAP);
> 85:public void createTracingSession(Map customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:state.createTracingSession();
> {code}
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot
> be fixed by the tracing plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mck updated CASSANDRA-12835:
Status: Ready to Commit (was: Patch Available)
> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
> Issue Type: Bug
>Reporter: Hannu Kröger
>Assignee: mck
>Priority: Critical
> Labels: tracing
> Fix For: 3.11.x, 4.x
>
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is
> QueryMessage and the code in
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
> is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder =
> ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be
> {{state.createTracingSession(getCustomPayload());}}. At least that fixes the
> problem for me.
> This also raises the question whether some other parts of the code should
> pass the custom payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:public void createTracingSession()
> 82:createTracingSession(Collections.EMPTY_MAP);
> 85:public void createTracingSession(Map customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:state.createTracingSession();
> {code}
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot
> be fixed by the tracing plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mck updated CASSANDRA-12835:
Attachment: (was: 12835-trunk.txt)
> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
> Issue Type: Bug
>Reporter: Hannu Kröger
>Assignee: mck
>Priority: Critical
> Labels: tracing
> Fix For: 3.11.x, 4.x
>
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is
> QueryMessage and the code in
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
> is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder =
> ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be
> {{state.createTracingSession(getCustomPayload());}}. At least that fixes the
> problem for me.
> This also raises the question whether some other parts of the code should
> pass the custom payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:public void createTracingSession()
> 82:createTracingSession(Collections.EMPTY_MAP);
> 85:public void createTracingSession(Map customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:state.createTracingSession();
> {code}
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot
> be fixed by the tracing plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mck updated CASSANDRA-12835:
Attachment: (was: 12835-3.X.txt)
> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
> Issue Type: Bug
>Reporter: Hannu Kröger
>Assignee: mck
>Priority: Critical
> Labels: tracing
> Fix For: 3.11.x, 4.x
>
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is
> QueryMessage and the code in
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
> is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder =
> ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be
> {{state.createTracingSession(getCustomPayload());}}. At least that fixes the
> problem for me.
> This also raises the question whether some other parts of the code should
> pass the custom payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:public void createTracingSession()
> 82:createTracingSession(Collections.EMPTY_MAP);
> 85:public void createTracingSession(Map customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:state.createTracingSession();
> {code}
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot
> be fixed by the tracing plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joshua McKenzie updated CASSANDRA-12835:
Reviewer: T Jake Luciani
> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
> Issue Type: Bug
>Reporter: Hannu Kröger
>Assignee: mck
>Priority: Critical
> Labels: tracing
> Fix For: 3.x, 4.x
>
> Attachments: 12835-3.X.txt, 12835-trunk.txt
>
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is
> QueryMessage and the code in
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
> is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder =
> ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be
> {{state.createTracingSession(getCustomPayload());}}. At least that fixes the
> problem for me.
> This also raises the question whether some other parts of the code should
> pass the custom payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:public void createTracingSession()
> 82:createTracingSession(Collections.EMPTY_MAP);
> 85:public void createTracingSession(Map customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:state.createTracingSession();
> {code}
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot
> be fixed by the tracing plugin.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mck updated CASSANDRA-12835:
Fix Version/s: 4.x
3.x
Status: Patch Available (was: In Progress)
> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
> Issue Type: Bug
>Reporter: Hannu Kröger
>Assignee: mck
>Priority: Critical
> Labels: tracing
> Fix For: 3.x, 4.x
>
> Attachments: 12835-3.X.txt, 12835-trunk.txt
>
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is
> QueryMessage and the code in
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
> is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder =
> ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be
> {{state.createTracingSession(getCustomPayload());}}. At least that fixes the
> problem for me.
> This also raises the question whether some other parts of the code should
> pass the custom payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:public void createTracingSession()
> 82:createTracingSession(Collections.EMPTY_MAP);
> 85:public void createTracingSession(Map customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:state.createTracingSession();
> {code}
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot
> be fixed by the tracing plugin.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mck updated CASSANDRA-12835:
Attachment: 12835-trunk.txt
12835-3.X.txt
Patches for 3.X and trunk.
> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
> Issue Type: Bug
>Reporter: Hannu Kröger
>Assignee: mck
>Priority: Critical
> Labels: tracing
> Attachments: 12835-3.X.txt, 12835-trunk.txt
>
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is
> QueryMessage and the code in
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
> is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder =
> ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be
> {{state.createTracingSession(getCustomPayload());}}. At least that fixes the
> problem for me.
> This also raises the question whether some other parts of the code should
> pass the custom payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:public void createTracingSession()
> 82:createTracingSession(Collections.EMPTY_MAP);
> 85:public void createTracingSession(Map customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:state.createTracingSession();
> {code}
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot
> be fixed by the tracing plugin.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hannu Kröger updated CASSANDRA-12835:
-
Reproduced In: 3.x
> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
> Issue Type: Bug
>Reporter: Hannu Kröger
>Priority: Critical
> Labels: tracing
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is
> QueryMessage and the code in
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
> is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder =
> ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be
> {{state.createTracingSession(getCustomPayload());}}. At least that fixes the
> problem for me.
> This also raises the question whether some other parts of the code should
> pass the custom payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:public void createTracingSession()
> 82:createTracingSession(Collections.EMPTY_MAP);
> 85:public void createTracingSession(Map customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:state.createTracingSession();
> {code}
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot
> be fixed by the tracing plugin.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hannu Kröger updated CASSANDRA-12835:
-
Description:
Caused by CASSANDRA-10392.
Related to CASSANDRA-11706.
When querying using CQL statements (not prepared) the message type is
QueryMessage and the code in
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
is as follows:
{code:java}
if (state.traceNextQuery())
{
state.createTracingSession();
ImmutableMap.Builder builder =
ImmutableMap.builder();
{code}
{{state.createTracingSession();}} should probably be
{{state.createTracingSession(getCustomPayload());}}. At least that fixes the
problem for me.
This also raises the question whether some other parts of the code should pass
the custom payload as well (I'm not the right person to analyze this):
{code}
$ ag createTracingSession
src/java/org/apache/cassandra/service/QueryState.java
80:public void createTracingSession()
82:createTracingSession(Collections.EMPTY_MAP);
85:public void createTracingSession(Map customPayload)
src/java/org/apache/cassandra/thrift/CassandraServer.java
2528:state().getQueryState().createTracingSession();
src/java/org/apache/cassandra/transport/messages/BatchMessage.java
163:state.createTracingSession();
src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
114:state.createTracingSession(getCustomPayload());
src/java/org/apache/cassandra/transport/messages/QueryMessage.java
101:state.createTracingSession();
src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
74:state.createTracingSession();
{code}
This is not marked as `minor` as the CASSANDRA-11706 was because this cannot be
fixed by the tracing plugin.
was:
Caused by CASSANDRA-10392.
Related to CASSANDRA-11706.
When querying using CQL statements (not prepared) the message type is
QueryMessage and the code in
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
is as follows:
{code:java}
if (state.traceNextQuery())
{
state.createTracingSession();
ImmutableMap.Builder builder =
ImmutableMap.builder();
{code}
`state.createTracingSession();` should probably be
`state.createTracingSession(getCustomPayload());`. At least that fixes the
problem for me.
This is not marked as `minor` as the CASSANDRA-11706 was because this cannot be
fixed by the tracing plugin.
> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
> Issue Type: Bug
>Reporter: Hannu Kröger
>Priority: Critical
> Labels: tracing
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is
> QueryMessage and the code in
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
> is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder =
> ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be
> {{state.createTracingSession(getCustomPayload());}}. At least that fixes the
> problem for me.
> This also raises the question whether some other parts of the code should
> pass the custom payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:public void createTracingSession()
> 82:createTracingSession(Collections.EMPTY_MAP);
> 85:public void createTracingSession(Map customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:state.createTracingSession();
> {code}
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot
> be fixed by the tracing plugin.
--
This message
[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hannu Kröger updated CASSANDRA-12835:
-
Description:
Caused by CASSANDRA-10392.
Related to CASSANDRA-11706.
When querying using CQL statements (not prepared) the message type is
QueryMessage and the code in
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
is as follows:
{code:java}
if (state.traceNextQuery())
{
state.createTracingSession();
ImmutableMap.Builder builder =
ImmutableMap.builder();
{code}
`state.createTracingSession();` should probably be
`state.createTracingSession(getCustomPayload());`. At least that fixes the
problem for me.
This is not marked as `minor` as the CASSANDRA-11706 was because this cannot be
fixed by the tracing plugin.
was:
Caused by CASSANDRA-10392.
Related to CASSANDRA-11706.
When querying using CQL statements (not prepared) the message type is
QueryMessage and the code in
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
is as follows:
```
if (state.traceNextQuery())
{
state.createTracingSession();
ImmutableMap.Builder builder =
ImmutableMap.builder();
```
`state.createTracingSession();` should probably be
`state.createTracingSession(getCustomPayload());`. At least that fixes the
problem for me.
This is not marked as `minor` as the CASSANDRA-11706 was because this cannot be
fixed by the tracing plugin.
> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
> Issue Type: Bug
>Reporter: Hannu Kröger
>Priority: Critical
> Labels: tracing
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is
> QueryMessage and the code in
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
> is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder =
> ImmutableMap.builder();
> {code}
> `state.createTracingSession();` should probably be
> `state.createTracingSession(getCustomPayload());`. At least that fixes the
> problem for me.
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot
> be fixed by the tracing plugin.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session
[
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hannu Kröger updated CASSANDRA-12835:
-
Description:
Caused by CASSANDRA-10392.
Related to CASSANDRA-11706.
When querying using CQL statements (not prepared) the message type is
QueryMessage and the code in
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
is as follows:
```
if (state.traceNextQuery())
{
state.createTracingSession();
ImmutableMap.Builder builder =
ImmutableMap.builder();
```
`state.createTracingSession();` should probably be
`state.createTracingSession(getCustomPayload());`. At least that fixes the
problem for me.
This is not marked as `minor` as the CASSANDRA-11706 was because this cannot be
fixed by the tracing plugin.
> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
> Issue Type: Bug
>Reporter: Hannu Kröger
>Priority: Critical
> Labels: tracing
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is
> QueryMessage and the code in
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
> is as follows:
> ```
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder =
> ImmutableMap.builder();
> ```
> `state.createTracingSession();` should probably be
> `state.createTracingSession(getCustomPayload());`. At least that fixes the
> problem for me.
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot
> be fixed by the tracing plugin.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
