[jira] [Updated] (CASSANDRA-13238) Add actual row output to assertEmpty error message
[
https://issues.apache.org/jira/browse/CASSANDRA-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-13238:
Fix Version/s: 4.x
3.11.x
3.0.x
> Add actual row output to assertEmpty error message
> --
>
> Key: CASSANDRA-13238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13238
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Trivial
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> We have several issues popping up every now and then that are hard to debug
> and the test failure messages aren't entirely helpful, for example:
> {code}
> java.lang.AssertionError: Expected empty result but got 1 rows:
> {code}
> It could be much better if we could have an actual output (what exactly the
> row that got returned appended to it:
> {code}
> java.lang.AssertionError: Expected empty result but got 1 rows:
> [row(value=null)]
> {code}
> The nice side-effect of this change is that now we will have a helper method
> that can nicely turn an {{UntypedResultSet}} into {{String}} (I apologise if
> I did overlooked one).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (CASSANDRA-13238) Add actual row output to assertEmpty error message
[
https://issues.apache.org/jira/browse/CASSANDRA-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-13238:
Fix Version/s: (was: 3.11.x)
(was: 4.x)
(was: 3.0.x)
4.0
3.11.0
3.0.13
> Add actual row output to assertEmpty error message
> --
>
> Key: CASSANDRA-13238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13238
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Trivial
> Labels: test
> Fix For: 3.0.13, 3.11.0, 4.0
>
>
> We have several issues popping up every now and then that are hard to debug
> and the test failure messages aren't entirely helpful, for example:
> {code}
> java.lang.AssertionError: Expected empty result but got 1 rows:
> {code}
> It could be much better if we could have an actual output (what exactly the
> row that got returned appended to it:
> {code}
> java.lang.AssertionError: Expected empty result but got 1 rows:
> [row(value=null)]
> {code}
> The nice side-effect of this change is that now we will have a helper method
> that can nicely turn an {{UntypedResultSet}} into {{String}} (I apologise if
> I did overlooked one).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (CASSANDRA-13238) Add actual row output to assertEmpty error message
[
https://issues.apache.org/jira/browse/CASSANDRA-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-13238:
Labels: test (was: )
> Add actual row output to assertEmpty error message
> --
>
> Key: CASSANDRA-13238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13238
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Trivial
> Labels: test
> Fix For: 3.0.13, 3.11.0, 4.0
>
>
> We have several issues popping up every now and then that are hard to debug
> and the test failure messages aren't entirely helpful, for example:
> {code}
> java.lang.AssertionError: Expected empty result but got 1 rows:
> {code}
> It could be much better if we could have an actual output (what exactly the
> row that got returned appended to it:
> {code}
> java.lang.AssertionError: Expected empty result but got 1 rows:
> [row(value=null)]
> {code}
> The nice side-effect of this change is that now we will have a helper method
> that can nicely turn an {{UntypedResultSet}} into {{String}} (I apologise if
> I did overlooked one).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (CASSANDRA-13238) Add actual row output to assertEmpty error message
[
https://issues.apache.org/jira/browse/CASSANDRA-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-13238:
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Add actual row output to assertEmpty error message
> --
>
> Key: CASSANDRA-13238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13238
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Trivial
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> We have several issues popping up every now and then that are hard to debug
> and the test failure messages aren't entirely helpful, for example:
> {code}
> java.lang.AssertionError: Expected empty result but got 1 rows:
> {code}
> It could be much better if we could have an actual output (what exactly the
> row that got returned appended to it:
> {code}
> java.lang.AssertionError: Expected empty result but got 1 rows:
> [row(value=null)]
> {code}
> The nice side-effect of this change is that now we will have a helper method
> that can nicely turn an {{UntypedResultSet}} into {{String}} (I apologise if
> I did overlooked one).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (CASSANDRA-13238) Add actual row output to assertEmpty error message
[
https://issues.apache.org/jira/browse/CASSANDRA-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-13238:
Status: Ready to Commit (was: Patch Available)
> Add actual row output to assertEmpty error message
> --
>
> Key: CASSANDRA-13238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13238
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Alex Petrov
>Priority: Trivial
>
> We have several issues popping up every now and then that are hard to debug
> and the test failure messages aren't entirely helpful, for example:
> {code}
> java.lang.AssertionError: Expected empty result but got 1 rows:
> {code}
> It could be much better if we could have an actual output (what exactly the
> row that got returned appended to it:
> {code}
> java.lang.AssertionError: Expected empty result but got 1 rows:
> [row(value=null)]
> {code}
> The nice side-effect of this change is that now we will have a helper method
> that can nicely turn an {{UntypedResultSet}} into {{String}} (I apologise if
> I did overlooked one).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (CASSANDRA-13238) Add actual row output to assertEmpty error message
[
https://issues.apache.org/jira/browse/CASSANDRA-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-13238:
Status: Patch Available (was: Open)
And a trivial patch to fix it (without CI, but hope it's also not necessary):
[3.0|https://github.com/ifesdjeen/cassandra/tree/12811-3.0] would merge clean
up to trunk.
> Add actual row output to assertEmpty error message
> --
>
> Key: CASSANDRA-13238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13238
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Alex Petrov
>Priority: Trivial
>
> We have several issues popping up every now and then that are hard to debug
> and the test failure messages aren't entirely helpful, for example:
> {code}
> java.lang.AssertionError: Expected empty result but got 1 rows:
> {code}
> It could be much better if we could have an actual output (what exactly the
> row that got returned appended to it:
> {code}
> java.lang.AssertionError: Expected empty result but got 1 rows:
> [row(value=null)]
> {code}
> The nice side-effect of this change is that now we will have a helper method
> that can nicely turn an {{UntypedResultSet}} into {{String}} (I apologise if
> I did overlooked one).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
