[jira] [Updated] (CASSANDRA-13801) CompactionManager sometimes wrongly determines that a background compaction is running for a particular table
[
https://issues.apache.org/jira/browse/CASSANDRA-13801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo Motta updated CASSANDRA-13801:
Resolution: Fixed
Fix Version/s: 4.0
3.11.2
3.0.16
2.2.12
Status: Resolved (was: Patch Available)
Good catch, patch and tests LGTM! I looked the results of the dtests on
internal CI and they look good (unrelated failures), can you just attach the
screen shots so they are public?
I will commit this to 2.2 even though it is in critical fixes mode because it's
pretty simple/safe and the only way to solve it is to restart the node if it
ever gets into this nasty state.
I added a comment on
[CompactionManager.submitBackground|https://github.com/apache/cassandra/commit/35e6d61361e699908d73c277da7d9ac3390f6e5d#diff-d4e3b82e9bebfd2cb466b4a30af07fa4R159]
extracted from CASSANDRA-4310 to explain the reasoning behind keeping track of
compacting cfs.
Committed to 2.2 as {{35e6d61361e699908d73c277da7d9ac3390f6e5d}} and merged up
to cassandra-3.0, cassandra-3.11 and trunk. Thanks!
> CompactionManager sometimes wrongly determines that a background compaction
> is running for a particular table
> -
>
> Key: CASSANDRA-13801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13801
> Project: Cassandra
> Issue Type: Bug
> Components: Compaction
>Reporter: Dimitar Dimitrov
>Assignee: Dimitar Dimitrov
>Priority: Minor
> Fix For: 2.2.12, 3.0.16, 3.11.2, 4.0
>
> Attachments: c13801-2.2-testall.png, c13801-3.0-testall.png,
> c13801-3.11-testall.png, c13801-trunk-testall.png
>
>
> Sometimes after writing different rows to a table, then doing a blocking
> flush, if you alter the compaction strategy, then run background compaction
> and wait for it to finish, {{CompactionManager}} may decide that there's an
> ongoing compaction for that same table.
> This may happen even though logs don't indicate that to be the case
> (compaction may still be running for system_schema tables).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13801) CompactionManager sometimes wrongly determines that a background compaction is running for a particular table
[
https://issues.apache.org/jira/browse/CASSANDRA-13801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dimitar Dimitrov updated CASSANDRA-13801:
-
Status: Patch Available (was: Open)
> CompactionManager sometimes wrongly determines that a background compaction
> is running for a particular table
> -
>
> Key: CASSANDRA-13801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13801
> Project: Cassandra
> Issue Type: Bug
> Components: Compaction
>Reporter: Dimitar Dimitrov
>Assignee: Dimitar Dimitrov
>Priority: Minor
> Attachments: c13801-2.2-testall.png, c13801-3.0-testall.png,
> c13801-3.11-testall.png, c13801-trunk-testall.png
>
>
> Sometimes after writing different rows to a table, then doing a blocking
> flush, if you alter the compaction strategy, then run background compaction
> and wait for it to finish, {{CompactionManager}} may decide that there's an
> ongoing compaction for that same table.
> This may happen even though logs don't indicate that to be the case
> (compaction may still be running for system_schema tables).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13801) CompactionManager sometimes wrongly determines that a background compaction is running for a particular table
[
https://issues.apache.org/jira/browse/CASSANDRA-13801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dimitar Dimitrov updated CASSANDRA-13801:
-
Attachment: c13801-2.2-testall.png
c13801-3.0-testall.png
c13801-3.11-testall.png
c13801-trunk-testall.png
> CompactionManager sometimes wrongly determines that a background compaction
> is running for a particular table
> -
>
> Key: CASSANDRA-13801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13801
> Project: Cassandra
> Issue Type: Bug
> Components: Compaction
>Reporter: Dimitar Dimitrov
>Assignee: Dimitar Dimitrov
>Priority: Minor
> Attachments: c13801-2.2-testall.png, c13801-3.0-testall.png,
> c13801-3.11-testall.png, c13801-trunk-testall.png
>
>
> Sometimes after writing different rows to a table, then doing a blocking
> flush, if you alter the compaction strategy, then run background compaction
> and wait for it to finish, {{CompactionManager}} may decide that there's an
> ongoing compaction for that same table.
> This may happen even though logs don't indicate that to be the case
> (compaction may still be running for system_schema tables).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13801) CompactionManager sometimes wrongly determines that a background compaction is running for a particular table
[
https://issues.apache.org/jira/browse/CASSANDRA-13801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo Motta updated CASSANDRA-13801:
Reviewer: Paulo Motta
> CompactionManager sometimes wrongly determines that a background compaction
> is running for a particular table
> -
>
> Key: CASSANDRA-13801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13801
> Project: Cassandra
> Issue Type: Bug
> Components: Compaction
>Reporter: Dimitar Dimitrov
>Assignee: Dimitar Dimitrov
>Priority: Minor
>
> Sometimes after writing different rows to a table, then doing a blocking
> flush, if you alter the compaction strategy, then run background compaction
> and wait for it to finish, {{CompactionManager}} may decide that there's an
> ongoing compaction for that same table.
> This may happen even though logs don't indicate that to be the case
> (compaction may still be running for system_schema tables).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13801) CompactionManager sometimes wrongly determines that a background compaction is running for a particular table
[
https://issues.apache.org/jira/browse/CASSANDRA-13801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joshua McKenzie updated CASSANDRA-13801:
Priority: Minor (was: Major)
> CompactionManager sometimes wrongly determines that a background compaction
> is running for a particular table
> -
>
> Key: CASSANDRA-13801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13801
> Project: Cassandra
> Issue Type: Bug
> Components: Compaction
>Reporter: Dimitar Dimitrov
>Assignee: Dimitar Dimitrov
>Priority: Minor
>
> Sometimes after writing different rows to a table, then doing a blocking
> flush, if you alter the compaction strategy, then run background compaction
> and wait for it to finish, {{CompactionManager}} may decide that there's an
> ongoing compaction for that same table.
> This may happen even though logs don't indicate that to be the case
> (compaction may still be running for system_schema tables).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
