[jira] [Updated] (CASSANDRA-14085) Excessive update of ReadLatency metric in digest calculation
[ https://issues.apache.org/jira/browse/CASSANDRA-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-14085: --- Fix Version/s: (was: 3.11.x) (was: 4.x) (was: 3.0.x) 4.0.1 3.11.12 3.0.26 > Excessive update of ReadLatency metric in digest calculation > > > Key: CASSANDRA-14085 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14085 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core, Observability/Metrics >Reporter: Andrew Whang >Assignee: Andrew Whang >Priority: Low > Fix For: 3.0.26, 3.11.12, 4.0.1, 4.1 > > > We noticed an increase in read latency after upgrading to 3.x, specifically > for requests with CL>ONE. It turns out the read latency metric is being > doubly updated for digest calculations. This code > (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java#L243) > makes an improper copy of an iterator that's wrapped by MetricRecording, > whose onClose() records the latency of the execution. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14085) Excessive update of ReadLatency metric in digest calculation
[ https://issues.apache.org/jira/browse/CASSANDRA-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14085: - Status: Open (was: Patch Available) > Excessive update of ReadLatency metric in digest calculation > > > Key: CASSANDRA-14085 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14085 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core, Observability/Metrics >Reporter: Andrew Whang >Assignee: Andrew Whang >Priority: Low > Fix For: 3.0.x, 3.11.x, 4.x > > > We noticed an increase in read latency after upgrading to 3.x, specifically > for requests with CL>ONE. It turns out the read latency metric is being > doubly updated for digest calculations. This code > (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java#L243) > makes an improper copy of an iterator that's wrapped by MetricRecording, > whose onClose() records the latency of the execution. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14085) Excessive update of ReadLatency metric in digest calculation
[ https://issues.apache.org/jira/browse/CASSANDRA-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14085: - Resolution: Not A Problem Status: Resolved (was: Open) This no longer appears to be an issue: https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java#L247 > Excessive update of ReadLatency metric in digest calculation > > > Key: CASSANDRA-14085 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14085 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core, Observability/Metrics >Reporter: Andrew Whang >Assignee: Andrew Whang >Priority: Low > Fix For: 3.0.x, 3.11.x, 4.x > > > We noticed an increase in read latency after upgrading to 3.x, specifically > for requests with CL>ONE. It turns out the read latency metric is being > doubly updated for digest calculations. This code > (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java#L243) > makes an improper copy of an iterator that's wrapped by MetricRecording, > whose onClose() records the latency of the execution. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14085) Excessive update of ReadLatency metric in digest calculation
[ https://issues.apache.org/jira/browse/CASSANDRA-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Jirsa updated CASSANDRA-14085: --- Fix Version/s: (was: 3.0.16) (was: 4.0) 4.x 3.11.x 3.0.x > Excessive update of ReadLatency metric in digest calculation > > > Key: CASSANDRA-14085 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14085 > Project: Cassandra > Issue Type: Bug > Components: Core, Metrics >Reporter: Andrew Whang >Assignee: Andrew Whang >Priority: Minor > Fix For: 3.0.x, 3.11.x, 4.x > > > We noticed an increase in read latency after upgrading to 3.x, specifically > for requests with CL>ONE. It turns out the read latency metric is being > doubly updated for digest calculations. This code > (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java#L243) > makes an improper copy of an iterator that's wrapped by MetricRecording, > whose onClose() records the latency of the execution. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14085) Excessive update of ReadLatency metric in digest calculation
[ https://issues.apache.org/jira/browse/CASSANDRA-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Jirsa updated CASSANDRA-14085: --- Component/s: Core > Excessive update of ReadLatency metric in digest calculation > > > Key: CASSANDRA-14085 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14085 > Project: Cassandra > Issue Type: Bug > Components: Core, Metrics >Reporter: Andrew Whang >Assignee: Andrew Whang >Priority: Minor > Fix For: 3.0.x, 3.11.x, 4.x > > > We noticed an increase in read latency after upgrading to 3.x, specifically > for requests with CL>ONE. It turns out the read latency metric is being > doubly updated for digest calculations. This code > (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java#L243) > makes an improper copy of an iterator that's wrapped by MetricRecording, > whose onClose() records the latency of the execution. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14085) Excessive update of ReadLatency metric in digest calculation
[ https://issues.apache.org/jira/browse/CASSANDRA-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Whang updated CASSANDRA-14085: - Fix Version/s: 4.0 3.0.16 Status: Patch Available (was: Open) https://github.com/whangsf/cassandra/commit/2ae3589ce9eefd8699bbd4e29bf1c61a486d394e > Excessive update of ReadLatency metric in digest calculation > > > Key: CASSANDRA-14085 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14085 > Project: Cassandra > Issue Type: Bug > Components: Metrics >Reporter: Andrew Whang >Priority: Minor > Fix For: 3.0.16, 4.0 > > > We noticed an increase in read latency after upgrading to 3.x, specifically > for requests with CL>ONE. It turns out the read latency metric is being > doubly updated for digest calculations. This code > (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java#L243) > makes an improper copy of an iterator that's wrapped by MetricRecording, > whose onClose() records the latency of the execution. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org