[jira] [Updated] (CASSANDRA-15002) Avoid leaking threads when anticompaction fails
[
https://issues.apache.org/jira/browse/CASSANDRA-15002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eriksson updated CASSANDRA-15002:
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
And committed as {{7f634feb7cf1fdb135133946ffd75efa681b8cb7}}, thanks
Ran the failing test in a loop locally successfully, don't think this patch
caused the test failure
> Avoid leaking threads when anticompaction fails
> ---
>
> Key: CASSANDRA-15002
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15002
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
> Fix For: 4.0
>
>
> If anticompaction fails on a node, a message is sent to all repair
> participants that this session is failed. If the other participants
> successfully finish their anticompactions we will not shut down the executor
> in `LocalSessions` since we can't change the state from "FAILED" to
> "PREPARED" and throw exception before calling shutdown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15002) Avoid leaking threads when anticompaction fails
[ https://issues.apache.org/jira/browse/CASSANDRA-15002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-15002: Status: Ready to Commit (was: Patch Available) > Avoid leaking threads when anticompaction fails > --- > > Key: CASSANDRA-15002 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15002 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Major > Fix For: 4.0 > > > If anticompaction fails on a node, a message is sent to all repair > participants that this session is failed. If the other participants > successfully finish their anticompactions we will not shut down the executor > in `LocalSessions` since we can't change the state from "FAILED" to > "PREPARED" and throw exception before calling shutdown. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15002) Avoid leaking threads when anticompaction fails
[ https://issues.apache.org/jira/browse/CASSANDRA-15002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-15002: Status: Patch Available (was: Open) Patch: https://github.com/krummas/cassandra/commits/marcuse/15002 Tests: https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F15002 The branch contains 2 commits, first one fixes the thread leak and retries acquiring sstables for 1 minute, the second commit adds rate limiting to anticompaction and makes anticompactions stoppable again (should have been done in CASSANDRA-14935). The reasoning behind adding retries when trying to acquire sstables is that if there is an sstable [0, 100] and the user submits a repair on [0, 50], we will anticompact the sstable in to two new sstables [0, 50], [51, 100] - if a user submits a repair on [51, 100] while the first anticompaction is executing, we would fail immediately, since the sstable the new repair requires is busy anticompacting. By retrying to acquire sstables we give the first anticompaction a chance to finish and the new repair would be able to grab the new [51, 100] sstable - it does not need to wait for the whole first repair to finish. > Avoid leaking threads when anticompaction fails > --- > > Key: CASSANDRA-15002 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15002 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Major > Fix For: 4.0 > > > If anticompaction fails on a node, a message is sent to all repair > participants that this session is failed. If the other participants > successfully finish their anticompactions we will not shut down the executor > in `LocalSessions` since we can't change the state from "FAILED" to > "PREPARED" and throw exception before calling shutdown. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
