[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15704: --- Change Category: Operability Complexity: Low Hanging Fruit Status: Open (was: Triage Needed) > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15704: --- Test and Documentation Plan: PR here: https://github.com/apache/cassandra/pull/524 Status: Patch Available (was: Open) > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15704: --- Test and Documentation Plan: (was: PR here: https://github.com/apache/cassandra/pull/524) > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15704: -- Reviewers: David Capwell, David Capwell (was: David Capwell) David Capwell, David Capwell Status: Review In Progress (was: Patch Available) > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-15704: --- Labels: pull-request-available (was: ) > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > Labels: pull-request-available > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-15704: --- Labels: pull-request-available (was: ) > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > Labels: pull-request-available > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-15704: --- Labels: pull-request-available (was: ) > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > Labels: pull-request-available > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15704: -- Status: Changes Suggested (was: Review In Progress) Feedback in GitHub. The main comment is that Netty keeps appending to the same buffer which leads to double counting, and we output frame as two buffers which leads to skewed histogram on the encoding side. It is a small change to move this logic to the two call sites which know the correct sizes. Other than that, LGTM. > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15704: --- Test and Documentation Plan: CircleCI Status: Patch Available (was: In Progress) > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15704: --- Status: In Progress (was: Changes Suggested) > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15704: -- Reviewers: David Capwell, David Capwell (was: David Capwell) David Capwell, David Capwell (was: David Capwell) Status: Review In Progress (was: Patch Available) > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15704: --- Status: Ready to Commit (was: Review In Progress) > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15704) add client request size metrics to netty pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15704: --- Fix Version/s: 4.0-alpha Source Control Link: https://github.com/apache/cassandra/commit/165081afdaf82ff36a1ccf46f933faf6f76ec102 Resolution: Fixed Status: Resolved (was: Ready to Commit) > add client request size metrics to netty pipeline > - > > Key: CASSANDRA-15704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15704 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Jon Haddad >Assignee: Jon Haddad >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 40m > Remaining Estimate: 0h > > We currently lack metrics around client connection incoming / outgoing bytes. > It’s fairly standard to know how many bytes are read and written to the > network, but that aggregates client facing and internal cluster traffic to a > single number. This patch will help us understand client overhead more > granularly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
