[jira] [Updated] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
[
https://issues.apache.org/jira/browse/CASSANDRA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16028:
-
Since Version: 2.1.21
Source Control Link:
https://github.com/apache/cassandra/commit/f93c5631636020cd3fa1f39d0ac92959102bd5eb
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed, thanks!
> cqlsh tests broken in Python 3.7+
> -
>
> Key: CASSANDRA-16028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> {code:java}
> // cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
> if not isinstance(until, re._pattern_type):
> AttributeError: module 're' has no attribute '_pattern_type'
> {code}
> An internal module attribute was changed/removed from Python 3.7 on.
> [https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272]
> This breakage did not manifest in CI because the test use the Jenkins host
> system Python, which is 3.6.
> I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
[
https://issues.apache.org/jira/browse/CASSANDRA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16028:
-
Reviewers: Brandon Williams, Brandon Williams (was: Brandon Williams)
Brandon Williams, Brandon Williams
Status: Review In Progress (was: Patch Available)
> cqlsh tests broken in Python 3.7+
> -
>
> Key: CASSANDRA-16028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> {code:java}
> // cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
> if not isinstance(until, re._pattern_type):
> AttributeError: module 're' has no attribute '_pattern_type'
> {code}
> An internal module attribute was changed/removed from Python 3.7 on.
> [https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272]
> This breakage did not manifest in CI because the test use the Jenkins host
> system Python, which is 3.6.
> I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
[
https://issues.apache.org/jira/browse/CASSANDRA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16028:
-
Status: Ready to Commit (was: Review In Progress)
> cqlsh tests broken in Python 3.7+
> -
>
> Key: CASSANDRA-16028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> {code:java}
> // cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
> if not isinstance(until, re._pattern_type):
> AttributeError: module 're' has no attribute '_pattern_type'
> {code}
> An internal module attribute was changed/removed from Python 3.7 on.
> [https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272]
> This breakage did not manifest in CI because the test use the Jenkins host
> system Python, which is 3.6.
> I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
[
https://issues.apache.org/jira/browse/CASSANDRA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-16028:
--
Test and Documentation Plan:
repro/validation:
- activate python 3.7+
- cd pylib/cqlshlib; nosetests
- apply patch
- run tests again, expecting success
- activate python 3.6 and/or 2.7 and verify
No docs required.
Status: Patch Available (was: In Progress)
https://github.com/apache/cassandra/pull/710
> cqlsh tests broken in Python 3.7+
> -
>
> Key: CASSANDRA-16028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> {code:java}
> // cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
> if not isinstance(until, re._pattern_type):
> AttributeError: module 're' has no attribute '_pattern_type'
> {code}
> An internal module attribute was changed/removed from Python 3.7 on.
> [https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272]
> This breakage did not manifest in CI because the test use the Jenkins host
> system Python, which is 3.6.
> I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
[
https://issues.apache.org/jira/browse/CASSANDRA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-16028:
--
Description:
{code:java}
// cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
if not isinstance(until, re._pattern_type):
AttributeError: module 're' has no attribute '_pattern_type'
{code}
An internal module attribute was changed/removed from Python 3.7 on.
[https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272]
This breakage did not manifest in CI because the test use the Jenkins host
system Python, which is 3.6.
I have a trivial patch I'll add shortly.
was:
{code:java}
// cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
if not isinstance(until, re._pattern_type):
AttributeError: module 're' has no attribute '_pattern_type'
{code}
An internal module attribute was changed/removed from Python 3.7 on.
This breakage did not manifest in CI because the test use the Jenkins host
system Python, which is 3.6.
I have a trivial patch I'll add shortly.
> cqlsh tests broken in Python 3.7+
> -
>
> Key: CASSANDRA-16028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> {code:java}
> // cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
> if not isinstance(until, re._pattern_type):
> AttributeError: module 're' has no attribute '_pattern_type'
> {code}
> An internal module attribute was changed/removed from Python 3.7 on.
> [https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272]
> This breakage did not manifest in CI because the test use the Jenkins host
> system Python, which is 3.6.
> I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
[
https://issues.apache.org/jira/browse/CASSANDRA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-16028:
--
Bug Category: Parent values: Code(13163)
Complexity: Low Hanging Fruit
Discovered By: Unit Test
Fix Version/s: 4.0-beta2
Severity: Low
Status: Open (was: Triage Needed)
> cqlsh tests broken in Python 3.7+
> -
>
> Key: CASSANDRA-16028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> {code:java}
> // cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
> if not isinstance(until, re._pattern_type):
> AttributeError: module 're' has no attribute '_pattern_type'
> {code}
> An internal module attribute was changed/removed from Python 3.7 on.
> This breakage did not manifest in CI because the test use the Jenkins host
> system Python, which is 3.6.
> I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
