[jira] [Updated] (CASSANDRA-16883) Weak visibility guarantees of Accumulator can lead to failure to recognize digest mismatches
[
https://issues.apache.org/jira/browse/CASSANDRA-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16883:
Since Version: 3.0.0
Source Control Link:
https://github.com/apache/cassandra/commit/f9d41ff83655ead37ac6083d7ee43f2c35a346da
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed as
https://github.com/apache/cassandra/commit/f9d41ff83655ead37ac6083d7ee43f2c35a346da
to {{cassandra-3.0}}.
> Weak visibility guarantees of Accumulator can lead to failure to recognize
> digest mismatches
>
>
> Key: CASSANDRA-16883
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16883
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 3.0.26, 3.11.12
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The context for this problem is largely the same as CASSANDRA-16807. The
> difference is that for 4.0+, CASSANDRA-16097 added an assertion to
> {{DigestResolver#responseMatch()}} that ensures the responses snapshot has at
> least one visible element (although of course only one element trivially
> cannot generate a mismatch and short-circuits immediately). In 3.0 and 3.11,
> this assertion does not exist, and when the underlying problem occurs (i.e.
> zero responses are visible on {{Accumulator}} when there should be 2), we can
> silently avoid the digest matching entirely. This seems like it would make it
> both impossible to do a potentially necessary full data read to resolve the
> correct response and prevent repair.
> The fix here should be similar to the one in CASSANDRA-16807, although there
> might be some test infrastructure that needs porting in order to make that
> work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16883) Weak visibility guarantees of Accumulator can lead to failure to recognize digest mismatches
[
https://issues.apache.org/jira/browse/CASSANDRA-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16883:
Fix Version/s: (was: 3.11.x)
(was: 3.0.x)
3.11.12
3.0.26
> Weak visibility guarantees of Accumulator can lead to failure to recognize
> digest mismatches
>
>
> Key: CASSANDRA-16883
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16883
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 3.0.26, 3.11.12
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The context for this problem is largely the same as CASSANDRA-16807. The
> difference is that for 4.0+, CASSANDRA-16097 added an assertion to
> {{DigestResolver#responseMatch()}} that ensures the responses snapshot has at
> least one visible element (although of course only one element trivially
> cannot generate a mismatch and short-circuits immediately). In 3.0 and 3.11,
> this assertion does not exist, and when the underlying problem occurs (i.e.
> zero responses are visible on {{Accumulator}} when there should be 2), we can
> silently avoid the digest matching entirely. This seems like it would make it
> both impossible to do a potentially necessary full data read to resolve the
> correct response and prevent repair.
> The fix here should be similar to the one in CASSANDRA-16807, although there
> might be some test infrastructure that needs porting in order to make that
> work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16883) Weak visibility guarantees of Accumulator can lead to failure to recognize digest mismatches
[
https://issues.apache.org/jira/browse/CASSANDRA-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16883:
Status: Ready to Commit (was: Review In Progress)
> Weak visibility guarantees of Accumulator can lead to failure to recognize
> digest mismatches
>
>
> Key: CASSANDRA-16883
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16883
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The context for this problem is largely the same as CASSANDRA-16807. The
> difference is that for 4.0+, CASSANDRA-16097 added an assertion to
> {{DigestResolver#responseMatch()}} that ensures the responses snapshot has at
> least one visible element (although of course only one element trivially
> cannot generate a mismatch and short-circuits immediately). In 3.0 and 3.11,
> this assertion does not exist, and when the underlying problem occurs (i.e.
> zero responses are visible on {{Accumulator}} when there should be 2), we can
> silently avoid the digest matching entirely. This seems like it would make it
> both impossible to do a potentially necessary full data read to resolve the
> correct response and prevent repair.
> The fix here should be similar to the one in CASSANDRA-16807, although there
> might be some test infrastructure that needs porting in order to make that
> work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16883) Weak visibility guarantees of Accumulator can lead to failure to recognize digest mismatches
[
https://issues.apache.org/jira/browse/CASSANDRA-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Meredith updated CASSANDRA-16883:
-
Reviewers: Jon Meredith, Jon Meredith (was: Jon Meredith)
Jon Meredith, Jon Meredith
Status: Review In Progress (was: Patch Available)
> Weak visibility guarantees of Accumulator can lead to failure to recognize
> digest mismatches
>
>
> Key: CASSANDRA-16883
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16883
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The context for this problem is largely the same as CASSANDRA-16807. The
> difference is that for 4.0+, CASSANDRA-16097 added an assertion to
> {{DigestResolver#responseMatch()}} that ensures the responses snapshot has at
> least one visible element (although of course only one element trivially
> cannot generate a mismatch and short-circuits immediately). In 3.0 and 3.11,
> this assertion does not exist, and when the underlying problem occurs (i.e.
> zero responses are visible on {{Accumulator}} when there should be 2), we can
> silently avoid the digest matching entirely. This seems like it would make it
> both impossible to do a potentially necessary full data read to resolve the
> correct response and prevent repair.
> The fix here should be similar to the one in CASSANDRA-16807, although there
> might be some test infrastructure that needs porting in order to make that
> work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16883) Weak visibility guarantees of Accumulator can lead to failure to recognize digest mismatches
[
https://issues.apache.org/jira/browse/CASSANDRA-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16883:
Test and Documentation Plan: new unit test in {{DigestResolverTest}} covers
the changes here
Status: Patch Available (was: In Progress)
||branch||Circle CI||Apache CI|
|[3.0|https://github.com/apache/cassandra/pull/1173]|[J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-16883-3.0]|[1078|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1078/]
> Weak visibility guarantees of Accumulator can lead to failure to recognize
> digest mismatches
>
>
> Key: CASSANDRA-16883
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16883
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> The context for this problem is largely the same as CASSANDRA-16807. The
> difference is that for 4.0+, CASSANDRA-16097 added an assertion to
> {{DigestResolver#responseMatch()}} that ensures the responses snapshot has at
> least one visible element (although of course only one element trivially
> cannot generate a mismatch and short-circuits immediately). In 3.0 and 3.11,
> this assertion does not exist, and when the underlying problem occurs (i.e.
> zero responses are visible on {{Accumulator}} when there should be 2), we can
> silently avoid the digest matching entirely. This seems like it would make it
> both impossible to do a potentially necessary full data read to resolve the
> correct response and prevent repair.
> The fix here should be similar to the one in CASSANDRA-16807, although there
> might be some test infrastructure that needs porting in order to make that
> work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16883) Weak visibility guarantees of Accumulator can lead to failure to recognize digest mismatches
[
https://issues.apache.org/jira/browse/CASSANDRA-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16883:
Bug Category: Parent values: Correctness(12982)Level 1 values:
Consistency(12989)
Complexity: Normal
Discovered By: Fuzz Test
Fix Version/s: 3.11.x
3.0.x
Severity: Critical
Status: Open (was: Triage Needed)
> Weak visibility guarantees of Accumulator can lead to failure to recognize
> digest mismatches
>
>
> Key: CASSANDRA-16883
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16883
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> The context for this problem is largely the same as CASSANDRA-16807. The
> difference is that for 4.0+, CASSANDRA-16097 added an assertion to
> {{DigestResolver#responseMatch()}} that ensures the responses snapshot has at
> least one visible element (although of course only one element trivially
> cannot generate a mismatch and short-circuits immediately). In 3.0 and 3.11,
> this assertion does not exist, and when the underlying problem occurs (i.e.
> zero responses are visible on {{Accumulator}} when there should be 2), we can
> silently avoid the digest matching entirely. This seems like it would make it
> both impossible to do a potentially necessary full data read to resolve the
> correct response and prevent repair.
> The fix here should be similar to the one in CASSANDRA-16807, although there
> might be some test infrastructure that needs porting in order to make that
> work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
