[jira] [Updated] (CASSANDRA-17069) Refactor normal/preview/IR repair to standardize repair cleanup and error handling of failed RepairJobs
[ https://issues.apache.org/jira/browse/CASSANDRA-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17069: -- Fix Version/s: 4.1 (was: 4.x) Source Control Link: https://github.com/apache/cassandra/commit/b84ec51b4c73d7b9b58ea8a1708ae2f330972970 Resolution: Fixed Status: Resolved (was: Ready to Commit) There were many failures... so need to justify here... * python dtest in j8 looked to have a CI issue where another process was listening on the port; the tests were passing in j11, so ignoring the bad results from j8 * jvm dtest is 2 known issues: CASSANDRA-17143 and the bootstrap one I just linked * python dtest hinted handoff failed, but confirmed using butler this is a known flaky test; there wasn't a JIRA so filed CASSANDRA-17144 * jvm dtest upgrade tests are still failing for compact storage, not seen them passing in trunk yet * python dtest upgrade tests, all known issues > Refactor normal/preview/IR repair to standardize repair cleanup and error > handling of failed RepairJobs > --- > > Key: CASSANDRA-17069 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17069 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.1 > > > Right now we have 3 different implementations of repair: normal, preview, and > incremental (IR); all 3 handle RepairJob failures differently and offer > different state cleanup. To make sure that we consistently handle errors the > same way and cleanup, we should move these responsibilities outside of the > repair task itself and move these into common APIs and move some logic into > the repair coordination its self. > This work relates with CASSANDRA-15399 as special handling each task makes > the work more complex. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17069) Refactor normal/preview/IR repair to standardize repair cleanup and error handling of failed RepairJobs
[ https://issues.apache.org/jira/browse/CASSANDRA-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17069: -- Status: Ready to Commit (was: Review In Progress) > Refactor normal/preview/IR repair to standardize repair cleanup and error > handling of failed RepairJobs > --- > > Key: CASSANDRA-17069 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17069 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > > Right now we have 3 different implementations of repair: normal, preview, and > incremental (IR); all 3 handle RepairJob failures differently and offer > different state cleanup. To make sure that we consistently handle errors the > same way and cleanup, we should move these responsibilities outside of the > repair task itself and move these into common APIs and move some logic into > the repair coordination its self. > This work relates with CASSANDRA-15399 as special handling each task makes > the work more complex. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17069) Refactor normal/preview/IR repair to standardize repair cleanup and error handling of failed RepairJobs
[ https://issues.apache.org/jira/browse/CASSANDRA-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17069: -- Status: Review In Progress (was: Patch Available) > Refactor normal/preview/IR repair to standardize repair cleanup and error > handling of failed RepairJobs > --- > > Key: CASSANDRA-17069 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17069 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > > Right now we have 3 different implementations of repair: normal, preview, and > incremental (IR); all 3 handle RepairJob failures differently and offer > different state cleanup. To make sure that we consistently handle errors the > same way and cleanup, we should move these responsibilities outside of the > repair task itself and move these into common APIs and move some logic into > the repair coordination its self. > This work relates with CASSANDRA-15399 as special handling each task makes > the work more complex. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17069) Refactor normal/preview/IR repair to standardize repair cleanup and error handling of failed RepairJobs
[ https://issues.apache.org/jira/browse/CASSANDRA-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-17069: Reviewers: Marcus Eriksson > Refactor normal/preview/IR repair to standardize repair cleanup and error > handling of failed RepairJobs > --- > > Key: CASSANDRA-17069 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17069 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > > Right now we have 3 different implementations of repair: normal, preview, and > incremental (IR); all 3 handle RepairJob failures differently and offer > different state cleanup. To make sure that we consistently handle errors the > same way and cleanup, we should move these responsibilities outside of the > repair task itself and move these into common APIs and move some logic into > the repair coordination its self. > This work relates with CASSANDRA-15399 as special handling each task makes > the work more complex. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17069) Refactor normal/preview/IR repair to standardize repair cleanup and error handling of failed RepairJobs
[ https://issues.apache.org/jira/browse/CASSANDRA-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17069: -- Test and Documentation Plan: added tests and rely on existing ones Status: Patch Available (was: In Progress) > Refactor normal/preview/IR repair to standardize repair cleanup and error > handling of failed RepairJobs > --- > > Key: CASSANDRA-17069 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17069 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > > Right now we have 3 different implementations of repair: normal, preview, and > incremental (IR); all 3 handle RepairJob failures differently and offer > different state cleanup. To make sure that we consistently handle errors the > same way and cleanup, we should move these responsibilities outside of the > repair task itself and move these into common APIs and move some logic into > the repair coordination its self. > This work relates with CASSANDRA-15399 as special handling each task makes > the work more complex. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17069) Refactor normal/preview/IR repair to standardize repair cleanup and error handling of failed RepairJobs
[ https://issues.apache.org/jira/browse/CASSANDRA-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17069: -- Change Category: Quality Assurance Complexity: Low Hanging Fruit Fix Version/s: 4.x Status: Open (was: Triage Needed) > Refactor normal/preview/IR repair to standardize repair cleanup and error > handling of failed RepairJobs > --- > > Key: CASSANDRA-17069 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17069 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > > Right now we have 3 different implementations of repair: normal, preview, and > incremental (IR); all 3 handle RepairJob failures differently and offer > different state cleanup. To make sure that we consistently handle errors the > same way and cleanup, we should move these responsibilities outside of the > repair task itself and move these into common APIs and move some logic into > the repair coordination its self. > This work relates with CASSANDRA-15399 as special handling each task makes > the work more complex. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org