[jira] [Updated] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture
[ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17199: -- Fix Version/s: 5.0 (was: 5.x) Source Control Link: https://github.com/apache/cassandra/commit/721b6de555352bf0ac3ef7e36f94dc832f41 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Provide summary of failed SessionInfo's in StreamResultFuture > - > > Key: CASSANDRA-17199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17199 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Logging >Reporter: Brendan Cicchi >Assignee: Natnael Adere >Priority: Normal > Labels: AdventCalendar2021, lhf > Fix For: 5.0 > > > Currently, we warn about the presence of one or more failed sessions existing > in the final state and then an operator/user traces back through the logs to > find any failed streams for troubleshooting. > {code:java} > private synchronized void maybeComplete() > { > if (finishedAllSessions()) > { > StreamState finalState = getCurrentState(); > if (finalState.hasFailedSession()) > { > logger.warn("[Stream #{}] Stream failed", planId); > tryFailure(new StreamException(finalState, "Stream failed")); > } > else > { > logger.info("[Stream #{}] All sessions completed", planId); > trySuccess(finalState); > } > } > } {code} > It would be helpful to log out a summary of the SessionInfo for each failed > session since that should be accessible via the StreamState. > > This can be especially helpful for longer streaming operations like bootstrap > where the failure could have been a long time back and all recent streams > leading up to the warning actually are successful. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture
[ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17199: -- Reviewers: David Capwell, Dinesh Joshi, Jon Meredith (was: Jon Meredith) > Provide summary of failed SessionInfo's in StreamResultFuture > - > > Key: CASSANDRA-17199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17199 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Logging >Reporter: Brendan Cicchi >Assignee: Natnael Adere >Priority: Normal > Labels: AdventCalendar2021, lhf > Fix For: 5.x > > > Currently, we warn about the presence of one or more failed sessions existing > in the final state and then an operator/user traces back through the logs to > find any failed streams for troubleshooting. > {code:java} > private synchronized void maybeComplete() > { > if (finishedAllSessions()) > { > StreamState finalState = getCurrentState(); > if (finalState.hasFailedSession()) > { > logger.warn("[Stream #{}] Stream failed", planId); > tryFailure(new StreamException(finalState, "Stream failed")); > } > else > { > logger.info("[Stream #{}] All sessions completed", planId); > trySuccess(finalState); > } > } > } {code} > It would be helpful to log out a summary of the SessionInfo for each failed > session since that should be accessible via the StreamState. > > This can be especially helpful for longer streaming operations like bootstrap > where the failure could have been a long time back and all recent streams > leading up to the warning actually are successful. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture
[ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17199: -- Status: Ready to Commit (was: Review In Progress) 3 +1s (me, Dinesh, Jon) > Provide summary of failed SessionInfo's in StreamResultFuture > - > > Key: CASSANDRA-17199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17199 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Logging >Reporter: Brendan Cicchi >Assignee: Natnael Adere >Priority: Normal > Labels: AdventCalendar2021, lhf > Fix For: 4.0.x > > > Currently, we warn about the presence of one or more failed sessions existing > in the final state and then an operator/user traces back through the logs to > find any failed streams for troubleshooting. > {code:java} > private synchronized void maybeComplete() > { > if (finishedAllSessions()) > { > StreamState finalState = getCurrentState(); > if (finalState.hasFailedSession()) > { > logger.warn("[Stream #{}] Stream failed", planId); > tryFailure(new StreamException(finalState, "Stream failed")); > } > else > { > logger.info("[Stream #{}] All sessions completed", planId); > trySuccess(finalState); > } > } > } {code} > It would be helpful to log out a summary of the SessionInfo for each failed > session since that should be accessible via the StreamState. > > This can be especially helpful for longer streaming operations like bootstrap > where the failure could have been a long time back and all recent streams > leading up to the warning actually are successful. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture
[ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17199: -- Fix Version/s: 5.x (was: 4.0.x) > Provide summary of failed SessionInfo's in StreamResultFuture > - > > Key: CASSANDRA-17199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17199 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Logging >Reporter: Brendan Cicchi >Assignee: Natnael Adere >Priority: Normal > Labels: AdventCalendar2021, lhf > Fix For: 5.x > > > Currently, we warn about the presence of one or more failed sessions existing > in the final state and then an operator/user traces back through the logs to > find any failed streams for troubleshooting. > {code:java} > private synchronized void maybeComplete() > { > if (finishedAllSessions()) > { > StreamState finalState = getCurrentState(); > if (finalState.hasFailedSession()) > { > logger.warn("[Stream #{}] Stream failed", planId); > tryFailure(new StreamException(finalState, "Stream failed")); > } > else > { > logger.info("[Stream #{}] All sessions completed", planId); > trySuccess(finalState); > } > } > } {code} > It would be helpful to log out a summary of the SessionInfo for each failed > session since that should be accessible via the StreamState. > > This can be especially helpful for longer streaming operations like bootstrap > where the failure could have been a long time back and all recent streams > leading up to the warning actually are successful. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture
[ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Meredith updated CASSANDRA-17199: - Reviewers: Jon Meredith Status: Review In Progress (was: Patch Available) > Provide summary of failed SessionInfo's in StreamResultFuture > - > > Key: CASSANDRA-17199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17199 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Logging >Reporter: Brendan Cicchi >Assignee: Natnael Adere >Priority: Normal > Labels: AdventCalendar2021, lhf > Fix For: 4.0.x > > > Currently, we warn about the presence of one or more failed sessions existing > in the final state and then an operator/user traces back through the logs to > find any failed streams for troubleshooting. > {code:java} > private synchronized void maybeComplete() > { > if (finishedAllSessions()) > { > StreamState finalState = getCurrentState(); > if (finalState.hasFailedSession()) > { > logger.warn("[Stream #{}] Stream failed", planId); > tryFailure(new StreamException(finalState, "Stream failed")); > } > else > { > logger.info("[Stream #{}] All sessions completed", planId); > trySuccess(finalState); > } > } > } {code} > It would be helpful to log out a summary of the SessionInfo for each failed > session since that should be accessible via the StreamState. > > This can be especially helpful for longer streaming operations like bootstrap > where the failure could have been a long time back and all recent streams > leading up to the warning actually are successful. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture
[ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-17199: -- Test and Documentation Plan: Circle ci tests passing Status: Patch Available (was: In Progress) Patch for trunk: https://github.com/apache/cassandra/pull/2104 > Provide summary of failed SessionInfo's in StreamResultFuture > - > > Key: CASSANDRA-17199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17199 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Logging >Reporter: Brendan Cicchi >Assignee: Natnael Adere >Priority: Normal > Labels: AdventCalendar2021, lhf > Fix For: 4.0.x > > > Currently, we warn about the presence of one or more failed sessions existing > in the final state and then an operator/user traces back through the logs to > find any failed streams for troubleshooting. > {code:java} > private synchronized void maybeComplete() > { > if (finishedAllSessions()) > { > StreamState finalState = getCurrentState(); > if (finalState.hasFailedSession()) > { > logger.warn("[Stream #{}] Stream failed", planId); > tryFailure(new StreamException(finalState, "Stream failed")); > } > else > { > logger.info("[Stream #{}] All sessions completed", planId); > trySuccess(finalState); > } > } > } {code} > It would be helpful to log out a summary of the SessionInfo for each failed > session since that should be accessible via the StreamState. > > This can be especially helpful for longer streaming operations like bootstrap > where the failure could have been a long time back and all recent streams > leading up to the warning actually are successful. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture
[ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-17199: --- Labels: AdventCalendar2021 lhf (was: AdventCalendar2021 lh) > Provide summary of failed SessionInfo's in StreamResultFuture > - > > Key: CASSANDRA-17199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17199 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Logging >Reporter: Brendan Cicchi >Priority: Normal > Labels: AdventCalendar2021, lhf > Fix For: 4.0.x > > > Currently, we warn about the presence of one or more failed sessions existing > in the final state and then an operator/user traces back through the logs to > find any failed streams for troubleshooting. > {code:java} > private synchronized void maybeComplete() > { > if (finishedAllSessions()) > { > StreamState finalState = getCurrentState(); > if (finalState.hasFailedSession()) > { > logger.warn("[Stream #{}] Stream failed", planId); > tryFailure(new StreamException(finalState, "Stream failed")); > } > else > { > logger.info("[Stream #{}] All sessions completed", planId); > trySuccess(finalState); > } > } > } {code} > It would be helpful to log out a summary of the SessionInfo for each failed > session since that should be accessible via the StreamState. > > This can be especially helpful for longer streaming operations like bootstrap > where the failure could have been a long time back and all recent streams > leading up to the warning actually are successful. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture
[ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-17199: --- Labels: AdventCalendar2021 lh (was: ) > Provide summary of failed SessionInfo's in StreamResultFuture > - > > Key: CASSANDRA-17199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17199 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Logging >Reporter: Brendan Cicchi >Priority: Normal > Labels: AdventCalendar2021, lh > Fix For: 4.0.x > > > Currently, we warn about the presence of one or more failed sessions existing > in the final state and then an operator/user traces back through the logs to > find any failed streams for troubleshooting. > {code:java} > private synchronized void maybeComplete() > { > if (finishedAllSessions()) > { > StreamState finalState = getCurrentState(); > if (finalState.hasFailedSession()) > { > logger.warn("[Stream #{}] Stream failed", planId); > tryFailure(new StreamException(finalState, "Stream failed")); > } > else > { > logger.info("[Stream #{}] All sessions completed", planId); > trySuccess(finalState); > } > } > } {code} > It would be helpful to log out a summary of the SessionInfo for each failed > session since that should be accessible via the StreamState. > > This can be especially helpful for longer streaming operations like bootstrap > where the failure could have been a long time back and all recent streams > leading up to the warning actually are successful. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture
[ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-17199: --- Mentor: Brandon Williams > Provide summary of failed SessionInfo's in StreamResultFuture > - > > Key: CASSANDRA-17199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17199 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Logging >Reporter: Brendan Cicchi >Priority: Normal > Fix For: 4.0.x > > > Currently, we warn about the presence of one or more failed sessions existing > in the final state and then an operator/user traces back through the logs to > find any failed streams for troubleshooting. > {code:java} > private synchronized void maybeComplete() > { > if (finishedAllSessions()) > { > StreamState finalState = getCurrentState(); > if (finalState.hasFailedSession()) > { > logger.warn("[Stream #{}] Stream failed", planId); > tryFailure(new StreamException(finalState, "Stream failed")); > } > else > { > logger.info("[Stream #{}] All sessions completed", planId); > trySuccess(finalState); > } > } > } {code} > It would be helpful to log out a summary of the SessionInfo for each failed > session since that should be accessible via the StreamState. > > This can be especially helpful for longer streaming operations like bootstrap > where the failure could have been a long time back and all recent streams > leading up to the warning actually are successful. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture
[ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17199: - Change Category: Operability Complexity: Low Hanging Fruit Fix Version/s: 4.0.x Status: Open (was: Triage Needed) > Provide summary of failed SessionInfo's in StreamResultFuture > - > > Key: CASSANDRA-17199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17199 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Logging >Reporter: Brendan Cicchi >Priority: Normal > Fix For: 4.0.x > > > Currently, we warn about the presence of one or more failed sessions existing > in the final state and then an operator/user traces back through the logs to > find any failed streams for troubleshooting. > {code:java} > private synchronized void maybeComplete() > { > if (finishedAllSessions()) > { > StreamState finalState = getCurrentState(); > if (finalState.hasFailedSession()) > { > logger.warn("[Stream #{}] Stream failed", planId); > tryFailure(new StreamException(finalState, "Stream failed")); > } > else > { > logger.info("[Stream #{}] All sessions completed", planId); > trySuccess(finalState); > } > } > } {code} > It would be helpful to log out a summary of the SessionInfo for each failed > session since that should be accessible via the StreamState. > > This can be especially helpful for longer streaming operations like bootstrap > where the failure could have been a long time back and all recent streams > leading up to the warning actually are successful. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture
[ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brendan Cicchi updated CASSANDRA-17199: --- Summary: Provide summary of failed SessionInfo's in StreamResultFuture (was: Provide summary of failed SessionInfo's in a failed state StreamResultFuture) > Provide summary of failed SessionInfo's in StreamResultFuture > - > > Key: CASSANDRA-17199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17199 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Logging >Reporter: Brendan Cicchi >Priority: Normal > > Currently, we warn about the presence of one or more failed sessions existing > in the final state and then an operator/user traces back through the logs to > find any failed streams for troubleshooting. > {code:java} > private synchronized void maybeComplete() > { > if (finishedAllSessions()) > { > StreamState finalState = getCurrentState(); > if (finalState.hasFailedSession()) > { > logger.warn("[Stream #{}] Stream failed", planId); > tryFailure(new StreamException(finalState, "Stream failed")); > } > else > { > logger.info("[Stream #{}] All sessions completed", planId); > trySuccess(finalState); > } > } > } {code} > It would be helpful to log out a summary of the SessionInfo for each failed > session since that should be accessible via the StreamState. > > This can be especially helpful for longer streaming operations like bootstrap > where the failure could have been a long time back and all recent streams > leading up to the warning actually are successful. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org