[jira] [Updated] (CASSANDRA-17209) Avoid unecessary array allocations and initializations in RequestValidations

2021-12-20 Thread Benjamin Lerer (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer updated CASSANDRA-17209:
---
  Fix Version/s: 4.1
 (was: 4.x)
Source Control Link: 
https://github.com/apache/cassandra/commit/11952fae774d51d4e268dae506803fef874c8c50
 Resolution: Fixed
 Status: Resolved  (was: Ready to Commit)

Committed into trunk at 11952fae774d51d4e268dae506803fef874c8c50

> Avoid unecessary array allocations and initializations in RequestValidations
> 
>
> Key: CASSANDRA-17209
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17209
> Project: Cassandra
>  Issue Type: Improvement
>  Components: CQL/Interpreter
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.1
>
>
> {{RequestValidations}} methods used extensively varargs. As the array 
> creation is necessary only when the check fail we endup creating most of the 
> time unecessary array. This can easily be avoided by overloading the 
> different methods with a number of message argument from zero to three. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-17209) Avoid unecessary array allocations and initializations in RequestValidations

2021-12-20 Thread Benjamin Lerer (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer updated CASSANDRA-17209:
---
Status: Ready to Commit  (was: Review In Progress)

> Avoid unecessary array allocations and initializations in RequestValidations
> 
>
> Key: CASSANDRA-17209
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17209
> Project: Cassandra
>  Issue Type: Improvement
>  Components: CQL/Interpreter
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.x
>
>
> {{RequestValidations}} methods used extensively varargs. As the array 
> creation is necessary only when the check fail we endup creating most of the 
> time unecessary array. This can easily be avoided by overloading the 
> different methods with a number of message argument from zero to three. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-17209) Avoid unecessary array allocations and initializations in RequestValidations

2021-12-20 Thread Benjamin Lerer (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer updated CASSANDRA-17209:
---
Status: Review In Progress  (was: Patch Available)

> Avoid unecessary array allocations and initializations in RequestValidations
> 
>
> Key: CASSANDRA-17209
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17209
> Project: Cassandra
>  Issue Type: Improvement
>  Components: CQL/Interpreter
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.x
>
>
> {{RequestValidations}} methods used extensively varargs. As the array 
> creation is necessary only when the check fail we endup creating most of the 
> time unecessary array. This can easily be avoided by overloading the 
> different methods with a number of message argument from zero to three. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-17209) Avoid unecessary array allocations and initializations in RequestValidations

2021-12-15 Thread Caleb Rackliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caleb Rackliffe updated CASSANDRA-17209:

Reviewers: Caleb Rackliffe

> Avoid unecessary array allocations and initializations in RequestValidations
> 
>
> Key: CASSANDRA-17209
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17209
> Project: Cassandra
>  Issue Type: Improvement
>  Components: CQL/Interpreter
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.x
>
>
> {{RequestValidations}} methods used extensively varargs. As the array 
> creation is necessary only when the check fail we endup creating most of the 
> time unecessary array. This can easily be avoided by overloading the 
> different methods with a number of message argument from zero to three. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-17209) Avoid unecessary array allocations and initializations in RequestValidations

2021-12-15 Thread Benjamin Lerer (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer updated CASSANDRA-17209:
---
Test and Documentation Plan: No need for new tests
 Status: Patch Available  (was: Open)

> Avoid unecessary array allocations and initializations in RequestValidations
> 
>
> Key: CASSANDRA-17209
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17209
> Project: Cassandra
>  Issue Type: Improvement
>  Components: CQL/Interpreter
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.x
>
>
> {{RequestValidations}} methods used extensively varargs. As the array 
> creation is necessary only when the check fail we endup creating most of the 
> time unecessary array. This can easily be avoided by overloading the 
> different methods with a number of message argument from zero to three. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-17209) Avoid unecessary array allocations and initializations in RequestValidations

2021-12-15 Thread Benjamin Lerer (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer updated CASSANDRA-17209:
---
Change Category: Performance
 Complexity: Low Hanging Fruit
  Fix Version/s: 4.x
 Status: Open  (was: Triage Needed)

> Avoid unecessary array allocations and initializations in RequestValidations
> 
>
> Key: CASSANDRA-17209
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17209
> Project: Cassandra
>  Issue Type: Improvement
>  Components: CQL/Interpreter
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.x
>
>
> {{RequestValidations}} methods used extensively varargs. As the array 
> creation is necessary only when the check fail we endup creating most of the 
> time unecessary array. This can easily be avoided by overloading the 
> different methods with a number of message argument from zero to three. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-17209) Avoid unecessary array allocations and initializations in RequestValidations

2021-12-15 Thread Benjamin Lerer (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer updated CASSANDRA-17209:
---
Summary: Avoid unecessary array allocations and initializations in 
RequestValidations  (was: Avoid unecessary array allocation and initialization 
in RequestValidations)

> Avoid unecessary array allocations and initializations in RequestValidations
> 
>
> Key: CASSANDRA-17209
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17209
> Project: Cassandra
>  Issue Type: Improvement
>  Components: CQL/Interpreter
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
>
> {{RequestValidations}} methods used extensively varargs. As the array 
> creation is necessary only when the check fail we endup creating most of the 
> time unecessary array. This can easily be avoided by overloading the 
> different methods with a number of message argument from zero to three. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org