[jira] [Updated] (CASSANDRA-17239) Race in CompactionExecutorTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Meredith updated CASSANDRA-17239:
-
Fix Version/s: 3.0.26
3.11.12
4.0.2
(was: 3.0.x)
(was: 3.11.x)
(was: 4.0.x)
Since Version: 2.2.11
Source Control Link:
https://github.com/apache/cassandra/commit/7f2c0d7e5f896fa1e466c9e7c1dbf9db9157eea8
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Race in CompactionExecutorTest
> --
>
> Key: CASSANDRA-17239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17239
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 3.0.26, 3.11.12, 4.0.2
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> CompactionExecutorTest has a race between the runnable/callable under test
> completing
> and the {{afterExecute}} method stashing it for the test. Replace the
> wait/sleep loop
> with a {{SimpleCondition}} that is signaled once the test task throwable has
> been recorded.
> This seems fairly hard to hit but has happened on CI. It took about 2600
> iterations on my MacBook to trigger, but you can artificially hit frequently
> by adding a sleep at the start of the afterExecute method.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17239) Race in CompactionExecutorTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh McKenzie updated CASSANDRA-17239:
--
Reviewers: Josh McKenzie
> Race in CompactionExecutorTest
> --
>
> Key: CASSANDRA-17239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17239
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> CompactionExecutorTest has a race between the runnable/callable under test
> completing
> and the {{afterExecute}} method stashing it for the test. Replace the
> wait/sleep loop
> with a {{SimpleCondition}} that is signaled once the test task throwable has
> been recorded.
> This seems fairly hard to hit but has happened on CI. It took about 2600
> iterations on my MacBook to trigger, but you can artificially hit frequently
> by adding a sleep at the start of the afterExecute method.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17239) Race in CompactionExecutorTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh McKenzie updated CASSANDRA-17239:
--
Reviewers: Josh McKenzie, Josh McKenzie (was: Josh McKenzie)
Josh McKenzie, Josh McKenzie (was: Josh McKenzie)
Status: Review In Progress (was: Patch Available)
> Race in CompactionExecutorTest
> --
>
> Key: CASSANDRA-17239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17239
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> CompactionExecutorTest has a race between the runnable/callable under test
> completing
> and the {{afterExecute}} method stashing it for the test. Replace the
> wait/sleep loop
> with a {{SimpleCondition}} that is signaled once the test task throwable has
> been recorded.
> This seems fairly hard to hit but has happened on CI. It took about 2600
> iterations on my MacBook to trigger, but you can artificially hit frequently
> by adding a sleep at the start of the afterExecute method.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17239) Race in CompactionExecutorTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh McKenzie updated CASSANDRA-17239:
--
Status: Ready to Commit (was: Review In Progress)
> Race in CompactionExecutorTest
> --
>
> Key: CASSANDRA-17239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17239
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> CompactionExecutorTest has a race between the runnable/callable under test
> completing
> and the {{afterExecute}} method stashing it for the test. Replace the
> wait/sleep loop
> with a {{SimpleCondition}} that is signaled once the test task throwable has
> been recorded.
> This seems fairly hard to hit but has happened on CI. It took about 2600
> iterations on my MacBook to trigger, but you can artificially hit frequently
> by adding a sleep at the start of the afterExecute method.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17239) Race in CompactionExecutorTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Meredith updated CASSANDRA-17239:
-
Test and Documentation Plan: Run unit test - a lot.
Status: Patch Available (was: Open)
Only affects 3.0/3.11/4.0. The changes made to the test for the simulator solve
the issue by using the {{UncaughtExceptionHandler}}
[3.0 PR|https://github.com/apache/cassandra/pull/1377]
[3.0 branch|https://github.com/jonmeredith/cassandra/tree/C-17239-3.0]
[3.11 branch (minor difference for test
setup|https://github.com/jonmeredith/cassandra/tree/C-17239-3.11)]
[4.0 branch (similar to
3.11)|https://github.com/jonmeredith/cassandra/tree/C-17239-4.0]
> Race in CompactionExecutorTest
> --
>
> Key: CASSANDRA-17239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17239
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> CompactionExecutorTest has a race between the runnable/callable under test
> completing
> and the {{afterExecute}} method stashing it for the test. Replace the
> wait/sleep loop
> with a {{SimpleCondition}} that is signaled once the test task throwable has
> been recorded.
> This seems fairly hard to hit but has happened on CI. It took about 2600
> iterations on my MacBook to trigger, but you can artificially hit frequently
> by adding a sleep at the start of the afterExecute method.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17239) Race in CompactionExecutorTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Meredith updated CASSANDRA-17239:
-
Bug Category: Parent values: Code(13163)
Complexity: Low Hanging Fruit
Discovered By: Unit Test
Fix Version/s: 3.0.x
3.11.x
4.0.x
Severity: Low
Status: Open (was: Triage Needed)
> Race in CompactionExecutorTest
> --
>
> Key: CASSANDRA-17239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17239
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
>
> CompactionExecutorTest has a race between the runnable/callable under test
> completing
> and the {{afterExecute}} method stashing it for the test. Replace the
> wait/sleep loop
> with a {{SimpleCondition}} that is signaled once the test task throwable has
> been recorded.
> This seems fairly hard to hit but has happened on CI. It took about 2600
> iterations on my MacBook to trigger, but you can artificially hit frequently
> by adding a sleep at the start of the afterExecute method.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
