[jira] [Updated] (CASSANDRA-17272) LeveledCompactionStrategy disk space check improvements
[ https://issues.apache.org/jira/browse/CASSANDRA-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-17272: Fix Version/s: 3.0.27 3.11.13 4.1 4.0.4 (was: 3.0.x) (was: 4.x) (was: 3.11.x) (was: 4.0.x) Since Version: 3.0.0 Source Control Link: https://github.com/apache/cassandra/commit/b58a5c86e89e10ad4d39756c5314a756eb18204d Resolution: Fixed Status: Resolved (was: Ready to Commit) and committed, thanks! test results; [3.0|https://app.circleci.com/pipelines/github/krummas/cassandra/782/workflows/9aee2269-1a67-41ff-a088-47ff77eeb82d] [3.11|https://app.circleci.com/pipelines/github/krummas/cassandra/780/workflows/5100c640-aafc-407e-91a3-2e1a9e6d3d3c] [4.0|https://app.circleci.com/pipelines/github/krummas/cassandra/783/workflows/594e1ca2-f346-4c4c-9458-381a32b404e4] [trunk|https://app.circleci.com/pipelines/github/krummas/cassandra/781/workflows/1b908866-deac-47f8-be13-0aedbd36f85b] > LeveledCompactionStrategy disk space check improvements > --- > > Key: CASSANDRA-17272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17272 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction/LCS >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 3.0.27, 3.11.13, 4.1, 4.0.4 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > We currently allow reducing scope (removing sstables from the compaction) > when starting STCS-in-L0 with LCS if the compaction is too large for the > available disk space. We can do the same for L0 -> L1 compactions - but we > can only remove L0 sstables to avoid causing overlap in L1. > Also, in 3.0, when starting an LCS compaction we try to [get a writeable > location|https://github.com/apache/cassandra/blob/b1a8a56c563b85ab9a34d3bbf9c16278dd441157/src/java/org/apache/cassandra/db/compaction/writers/CompactionAwareWriter.java#L128] > where the full result of the compaction will fit - here we should only get a > directory where the first sstable fits, otherwise the compaction might fail > even though there is enough space in total among the data directories -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17272) LeveledCompactionStrategy disk space check improvements
[ https://issues.apache.org/jira/browse/CASSANDRA-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-17272: Status: Ready to Commit (was: Review In Progress) > LeveledCompactionStrategy disk space check improvements > --- > > Key: CASSANDRA-17272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17272 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction/LCS >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > Time Spent: 2h 10m > Remaining Estimate: 0h > > We currently allow reducing scope (removing sstables from the compaction) > when starting STCS-in-L0 with LCS if the compaction is too large for the > available disk space. We can do the same for L0 -> L1 compactions - but we > can only remove L0 sstables to avoid causing overlap in L1. > Also, in 3.0, when starting an LCS compaction we try to [get a writeable > location|https://github.com/apache/cassandra/blob/b1a8a56c563b85ab9a34d3bbf9c16278dd441157/src/java/org/apache/cassandra/db/compaction/writers/CompactionAwareWriter.java#L128] > where the full result of the compaction will fit - here we should only get a > directory where the first sstable fits, otherwise the compaction might fail > even though there is enough space in total among the data directories -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17272) LeveledCompactionStrategy disk space check improvements
[ https://issues.apache.org/jira/browse/CASSANDRA-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-17272: Reviewers: Caleb Rackliffe, Caleb Rackliffe Caleb Rackliffe, Caleb Rackliffe (was: Caleb Rackliffe) Status: Review In Progress (was: Patch Available) > LeveledCompactionStrategy disk space check improvements > --- > > Key: CASSANDRA-17272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17272 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction/LCS >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > > We currently allow reducing scope (removing sstables from the compaction) > when starting STCS-in-L0 with LCS if the compaction is too large for the > available disk space. We can do the same for L0 -> L1 compactions - but we > can only remove L0 sstables to avoid causing overlap in L1. > Also, in 3.0, when starting an LCS compaction we try to [get a writeable > location|https://github.com/apache/cassandra/blob/b1a8a56c563b85ab9a34d3bbf9c16278dd441157/src/java/org/apache/cassandra/db/compaction/writers/CompactionAwareWriter.java#L128] > where the full result of the compaction will fit - here we should only get a > directory where the first sstable fits, otherwise the compaction might fail > even though there is enough space in total among the data directories -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17272) LeveledCompactionStrategy disk space check improvements
[ https://issues.apache.org/jira/browse/CASSANDRA-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-17272: Test and Documentation Plan: cci runs + new unit tests Status: Patch Available (was: Open) > LeveledCompactionStrategy disk space check improvements > --- > > Key: CASSANDRA-17272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17272 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction/LCS >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > > We currently allow reducing scope (removing sstables from the compaction) > when starting STCS-in-L0 with LCS if the compaction is too large for the > available disk space. We can do the same for L0 -> L1 compactions - but we > can only remove L0 sstables to avoid causing overlap in L1. > Also, in 3.0, when starting an LCS compaction we try to [get a writeable > location|https://github.com/apache/cassandra/blob/b1a8a56c563b85ab9a34d3bbf9c16278dd441157/src/java/org/apache/cassandra/db/compaction/writers/CompactionAwareWriter.java#L128] > where the full result of the compaction will fit - here we should only get a > directory where the first sstable fits, otherwise the compaction might fail > even though there is enough space in total among the data directories -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17272) LeveledCompactionStrategy disk space check improvements
[ https://issues.apache.org/jira/browse/CASSANDRA-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-17272: Fix Version/s: 3.0.x 3.11.x 4.0.x 4.x (was: 4.1) (was: 3.0.26) (was: 3.11.12) (was: 4.0.2) > LeveledCompactionStrategy disk space check improvements > --- > > Key: CASSANDRA-17272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17272 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction/LCS >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > > We currently allow reducing scope (removing sstables from the compaction) > when starting STCS-in-L0 with LCS if the compaction is too large for the > available disk space. We can do the same for L0 -> L1 compactions - but we > can only remove L0 sstables to avoid causing overlap in L1. > Also, in 3.0, when starting an LCS compaction we try to [get a writeable > location|https://github.com/apache/cassandra/blob/b1a8a56c563b85ab9a34d3bbf9c16278dd441157/src/java/org/apache/cassandra/db/compaction/writers/CompactionAwareWriter.java#L128] > where the full result of the compaction will fit - here we should only get a > directory where the first sstable fits, otherwise the compaction might fail > even though there is enough space in total among the data directories -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17272) LeveledCompactionStrategy disk space check improvements
[ https://issues.apache.org/jira/browse/CASSANDRA-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-17272: Bug Category: Parent values: Degradation(12984)Level 1 values: Resource Management(12995) Complexity: Low Hanging Fruit Component/s: Local/Compaction/LCS Discovered By: Adhoc Test Fix Version/s: 3.0.26 3.11.12 4.0.2 4.1 Severity: Normal Status: Open (was: Triage Needed) https://github.com/apache/cassandra/pull/1411 https://github.com/apache/cassandra/pull/1412 https://github.com/apache/cassandra/pull/1413 https://app.circleci.com/pipelines/github/krummas/cassandra?branch=marcuse%2Flcs_disk_space https://app.circleci.com/pipelines/github/krummas/cassandra?branch=marcuse%2Flcs_disk_space-3.11 https://app.circleci.com/pipelines/github/krummas/cassandra?branch=marcuse%2Flcs_disk_space-4.0 > LeveledCompactionStrategy disk space check improvements > --- > > Key: CASSANDRA-17272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17272 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction/LCS >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 3.0.26, 3.11.12, 4.0.2, 4.1 > > > We currently allow reducing scope (removing sstables from the compaction) > when starting STCS-in-L0 with LCS if the compaction is too large for the > available disk space. We can do the same for L0 -> L1 compactions - but we > can only remove L0 sstables to avoid causing overlap in L1. > Also, in 3.0, when starting an LCS compaction we try to [get a writeable > location|https://github.com/apache/cassandra/blob/b1a8a56c563b85ab9a34d3bbf9c16278dd441157/src/java/org/apache/cassandra/db/compaction/writers/CompactionAwareWriter.java#L128] > where the full result of the compaction will fit - here we should only get a > directory where the first sstable fits, otherwise the compaction might fail > even though there is enough space in total among the data directories -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
