[jira] [Updated] (CASSANDRA-17532) Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade tests

2022-04-12 Thread Ekaterina Dimitrova (Jira) 


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-17532:

Status: Review In Progress  (was: Needs Committer)

> Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade 
> tests
> -
>
> Key: CASSANDRA-17532
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17532
> Project: Cassandra
>  Issue Type: Task
>  Components: Local/Config
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> We reached lazy consensus on this here:
> [https://lists.apache.org/thread/knxs0p220d6jxgggn53v4o99jnk2qbj0]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-17532) Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade tests

2022-04-12 Thread Ekaterina Dimitrova (Jira) 


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-17532:

Status: Needs Committer  (was: Review In Progress)

> Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade 
> tests
> -
>
> Key: CASSANDRA-17532
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17532
> Project: Cassandra
>  Issue Type: Task
>  Components: Local/Config
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> We reached lazy consensus on this here:
> [https://lists.apache.org/thread/knxs0p220d6jxgggn53v4o99jnk2qbj0]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-17532) Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade tests

2022-04-12 Thread David Capwell (Jira) 


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Capwell updated CASSANDRA-17532:
--
Reviewers: David Capwell
   Status: Review In Progress  (was: Patch Available)

This patch just moves the below from UpgradeCluster to every test

{code}
set(Constants.KEY_DTEST_API_CONFIG_CHECK, false)
{code}

The problem we face is that InstanceConfig on trunk gets configs added that 
make sense on trunk but not older versions; we do not have an ability to 
downgrade configs (if using renamed config, switch to old, or if no old exists 
drop), so this causes all upgrade tests to fail... we added the flag to 
UpgradeCluster due to a lack of versioned config support, so without actually 
adding a ability to deal with versioned configs, we don't get a benefit from 
this patch.

I feel this patch doesn't solve the intent, making our tests safer by checking; 
as the tests still don't check they are just more verbose.

I am +0, I am not a fan but if others want this I will not stand in the way

> Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade 
> tests
> -
>
> Key: CASSANDRA-17532
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17532
> Project: Cassandra
>  Issue Type: Task
>  Components: Local/Config
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> We reached lazy consensus on this here:
> [https://lists.apache.org/thread/knxs0p220d6jxgggn53v4o99jnk2qbj0]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-17532) Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade tests

2022-04-11 Thread Ekaterina Dimitrova (Jira) 


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-17532:

Test and Documentation Plan: 
 [3.0|https://github.com/ekaterinadimitrova2/cassandra/pull/195]. [3.0 CI 
run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1501/workflows/d0128467-3ef8-446a-8b49-9bfc4b0238b5/jobs/9757]
 

[3.11|https://github.com/ekaterinadimitrova2/cassandra/pull/196]  [3.11 CI 
run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1513/workflows/c3b751d5-c3f4-40d4-8397-651aa5da446e]

 [4.0|https://github.com/ekaterinadimitrova2/cassandra/pull/197]. [4.0 CI 
run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1512/workflows/735dec78-3e1c-45c0-9e48-a2dcd5bfdc1f]

[trunk|https://github.com/ekaterinadimitrova2/cassandra/pull/198] [trunk CI 
run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1522/workflows/6f1e9d0a-fcee-41e6-b09c-e59930a41c59]

The current tests plus ran in a loop two flaky tests to confirm I didn't 
introduce new issues with this patch. More info in the comments
 Status: Patch Available  (was: In Progress)

> Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade 
> tests
> -
>
> Key: CASSANDRA-17532
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17532
> Project: Cassandra
>  Issue Type: Task
>  Components: Local/Config
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> We reached lazy consensus on this here:
> [https://lists.apache.org/thread/knxs0p220d6jxgggn53v4o99jnk2qbj0]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-17532) Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade tests

2022-04-06 Thread Ekaterina Dimitrova (Jira) 


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-17532:

Summary: Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for 
in-jvm upgrade tests  (was: Make Constants.KEY_DTEST_API_CONFIG_CHECK=true by 
default for in-jvm upgrade tests)

> Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade 
> tests
> -
>
> Key: CASSANDRA-17532
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17532
> Project: Cassandra
>  Issue Type: Task
>  Components: Local/Config
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> It seems we reached lazy consensus on this here:
> https://lists.apache.org/thread/knxs0p220d6jxgggn53v4o99jnk2qbj0



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-17532) Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade tests

2022-04-06 Thread Ekaterina Dimitrova (Jira) 


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-17532:

Description: 
We reached lazy consensus on this here:

[https://lists.apache.org/thread/knxs0p220d6jxgggn53v4o99jnk2qbj0]

  was:
It seems we reached lazy consensus on this here:

https://lists.apache.org/thread/knxs0p220d6jxgggn53v4o99jnk2qbj0


> Set Constants.KEY_DTEST_API_CONFIG_CHECK=true by default for in-jvm upgrade 
> tests
> -
>
> Key: CASSANDRA-17532
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17532
> Project: Cassandra
>  Issue Type: Task
>  Components: Local/Config
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> We reached lazy consensus on this here:
> [https://lists.apache.org/thread/knxs0p220d6jxgggn53v4o99jnk2qbj0]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org