[jira] [Updated] (CASSANDRA-17731) Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-17731:
--
Fix Version/s: 4.1-beta1
(was: 4.1)
> Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for
> in-JVM dtests
> ---
>
> Key: CASSANDRA-17731
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17731
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.6, 4.1-beta1, 4.2
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> There appear to be two problems w/ the way we shut down
> {{ScheduledExecutors}} in Instance in 4.0+:
> 1.) We do it twice, Ince as part of a larger batch of shutdown activity, and
> then again in its own {{parallelRun()}} block.
> 2.) It happens before {{MessagingService}} shuts down, but some
> messaging-related threads (see {{StreamSession#closeSession()}}) can submit
> tasks to {{nonPeriodicTasks}}.
> We should do it once, and do it after the {{MessagingService}} has properly
> shut down.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17731) Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-17731:
---
Fix Version/s: 4.0.6
4.1
4.2
(was: 4.x)
(was: 4.0.x)
(was: 4.1.x)
> Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for
> in-JVM dtests
> ---
>
> Key: CASSANDRA-17731
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17731
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.6, 4.1, 4.2
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> There appear to be two problems w/ the way we shut down
> {{ScheduledExecutors}} in Instance in 4.0+:
> 1.) We do it twice, Ince as part of a larger batch of shutdown activity, and
> then again in its own {{parallelRun()}} block.
> 2.) It happens before {{MessagingService}} shuts down, but some
> messaging-related threads (see {{StreamSession#closeSession()}}) can submit
> tasks to {{nonPeriodicTasks}}.
> We should do it once, and do it after the {{MessagingService}} has properly
> shut down.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17731) Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-17731:
Since Version: 4.0
Source Control Link:
https://github.com/apache/cassandra/commit/d51f90201b2d127166612384a75b4a49da9776d1
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed.
4.0 -
[https://github.com/apache/cassandra/commit/d51f90201b2d127166612384a75b4a49da9776d1]
4.1 -
[https://github.com/apache/cassandra/commit/9bd32771e3983efdb0b135699a036c91e89b52dd]
trunk -
https://github.com/apache/cassandra/commit/889ca60edc8afd85b4a594442883c1b5efdf3c6b
> Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for
> in-JVM dtests
> ---
>
> Key: CASSANDRA-17731
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17731
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> There appear to be two problems w/ the way we shut down
> {{ScheduledExecutors}} in Instance in 4.0+:
> 1.) We do it twice, Ince as part of a larger batch of shutdown activity, and
> then again in its own {{parallelRun()}} block.
> 2.) It happens before {{MessagingService}} shuts down, but some
> messaging-related threads (see {{StreamSession#closeSession()}}) can submit
> tasks to {{nonPeriodicTasks}}.
> We should do it once, and do it after the {{MessagingService}} has properly
> shut down.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17731) Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-17731:
--
Status: Ready to Commit (was: Review In Progress)
> Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for
> in-JVM dtests
> ---
>
> Key: CASSANDRA-17731
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17731
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> There appear to be two problems w/ the way we shut down
> {{ScheduledExecutors}} in Instance in 4.0+:
> 1.) We do it twice, Ince as part of a larger batch of shutdown activity, and
> then again in its own {{parallelRun()}} block.
> 2.) It happens before {{MessagingService}} shuts down, but some
> messaging-related threads (see {{StreamSession#closeSession()}}) can submit
> tasks to {{nonPeriodicTasks}}.
> We should do it once, and do it after the {{MessagingService}} has properly
> shut down.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17731) Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-17731:
--
Reviewers: David Capwell, David Capwell (was: David Capwell)
David Capwell, David Capwell (was: David Capwell)
Status: Review In Progress (was: Patch Available)
> Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for
> in-JVM dtests
> ---
>
> Key: CASSANDRA-17731
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17731
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> There appear to be two problems w/ the way we shut down
> {{ScheduledExecutors}} in Instance in 4.0+:
> 1.) We do it twice, Ince as part of a larger batch of shutdown activity, and
> then again in its own {{parallelRun()}} block.
> 2.) It happens before {{MessagingService}} shuts down, but some
> messaging-related threads (see {{StreamSession#closeSession()}}) can submit
> tasks to {{nonPeriodicTasks}}.
> We should do it once, and do it after the {{MessagingService}} has properly
> shut down.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17731) Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-17731:
Test and Documentation Plan: n/a (the patch itself is test fixes)
Status: Patch Available (was: In Progress)
Here are the patches and test runs:
|4.0|[patch|https://github.com/apache/cassandra/pull/1724]|[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-17731-4.0]|
|4.1|[patch|https://github.com/apache/cassandra/pull/1726]|[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-17731-4.1]|
|trunk|[patch|https://github.com/apache/cassandra/pull/1728]|[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-17731-trunk]|
> Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for
> in-JVM dtests
> ---
>
> Key: CASSANDRA-17731
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17731
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> There appear to be two problems w/ the way we shut down
> {{ScheduledExecutors}} in Instance in 4.0+:
> 1.) We do it twice, Ince as part of a larger batch of shutdown activity, and
> then again in its own {{parallelRun()}} block.
> 2.) It happens before {{MessagingService}} shuts down, but some
> messaging-related threads (see {{StreamSession#closeSession()}}) can submit
> tasks to {{nonPeriodicTasks}}.
> We should do it once, and do it after the {{MessagingService}} has properly
> shut down.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17731) Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-17731:
Reviewers: David Capwell
> Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for
> in-JVM dtests
> ---
>
> Key: CASSANDRA-17731
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17731
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There appear to be two problems w/ the way we shut down
> {{ScheduledExecutors}} in Instance in 4.0+:
> 1.) We do it twice, Ince as part of a larger batch of shutdown activity, and
> then again in its own {{parallelRun()}} block.
> 2.) It happens before {{MessagingService}} shuts down, but some
> messaging-related threads (see {{StreamSession#closeSession()}}) can submit
> tasks to {{nonPeriodicTasks}}.
> We should do it once, and do it after the {{MessagingService}} has properly
> shut down.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17731) Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-17731:
Summary: Clean up ScheduledExecutors, CommitLog, and MessagingService
shutdown for in-JVM dtests (was: Clean up ScheduledExecutors shutdown for
in-JVM dtests)
> Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for
> in-JVM dtests
> ---
>
> Key: CASSANDRA-17731
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17731
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
>
> There appear to be two problems w/ the way we shut down
> {{ScheduledExecutors}} in Instance in 4.0+:
> 1.) We do it twice, Ince as part of a larger batch of shutdown activity, and
> then again in its own {{parallelRun()}} block.
> 2.) It happens before {{MessagingService}} shuts down, but some
> messaging-related threads (see {{StreamSession#closeSession()}}) can submit
> tasks to {{nonPeriodicTasks}}.
> We should do it once, and do it after the {{MessagingService}} has properly
> shut down.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
