[jira] [Updated] (CASSANDRA-18152) mockito-inline causes tests to fail beacause o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean
[ https://issues.apache.org/jira/browse/CASSANDRA-18152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18152: -- Since Version: 4.0-alpha4 Source Control Link: https://github.com/apache/cassandra/commit/36a99bcdcc65eb2b3bb708f67e1bd75d35359f7f Resolution: Fixed Status: Resolved (was: Ready to Commit) > mockito-inline causes tests to fail beacause > o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean > --- > > Key: CASSANDRA-18152 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18152 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.2 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > While working on CASSANDRA-14361, when we included mockito-inline into the > build to test the new functionality, unrelated tests in CI started to fail. > (1) > This is happening because mockito, together with stuff which enables static > mocking, just does not play together with our way of doing things in dtest > framework. > The workaround is consisting of removing Mockito from InternalNodeProbe, it > tries to spy on StorageService to not send any notifications back. This might > be workarounded so we do not need Mockito hence tests are fixed and mocking > of static methods is possible without any other tests failing. > (1) > https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2168/#showFailuresLink > see also: [https://github.com/mockito/mockito/issues/2203] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18152) mockito-inline causes tests to fail beacause o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean
[ https://issues.apache.org/jira/browse/CASSANDRA-18152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18152: -- Fix Version/s: 4.2 (was: 4.x) > mockito-inline causes tests to fail beacause > o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean > --- > > Key: CASSANDRA-18152 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18152 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.2 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > While working on CASSANDRA-14361, when we included mockito-inline into the > build to test the new functionality, unrelated tests in CI started to fail. > (1) > This is happening because mockito, together with stuff which enables static > mocking, just does not play together with our way of doing things in dtest > framework. > The workaround is consisting of removing Mockito from InternalNodeProbe, it > tries to spy on StorageService to not send any notifications back. This might > be workarounded so we do not need Mockito hence tests are fixed and mocking > of static methods is possible without any other tests failing. > (1) > https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2168/#showFailuresLink > see also: [https://github.com/mockito/mockito/issues/2203] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18152) mockito-inline causes tests to fail beacause o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean
[ https://issues.apache.org/jira/browse/CASSANDRA-18152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18152: -- Reviewers: Andres de la Peña, Stefan Miklosovic (was: Andres de la Peña) Status: Review In Progress (was: Patch Available) > mockito-inline causes tests to fail beacause > o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean > --- > > Key: CASSANDRA-18152 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18152 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 3h 50m > Remaining Estimate: 0h > > While working on CASSANDRA-14361, when we included mockito-inline into the > build to test the new functionality, unrelated tests in CI started to fail. > (1) > This is happening because mockito, together with stuff which enables static > mocking, just does not play together with our way of doing things in dtest > framework. > The workaround is consisting of removing Mockito from InternalNodeProbe, it > tries to spy on StorageService to not send any notifications back. This might > be workarounded so we do not need Mockito hence tests are fixed and mocking > of static methods is possible without any other tests failing. > (1) > https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2168/#showFailuresLink > see also: [https://github.com/mockito/mockito/issues/2203] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18152) mockito-inline causes tests to fail beacause o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean
[ https://issues.apache.org/jira/browse/CASSANDRA-18152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18152: -- Status: Ready to Commit (was: Review In Progress) > mockito-inline causes tests to fail beacause > o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean > --- > > Key: CASSANDRA-18152 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18152 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 3h 50m > Remaining Estimate: 0h > > While working on CASSANDRA-14361, when we included mockito-inline into the > build to test the new functionality, unrelated tests in CI started to fail. > (1) > This is happening because mockito, together with stuff which enables static > mocking, just does not play together with our way of doing things in dtest > framework. > The workaround is consisting of removing Mockito from InternalNodeProbe, it > tries to spy on StorageService to not send any notifications back. This might > be workarounded so we do not need Mockito hence tests are fixed and mocking > of static methods is possible without any other tests failing. > (1) > https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2168/#showFailuresLink > see also: [https://github.com/mockito/mockito/issues/2203] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18152) mockito-inline causes tests to fail beacause o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean
[ https://issues.apache.org/jira/browse/CASSANDRA-18152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18152: -- Reviewers: Andres de la Peña > mockito-inline causes tests to fail beacause > o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean > --- > > Key: CASSANDRA-18152 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18152 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > While working on CASSANDRA-14361, when we included mockito-inline into the > build to test the new functionality, unrelated tests in CI started to fail. > (1) > This is happening because mockito, together with stuff which enables static > mocking, just does not play together with our way of doing things in dtest > framework. > The workaround is consisting of removing Mockito from InternalNodeProbe, it > tries to spy on StorageService to not send any notifications back. This might > be workarounded so we do not need Mockito hence tests are fixed and mocking > of static methods is possible without any other tests failing. > (1) > https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2168/#showFailuresLink > see also: [https://github.com/mockito/mockito/issues/2203] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18152) mockito-inline causes tests to fail beacause o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean
[ https://issues.apache.org/jira/browse/CASSANDRA-18152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18152: -- Test and Documentation Plan: CI passes Status: Patch Available (was: In Progress) PR: https://github.com/apache/cassandra/pull/2095 https://app.circleci.com/pipelines/github/instaclustr/cassandra?branch=CASSANDRA-18152 > mockito-inline causes tests to fail beacause > o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean > --- > > Key: CASSANDRA-18152 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18152 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > While working on CASSANDRA-14361, when we included mockito-inline into the > build to test the new functionality, unrelated tests in CI started to fail. > (1) > This is happening because mockito, together with stuff which enables static > mocking, just does not play together with our way of doing things in dtest > framework. > The workaround is consisting of removing Mockito from InternalNodeProbe, it > tries to spy on StorageService to not send any notifications back. This might > be workarounded so we do not need Mockito hence tests are fixed and mocking > of static methods is possible without any other tests failing. > (1) > https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2168/#showFailuresLink > see also: [https://github.com/mockito/mockito/issues/2203] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18152) mockito-inline causes tests to fail beacause o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean
[ https://issues.apache.org/jira/browse/CASSANDRA-18152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18152: -- Bug Category: Parent values: Code(13163) Complexity: Normal Component/s: Test/dtest/java Discovered By: Adhoc Test Fix Version/s: 4.x Severity: Low Assignee: Stefan Miklosovic Status: Open (was: Triage Needed) > mockito-inline causes tests to fail beacause > o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean > --- > > Key: CASSANDRA-18152 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18152 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > > While working on CASSANDRA-14361, when we included mockito-inline into the > build to test the new functionality, unrelated tests in CI started to fail. > (1) > This is happening because mockito, together with stuff which enables static > mocking, just does not play together with our way of doing things in dtest > framework. > The workaround is consisting of removing Mockito from InternalNodeProbe, it > tries to spy on StorageService to not send any notifications back. This might > be workarounded so we do not need Mockito hence tests are fixed and mocking > of static methods is possible without any other tests failing. > (1) > https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2168/#showFailuresLink > see also: [https://github.com/mockito/mockito/issues/2203] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org