[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-18212: -- Fix Version/s: 4.2 Source Control Link: https://github.com/apache/cassandra/commit/35f8da66f9b05d18b4177f8d2e1b86c772ad2221 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Local Write-Read Paths >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Fix For: 4.2 > > Attachments: DiskBased.png, allocations-after.html, > allocations-before.html > > Time Spent: 2.5h > Remaining Estimate: 0h > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-18212: -- Status: Ready to Commit (was: Review In Progress) > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Local Write-Read Paths >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: DiskBased.png, allocations-after.html, > allocations-before.html > > Time Spent: 2.5h > Remaining Estimate: 0h > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-18212: -- Reviewers: Benedict Elliott Smith, David Capwell (was: David Capwell) Status: Review In Progress (was: Patch Available) > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Local Write-Read Paths >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: DiskBased.png, allocations-after.html, > allocations-before.html > > Time Spent: 2.5h > Remaining Estimate: 0h > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-18212: -- Attachment: (was: MemoryBased.png) > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Local Write-Read Paths >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: DiskBased.png, allocations-after.html, > allocations-before.html > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-18212: -- Test and Documentation Plan: Performance testing and circle ci testing done Status: Patch Available (was: In Progress) Patch: [https://github.com/apache/cassandra/pull/2122] CircleCi: [https://app.circleci.com/pipelines/github/NateAdere/cassandra?branch=CASSANDRA-18212-trunk] > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Local Write-Read Paths >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: DiskBased.png, MemoryBased.png, allocations-after.html, > allocations-before.html > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-18212: -- Attachment: allocations-after.html allocations-before.html > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Local Write-Read Paths >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: DiskBased.png, MemoryBased.png, allocations-after.html, > allocations-before.html > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-18212: -- Change Category: Performance Complexity: Low Hanging Fruit Component/s: Legacy/Local Write-Read Paths Reviewers: David Capwell Status: Open (was: Triage Needed) > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Local Write-Read Paths >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: DiskBased.png, MemoryBased.png > > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-18212: -- Attachment: DiskBased.png > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: DiskBased.png, MemoryBased.png > > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-18212: -- Attachment: (was: DiskBased.html) > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: MemoryBased.png > > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-18212: -- Attachment: DiskBased.html > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: DiskBased.html, MemoryBased.png > > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-18212: -- Description: Currently, org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% of memory allocations in production. No changes have been made to reduce this but there is discussion related to the issue in CASSANDRA-13741. Attached below are the performance result for disk based queries and mostly memory based queries. (was: Currently, org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% of memory allocations in production. No changes have been made to reduce this but there is discussion related to the issue in CASSANDRA-13741.) > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: MemoryBased.png > > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-18212: -- Attachment: (was: Screenshot 2023-01-06 at 1.49.26 PM.png) > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: MemoryBased.png > > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-18212: -- Attachment: MemoryBased.png > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: MemoryBased.png > > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. Attached > below are the performance result for disk based queries and mostly memory > based queries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-18212: -- Labels: (was: low-hanging-fruit) > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Attachments: Screenshot 2023-01-06 at 1.49.26 PM.png > > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
[ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natnael Adere updated CASSANDRA-18212: -- Labels: low-hanging-fruit (was: ) > Reduce memory allocations of calls to ByteBufer.duplicate() made in > org.apache.cassandra.transport.CBUtil#writeValue > > > Key: CASSANDRA-18212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18212 > Project: Cassandra > Issue Type: Improvement >Reporter: Natnael Adere >Assignee: Natnael Adere >Priority: Normal > Labels: low-hanging-fruit > Attachments: Screenshot 2023-01-06 at 1.49.26 PM.png > > > Currently, > org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, > io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% > of memory allocations in production. No changes have been made to reduce this > but there is discussion related to the issue in CASSANDRA-13741. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
