[jira] [Updated] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)

2023-06-18 Thread Ekaterina Dimitrova (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-18239:

Description: 
Eclipse warnings is used for static code analysis. However, it does not fit 
well into Cassandra code and practically we end up explicitly adding 
suppressions in many places just to satisfy that tool rather than fix the real 
issues.

This is an incomplete list of reasons to remove it:
 - not closed resources are detected incorrectly
 - does not recognize custom utility methods used to close the resources, which 
use use heavily in the code, like {{{}Throwables.close{}}}, 
{{{}FileUtils.close{}}}, {{{}closeQuietly{}}}...
 - because of the above, we cannot make important things like {{Ref}} to 
implement {{Closeable}} as it would make the tool to explode with tons of 
warnings
 - it complains about correct generics - something like "method X is not 
applicable for ..." when the code compiles successfully is not acceptable
 - it is old and not maintained

There are better tools like IntelliJ inspections for example, which can also be 
run in headless mode

As agreed on the [dev mailing 
list|https://lists.apache.org/thread/8ok01odwx79crxw45cnfh0n1j4nsf9cp] we will 
replace it in trunk with CheckerFramework.

  was:
Eclipse warnings is used for static code analysis. However, it does not fit 
well into Cassandra code and practically we end up explicitly adding 
suppressions in many places just to satisfy that tool rather than fix the real 
issues.

This is an incomplete list of reasons to remove it:
- not closed resources are detected incorrectly
- does not recognize custom utility methods used to close the resources, which 
use use heavily in the code, like {{Throwables.close}}, {{FileUtils.close}}, 
{{closeQuietly}}...
- because of the above, we cannot make important things like {{Ref}} to 
implement {{Closeable}} as it would make the tool to explode with tons of 
warnings
- it complains about correct generics - something like "method X is not 
applicable for ..." when the code compiles successfully is not acceptable
- it is old and not maintained

There are better tools like IntelliJ inspections for example, which can also be 
run in headless mode



> Replace eclipse warnings based static code analysis with something better 
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.x
>
>
> Eclipse warnings is used for static code analysis. However, it does not fit 
> well into Cassandra code and practically we end up explicitly adding 
> suppressions in many places just to satisfy that tool rather than fix the 
> real issues.
> This is an incomplete list of reasons to remove it:
>  - not closed resources are detected incorrectly
>  - does not recognize custom utility methods used to close the resources, 
> which use use heavily in the code, like {{{}Throwables.close{}}}, 
> {{{}FileUtils.close{}}}, {{{}closeQuietly{}}}...
>  - because of the above, we cannot make important things like {{Ref}} to 
> implement {{Closeable}} as it would make the tool to explode with tons of 
> warnings
>  - it complains about correct generics - something like "method X is not 
> applicable for ..." when the code compiles successfully is not acceptable
>  - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also 
> be run in headless mode
> As agreed on the [dev mailing 
> list|https://lists.apache.org/thread/8ok01odwx79crxw45cnfh0n1j4nsf9cp] we 
> will replace it in trunk with CheckerFramework.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)

2023-06-18 Thread Ekaterina Dimitrova (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-18239:

Change Category: Quality Assurance
 Complexity: Normal
 Status: Open  (was: Triage Needed)

> Replace eclipse warnings based static code analysis with something better 
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit 
> well into Cassandra code and practically we end up explicitly adding 
> suppressions in many places just to satisfy that tool rather than fix the 
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources, 
> which use use heavily in the code, like {{Throwables.close}}, 
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to 
> implement {{Closeable}} as it would make the tool to explode with tons of 
> warnings
> - it complains about correct generics - something like "method X is not 
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also 
> be run in headless mode



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)

2023-06-18 Thread Ekaterina Dimitrova (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-18239:

Fix Version/s: 5.x

> Replace eclipse warnings based static code analysis with something better 
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.x
>
>
> Eclipse warnings is used for static code analysis. However, it does not fit 
> well into Cassandra code and practically we end up explicitly adding 
> suppressions in many places just to satisfy that tool rather than fix the 
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources, 
> which use use heavily in the code, like {{Throwables.close}}, 
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to 
> implement {{Closeable}} as it would make the tool to explode with tons of 
> warnings
> - it complains about correct generics - something like "method X is not 
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also 
> be run in headless mode



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)

2023-03-09 Thread Maxim Muzafarov (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxim Muzafarov updated CASSANDRA-18239:

Epic Link: CASSANDRA-18090

> Replace eclipse warnings based static code analysis with something better 
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit 
> well into Cassandra code and practically we end up explicitly adding 
> suppressions in many places just to satisfy that tool rather than fix the 
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources, 
> which use use heavily in the code, like {{Throwables.close}}, 
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to 
> implement {{Closeable}} as it would make the tool to explode with tons of 
> warnings
> - it complains about correct generics - something like "method X is not 
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also 
> be run in headless mode



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)

2023-02-13 Thread Jacek Lewandowski (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacek Lewandowski updated CASSANDRA-18239:
--
Summary: Replace eclipse warnings based static code analysis with something 
better (Sonar)  (was: Remove eclipse warnings task and replace it with 
something better)

> Replace eclipse warnings based static code analysis with something better 
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit 
> well into Cassandra code and practically we end up explicitly adding 
> suppressions in many places just to satisfy that tool rather than fix the 
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources, 
> which use use heavily in the code, like {{Throwables.close}}, 
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to 
> implement {{Closeable}} as it would make the tool to explode with tons of 
> warnings
> - it complains about correct generics - something like "method X is not 
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also 
> be run in headless mode



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org