[jira] [Updated] (CASSANDRA-18311) BufferPool incorrectly counts memoryInUse when putUnusedPortion is used
[ https://issues.apache.org/jira/browse/CASSANDRA-18311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18311: -- Fix Version/s: 4.0.9 4.1.1 (was: 4.0.x) (was: 4.1.x) Since Version: 4.0 Source Control Link: https://github.com/apache/cassandra/commit/3cfb2221223a7631f116108aec0a45646e775705 Resolution: Fixed Status: Resolved (was: Ready to Commit) > BufferPool incorrectly counts memoryInUse when putUnusedPortion is used > --- > > Key: CASSANDRA-18311 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18311 > Project: Cassandra > Issue Type: Bug > Components: Local/Caching >Reporter: Jaroslaw Grabowski >Assignee: Jaroslaw Grabowski >Priority: Normal > Fix For: 4.0.9, 4.1.1, 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The counter is incorrectly decremented by the size of the unused portion of > the provided buffer. > It should be decremented by the number of bytes actually returned to the pool > (that may be different than "size"). The number should be calculated as a > difference between original and resulting buffer capacity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18311) BufferPool incorrectly counts memoryInUse when putUnusedPortion is used
[ https://issues.apache.org/jira/browse/CASSANDRA-18311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18311: -- Reviewers: Jacek Lewandowski, Jacek Lewandowski (was: Jacek Lewandowski) Jacek Lewandowski, Jacek Lewandowski (was: Jacek Lewandowski) Status: Review In Progress (was: Patch Available) > BufferPool incorrectly counts memoryInUse when putUnusedPortion is used > --- > > Key: CASSANDRA-18311 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18311 > Project: Cassandra > Issue Type: Bug > Components: Local/Caching >Reporter: Jaroslaw Grabowski >Assignee: Jaroslaw Grabowski >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The counter is incorrectly decremented by the size of the unused portion of > the provided buffer. > It should be decremented by the number of bytes actually returned to the pool > (that may be different than "size"). The number should be calculated as a > difference between original and resulting buffer capacity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18311) BufferPool incorrectly counts memoryInUse when putUnusedPortion is used
[ https://issues.apache.org/jira/browse/CASSANDRA-18311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18311: -- Status: Ready to Commit (was: Review In Progress) > BufferPool incorrectly counts memoryInUse when putUnusedPortion is used > --- > > Key: CASSANDRA-18311 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18311 > Project: Cassandra > Issue Type: Bug > Components: Local/Caching >Reporter: Jaroslaw Grabowski >Assignee: Jaroslaw Grabowski >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The counter is incorrectly decremented by the size of the unused portion of > the provided buffer. > It should be decremented by the number of bytes actually returned to the pool > (that may be different than "size"). The number should be calculated as a > difference between original and resulting buffer capacity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18311) BufferPool incorrectly counts memoryInUse when putUnusedPortion is used
[ https://issues.apache.org/jira/browse/CASSANDRA-18311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18311: -- Test and Documentation Plan: regression tests + new test Status: Patch Available (was: Open) > BufferPool incorrectly counts memoryInUse when putUnusedPortion is used > --- > > Key: CASSANDRA-18311 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18311 > Project: Cassandra > Issue Type: Bug > Components: Local/Caching >Reporter: Jaroslaw Grabowski >Assignee: Jaroslaw Grabowski >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The counter is incorrectly decremented by the size of the unused portion of > the provided buffer. > It should be decremented by the number of bytes actually returned to the pool > (that may be different than "size"). The number should be calculated as a > difference between original and resulting buffer capacity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18311) BufferPool incorrectly counts memoryInUse when putUnusedPortion is used
[ https://issues.apache.org/jira/browse/CASSANDRA-18311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18311: -- Bug Category: Parent values: Correctness(12982) Complexity: Low Hanging Fruit Component/s: Local/Caching Discovered By: User Report Fix Version/s: 4.0.x 4.1.x 5.0 Severity: Low Status: Open (was: Triage Needed) +1, thanks for the patch > BufferPool incorrectly counts memoryInUse when putUnusedPortion is used > --- > > Key: CASSANDRA-18311 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18311 > Project: Cassandra > Issue Type: Bug > Components: Local/Caching >Reporter: Jaroslaw Grabowski >Assignee: Jaroslaw Grabowski >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The counter is incorrectly decremented by the size of the unused portion of > the provided buffer. > It should be decremented by the number of bytes actually returned to the pool > (that may be different than "size"). The number should be calculated as a > difference between original and resulting buffer capacity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18311) BufferPool incorrectly counts memoryInUse when putUnusedPortion is used
[ https://issues.apache.org/jira/browse/CASSANDRA-18311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaroslaw Grabowski updated CASSANDRA-18311: --- Summary: BufferPool incorrectly counts memoryInUse when putUnusedPortion is used (was: BufferPool incorectly counts memoryInUse when putUnusedPortion is used) > BufferPool incorrectly counts memoryInUse when putUnusedPortion is used > --- > > Key: CASSANDRA-18311 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18311 > Project: Cassandra > Issue Type: Bug >Reporter: Jaroslaw Grabowski >Assignee: Jaroslaw Grabowski >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > The counter is incorrectly decremented by the size of the unused portion of > the provided buffer. > It should be decremented by the number of bytes actually returned to the pool > (that may be different than "size"). The number should be calculated as a > difference between original and resulting buffer capacity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
