[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-18317:
Fix Version/s: 4.0.12
Since Version: 4.0
Source Control Link:
https://github.com/apache/cassandra/commit/26c374da4f03e4a6b64e414805cd92f3eb0a36c6
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed to 4.0 with [26c374da4f03e4a6b64e414805cd92f3eb0a36c6
|https://github.com/apache/cassandra/commit/26c374da4f03e4a6b64e414805cd92f3eb0a36c6],
and merged up to
[4.1|https://github.com/apache/cassandra/commit/26c374da4f03e4a6b64e414805cd92f3eb0a36c6],
[5.0|https://github.com/apache/cassandra/commit/8b941a6bdc826207e18a08c09e2ee4166f6e6d0d]
and
[trunk|https://github.com/apache/cassandra/commit/4b84c4332c3043b31fd33c4d8dc2d7f2771c90da].
Not specifying fix versions above 4.0.x since this is a testonly commit for
those branches.
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Fix For: 4.0.12
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-18317:
Status: Ready to Commit (was: Review In Progress)
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-18317:
Status: Review In Progress (was: Needs Committer)
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-18317:
Status: Patch Available (was: Needs Committer)
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-18317:
Status: Needs Committer (was: Patch Available)
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxwell Guo updated CASSANDRA-18317:
Reviewers: Alex Petrov, Maxwell Guo, Yifan Cai (was: Alex Petrov, Yifan
Cai)
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxwell Guo updated CASSANDRA-18317:
Status: Needs Committer (was: Review In Progress)
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-18317:
Reviewers: Alex Petrov, Yifan Cai (was: Yifan Cai)
Status: Review In Progress (was: Needs Committer)
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRA-18317:
---
Status: Needs Committer (was: Patch Available)
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRA-18317:
---
Test and Documentation Plan: Added unit tests that surface the issue.
Status: Patch Available (was: In Progress)
The issue seems to be resolved in trunk, I've added a PR against trunk with
only the unit tests, but it is still desirable to fix this in 4.0 and 4.1
PR (trunk) : https://github.com/apache/cassandra/pull/2207
CI (trunk) : https://app.circleci.com/pipelines/github/frankgh/cassandra/119
PR (4.0) : https://github.com/apache/cassandra/pull/2208
CI (4.0) : https://app.circleci.com/pipelines/github/frankgh/cassandra/118
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRA-18317:
---
Bug Category: Parent values: Correctness(12982)Level 1 values:
Unrecoverable Corruption / Loss(13161)
Complexity: Low Hanging Fruit
Discovered By: User Report
Reviewers: Yifan Cai
Severity: Normal
Status: Open (was: Triage Needed)
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
