[jira] [Updated] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18955: -- Status: Ready to Commit (was: Review In Progress) > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.x > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18955: -- Fix Version/s: 5.0-alpha2 5.1 (was: 5.x) Since Version: NA Source Control Link: https://github.com/apache/cassandra/commit/0c7410a9da1281dd4f7a70a0668903ebb61bda58 Resolution: Fixed Status: Resolved (was: Ready to Commit) > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.0-alpha2, 5.1 > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18955: -- Reviewers: Brandon Williams, Stefan Miklosovic (was: Brandon Williams) Status: Review In Progress (was: Needs Committer) > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.x > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18955: - Status: Needs Committer (was: Review In Progress) > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.0, 5.x > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18955: - Fix Version/s: (was: 5.0) > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.x > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18955: - Reviewers: Brandon Williams, Brandon Williams Brandon Williams, Brandon Williams (was: Brandon Williams) Status: Review In Progress (was: Patch Available) > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.0, 5.x > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxwell Guo updated CASSANDRA-18955: Test and Documentation Plan: ut Status: Patch Available (was: Open) > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.0, 5.x > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxwell Guo updated CASSANDRA-18955: Bug Category: Parent values: Correctness(12982) Complexity: Low Hanging Fruit Discovered By: Unit Test Fix Version/s: 5.0 5.x Severity: Normal Status: Open (was: Triage Needed) > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.0, 5.x > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
